From: Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
To: James Bottomley
<James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
Cc: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
Linux EFI <linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Matt Fleming
<matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>,
Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
X86-ML <x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH 0/4] EFI 1:1 mapping
Date: Mon, 3 Jun 2013 17:24:35 +0100 [thread overview]
Message-ID: <20130603162435.GA22563@srcf.ucam.org> (raw)
In-Reply-To: <1370276286.2910.29.camel@dabdike>
On Mon, Jun 03, 2013 at 09:18:06AM -0700, James Bottomley wrote:
> I don't entirely buy that. All EFI programs run with the physical
> address map, therefore every API an EFI program uses is also tested, at
> boot time only, obviously.
That seems optimistic. Windows never calls QueryVariableInfo() during
boot services, so what makes you think doing so has ever been tested?
> However, the ExitBootServices() code seems to be much simpler, so I
> don't think it will cause too many bugs. The UEFI test suites also
> seem to try UEFI calls before and after ExitBootServices(), so I think
> relying on a 1:1 mapping looks safer to me.
I have no expectation that the majority of system vendors run the test
suite, but I have every expectation that every system vendor runs
Windows. We should behave as close to the tested mechanism as possible,
ie do what Windows does - and that includes calling
SetVirtualAddressMap().
--
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Borislav Petkov <bp@alien8.de>,
Linux EFI <linux-efi@vger.kernel.org>,
Matt Fleming <matt@console-pimps.org>,
Jiri Kosina <jkosina@suse.cz>, X86-ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH 0/4] EFI 1:1 mapping
Date: Mon, 3 Jun 2013 17:24:35 +0100 [thread overview]
Message-ID: <20130603162435.GA22563@srcf.ucam.org> (raw)
In-Reply-To: <1370276286.2910.29.camel@dabdike>
On Mon, Jun 03, 2013 at 09:18:06AM -0700, James Bottomley wrote:
> I don't entirely buy that. All EFI programs run with the physical
> address map, therefore every API an EFI program uses is also tested, at
> boot time only, obviously.
That seems optimistic. Windows never calls QueryVariableInfo() during
boot services, so what makes you think doing so has ever been tested?
> However, the ExitBootServices() code seems to be much simpler, so I
> don't think it will cause too many bugs. The UEFI test suites also
> seem to try UEFI calls before and after ExitBootServices(), so I think
> relying on a 1:1 mapping looks safer to me.
I have no expectation that the majority of system vendors run the test
suite, but I have every expectation that every system vendor runs
Windows. We should behave as close to the tested mechanism as possible,
ie do what Windows does - and that includes calling
SetVirtualAddressMap().
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-06-03 16:24 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-02 12:56 [PATCH 0/4] EFI 1:1 mapping Borislav Petkov
2013-06-02 12:56 ` Borislav Petkov
[not found] ` <1370177770-26661-1-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2013-06-02 12:56 ` [PATCH 1/4] efi: Convert runtime services function ptrs Borislav Petkov
2013-06-02 12:56 ` Borislav Petkov
2013-06-06 10:07 ` Matt Fleming
[not found] ` <20130606100745.GF30420-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-11 6:49 ` Matt Fleming
2013-06-11 6:49 ` Matt Fleming
[not found] ` <20130611064912.GG31198-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-11 9:33 ` Borislav Petkov
2013-06-11 9:33 ` Borislav Petkov
2013-06-02 12:56 ` [PATCH 2/4] x86, cpa: Map in an arbitrary pgd Borislav Petkov
2013-06-02 12:56 ` Borislav Petkov
[not found] ` <1370177770-26661-3-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2013-06-06 10:22 ` Matt Fleming
2013-06-06 10:22 ` Matt Fleming
[not found] ` <20130606102233.GG30420-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-06 13:24 ` Borislav Petkov
2013-06-06 13:24 ` Borislav Petkov
2013-06-06 13:30 ` Matt Fleming
[not found] ` <20130606133023.GJ30420-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-06 13:33 ` Borislav Petkov
2013-06-06 13:33 ` Borislav Petkov
2013-06-02 12:56 ` [PATCH 3/4] x86, efi: Add an efi= kernel command line parameter Borislav Petkov
2013-06-02 12:56 ` Borislav Petkov
[not found] ` <1370177770-26661-4-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2013-06-04 12:18 ` Borislav Petkov
2013-06-04 12:18 ` Borislav Petkov
2013-06-06 10:42 ` Matt Fleming
2013-06-06 10:42 ` Matt Fleming
[not found] ` <20130606104224.GH30420-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-06 13:26 ` Borislav Petkov
2013-06-06 13:26 ` Borislav Petkov
[not found] ` <20130606132603.GD20972-fF5Pk5pvG8Y@public.gmane.org>
2013-06-06 13:36 ` Matt Fleming
2013-06-06 13:36 ` Matt Fleming
2013-06-06 17:50 ` Matthew Garrett
2013-06-06 17:50 ` Matthew Garrett
[not found] ` <20130606175052.GA1285-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-06 18:51 ` Borislav Petkov
2013-06-06 18:51 ` Borislav Petkov
[not found] ` <20130606185140.GK20972-fF5Pk5pvG8Y@public.gmane.org>
2013-06-06 19:35 ` Matthew Garrett
2013-06-06 19:35 ` Matthew Garrett
[not found] ` <20130606193548.GA2946-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-06 19:41 ` Borislav Petkov
2013-06-06 19:41 ` Borislav Petkov
[not found] ` <20130606194134.GN20972-fF5Pk5pvG8Y@public.gmane.org>
2013-06-06 19:54 ` Matthew Garrett
2013-06-06 19:54 ` Matthew Garrett
2013-06-06 20:07 ` Borislav Petkov
[not found] ` <20130606200705.GO20972-fF5Pk5pvG8Y@public.gmane.org>
2013-06-06 20:18 ` Matthew Garrett
2013-06-06 20:18 ` Matthew Garrett
2013-06-06 20:27 ` Borislav Petkov
[not found] ` <20130606202717.GP20972-fF5Pk5pvG8Y@public.gmane.org>
2013-06-06 20:30 ` Matthew Garrett
2013-06-06 20:30 ` Matthew Garrett
[not found] ` <20130606203057.GA4237-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-06 20:44 ` Borislav Petkov
2013-06-06 20:44 ` Borislav Petkov
[not found] ` <20130606204410.GQ20972-fF5Pk5pvG8Y@public.gmane.org>
2013-06-06 20:50 ` Matthew Garrett
2013-06-06 20:50 ` Matthew Garrett
[not found] ` <20130606205057.GA4363-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-06 21:02 ` Borislav Petkov
2013-06-06 21:02 ` Borislav Petkov
[not found] ` <20130606210218.GR20972-fF5Pk5pvG8Y@public.gmane.org>
2013-06-06 21:03 ` Matthew Garrett
2013-06-06 21:03 ` Matthew Garrett
2013-06-02 12:56 ` [PATCH 4/4] x86, efi: Map runtime services 1:1 Borislav Petkov
2013-06-02 12:56 ` Borislav Petkov
[not found] ` <1370177770-26661-5-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2013-06-06 13:14 ` Matt Fleming
2013-06-06 13:14 ` Matt Fleming
[not found] ` <20130606131439.GI30420-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-06 13:29 ` Borislav Petkov
2013-06-06 13:29 ` Borislav Petkov
[not found] ` <20130606132908.GE20972-fF5Pk5pvG8Y@public.gmane.org>
2013-06-06 15:58 ` Borislav Petkov
2013-06-06 15:58 ` Borislav Petkov
2013-06-06 19:28 ` H. Peter Anvin
[not found] ` <51B0E2D4.3040007-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-06-06 19:36 ` Borislav Petkov
2013-06-06 19:36 ` Borislav Petkov
[not found] ` <20130606193612.GM20972-fF5Pk5pvG8Y@public.gmane.org>
2013-06-06 19:38 ` H. Peter Anvin
2013-06-06 19:38 ` H. Peter Anvin
[not found] ` <51B0E522.4070005-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-06-10 12:55 ` Borislav Petkov
2013-06-10 12:55 ` Borislav Petkov
2013-06-02 22:56 ` [PATCH 0/4] EFI 1:1 mapping Matthew Garrett
[not found] ` <20130602225620.GA5496-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-03 8:11 ` Borislav Petkov
2013-06-03 8:11 ` Borislav Petkov
[not found] ` <20130603081148.GB13607-K5JNixvcfoxupOikMc4+xw@public.gmane.org>
2013-06-03 14:27 ` James Bottomley
2013-06-03 14:27 ` James Bottomley
2013-06-03 14:30 ` Matthew Garrett
2013-06-03 14:30 ` Matthew Garrett
2013-06-03 14:38 ` James Bottomley
2013-06-03 15:21 ` Matthew Garrett
2013-06-03 15:21 ` Matthew Garrett
2013-06-03 16:18 ` James Bottomley
2013-06-03 16:24 ` Matthew Garrett [this message]
2013-06-03 16:24 ` Matthew Garrett
[not found] ` <20130603162435.GA22563-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-03 16:35 ` James Bottomley
2013-06-03 16:35 ` James Bottomley
2013-06-03 16:42 ` Matthew Garrett
2013-06-03 16:42 ` Matthew Garrett
[not found] ` <20130603164237.GA23146-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-03 18:05 ` James Bottomley
2013-06-03 18:05 ` James Bottomley
2013-06-03 18:11 ` Matthew Garrett
2013-06-03 18:11 ` Matthew Garrett
[not found] ` <20130603181110.GA25060-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-03 21:19 ` James Bottomley
2013-06-03 21:19 ` James Bottomley
2013-06-03 21:29 ` Matthew Garrett
2013-06-03 21:29 ` Matthew Garrett
2014-02-10 3:59 ` Linux, UEFI, and Chromebooks (was RE: [PATCH 0/4] EFI 1:1 mapping) Yuhong Bao
2014-02-10 3:59 ` Yuhong Bao
2013-06-03 14:32 ` [PATCH 0/4] EFI 1:1 mapping Matthew Garrett
[not found] ` <20130603143252.GB20252-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-03 14:54 ` Matt Fleming
2013-06-03 14:54 ` Matt Fleming
[not found] ` <20130603145412.GJ2004-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-04 8:15 ` Borislav Petkov
2013-06-04 8:15 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603162435.GA22563@srcf.ucam.org \
--to=mjg59-1xo5oi07kqx4cg9nei1l7q@public.gmane.org \
--cc=James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=bp-l3A5Bk7waGM@public.gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.