From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64
Date: Mon, 3 Jun 2013 17:25:18 +0100 [thread overview]
Message-ID: <20130603162517.GC32295@arm.com> (raw)
In-Reply-To: <1370273624-26976-5-git-send-email-stefano.stabellini@eu.citrix.com>
On Mon, Jun 03, 2013 at 04:33:44PM +0100, Stefano Stabellini wrote:
> --- /dev/null
> +++ b/arch/arm64/xen/hypercall.S
...
> +/*
> + * The Xen hypercall calling convention is very similar to the ARM AEBI
> + * procedure calling convention: the first paramter is passed in x0, the
> + * second in x1, the third in x2 and the fourth in x3. Considering that
> + * Xen hypercalls have 5 arguments at most, the fifth paramter is passed
> + * in rx, differently from the procedure calling convention of using the
> + * stack for that case.
You may want to use the AArch64 ABI here where parameters are passed in
x0-x7, return in x0.
BTW, I think it's missing a MAINTAINERS file update.
Otherwise, the series looks good. How do you plan to upstream this?
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Will Deacon <Will.Deacon@arm.com>,
"Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
Subject: Re: [PATCH v2 5/5] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64
Date: Mon, 3 Jun 2013 17:25:18 +0100 [thread overview]
Message-ID: <20130603162517.GC32295@arm.com> (raw)
In-Reply-To: <1370273624-26976-5-git-send-email-stefano.stabellini@eu.citrix.com>
On Mon, Jun 03, 2013 at 04:33:44PM +0100, Stefano Stabellini wrote:
> --- /dev/null
> +++ b/arch/arm64/xen/hypercall.S
...
> +/*
> + * The Xen hypercall calling convention is very similar to the ARM AEBI
> + * procedure calling convention: the first paramter is passed in x0, the
> + * second in x1, the third in x2 and the fourth in x3. Considering that
> + * Xen hypercalls have 5 arguments at most, the fifth paramter is passed
> + * in rx, differently from the procedure calling convention of using the
> + * stack for that case.
You may want to use the AArch64 ABI here where parameters are passed in
x0-x7, return in x0.
BTW, I think it's missing a MAINTAINERS file update.
Otherwise, the series looks good. How do you plan to upstream this?
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 5/5] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64
Date: Mon, 3 Jun 2013 17:25:18 +0100 [thread overview]
Message-ID: <20130603162517.GC32295@arm.com> (raw)
In-Reply-To: <1370273624-26976-5-git-send-email-stefano.stabellini@eu.citrix.com>
On Mon, Jun 03, 2013 at 04:33:44PM +0100, Stefano Stabellini wrote:
> --- /dev/null
> +++ b/arch/arm64/xen/hypercall.S
...
> +/*
> + * The Xen hypercall calling convention is very similar to the ARM AEBI
> + * procedure calling convention: the first paramter is passed in x0, the
> + * second in x1, the third in x2 and the fourth in x3. Considering that
> + * Xen hypercalls have 5 arguments at most, the fifth paramter is passed
> + * in rx, differently from the procedure calling convention of using the
> + * stack for that case.
You may want to use the AArch64 ABI here where parameters are passed in
x0-x7, return in x0.
BTW, I think it's missing a MAINTAINERS file update.
Otherwise, the series looks good. How do you plan to upstream this?
--
Catalin
next prev parent reply other threads:[~2013-06-03 16:25 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 15:32 [PATCH v2 0/5] Introduce Xen support to ARM64 Stefano Stabellini
2013-06-03 15:32 ` Stefano Stabellini
2013-06-03 15:32 ` Stefano Stabellini
2013-06-03 15:33 ` [PATCH v2 1/5] arm/xen: define xen_remap as ioremap_cached Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-04 9:20 ` Ian Campbell
2013-06-04 9:20 ` Ian Campbell
2013-06-04 9:20 ` Ian Campbell
2013-06-04 11:28 ` Catalin Marinas
2013-06-04 11:28 ` Catalin Marinas
2013-06-04 11:35 ` Stefano Stabellini
2013-06-04 11:35 ` Stefano Stabellini
2013-06-04 13:58 ` Russell King - ARM Linux
2013-06-04 13:58 ` Russell King - ARM Linux
2013-06-04 14:14 ` Stefano Stabellini
2013-06-04 14:14 ` Stefano Stabellini
2013-06-04 16:26 ` Catalin Marinas
2013-06-04 16:26 ` Catalin Marinas
2013-06-04 16:26 ` Catalin Marinas
2013-06-03 15:33 ` [PATCH v2 2/5] arm64/xen: introduce asm/xen header files on arm64 Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-04 9:24 ` Ian Campbell
2013-06-04 9:24 ` Ian Campbell
2013-06-04 9:24 ` Ian Campbell
2013-06-03 15:33 ` [PATCH v2 3/5] arm64/xen: implement ioremap_cached " Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-03 15:33 ` [PATCH v2 4/5] arm64/xen: use XEN_IO_PROTO_ABI_ARM on ARM64 Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-04 9:25 ` Ian Campbell
2013-06-04 9:25 ` Ian Campbell
2013-06-04 9:25 ` Ian Campbell
2013-06-03 15:33 ` [PATCH v2 5/5] arm64/xen: introduce CONFIG_XEN and hypercall.S " Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-03 15:33 ` Stefano Stabellini
2013-06-03 16:25 ` Catalin Marinas [this message]
2013-06-03 16:25 ` Catalin Marinas
2013-06-03 16:25 ` Catalin Marinas
2013-06-03 16:37 ` [Xen-devel] " Ian Campbell
2013-06-03 16:37 ` Ian Campbell
2013-06-03 16:43 ` Catalin Marinas
2013-06-03 16:43 ` Catalin Marinas
2013-06-03 16:43 ` Catalin Marinas
2013-06-03 16:51 ` Stefano Stabellini
2013-06-03 16:51 ` Stefano Stabellini
2013-06-05 13:21 ` Catalin Marinas
2013-06-05 13:21 ` Catalin Marinas
2013-06-04 14:47 ` Konrad Rzeszutek Wilk
2013-06-04 14:47 ` Konrad Rzeszutek Wilk
2013-06-04 16:27 ` Catalin Marinas
2013-06-04 16:27 ` Catalin Marinas
2013-06-04 16:27 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603162517.GC32295@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.