From: Greg KH <gregkh@linuxfoundation.org>
To: Jingchang Lu <b35083@freescale.com>
Cc: linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, shawn.guo@linaro.org,
s.hauer@pengutronix.de
Subject: Re: [PATCH v5] tty: serial: add Freescale lpuart driver support
Date: Mon, 3 Jun 2013 10:29:08 -0700 [thread overview]
Message-ID: <20130603172908.GA3272@kroah.com> (raw)
In-Reply-To: <1369893217-27809-1-git-send-email-b35083@freescale.com>
On Thu, May 30, 2013 at 01:53:37PM +0800, Jingchang Lu wrote:
> Add Freescale lpuart driver support. The lpuart device
> can be found on Vybrid VF610 and Layerscape LS-1 SoCs.
>
> Signed-off-by: Jingchang Lu <b35083@freescale.com>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> changes in v5:
> Coding style fix, remove redundant code.
> Checking clk_prepare_enable return value.
> Using devm_ioremap_resource instead of devm_request_and_ioremap.
>
> changes in v4:
> Change Vybrid VF610 SoC compatible string to "fsl,vf610-lpuart"
>
> changes in v3:
> Use general driver name lpuart instead of mvf for further share between SoCs.
> Add bind doc in Documentation/devicetree/bindings/tty/serial.
> Remove unused #include header lines and clean up code.
>
> changes in v2:
> Remove unused variables and clean up the code.
>
> .../devicetree/bindings/tty/serial/fsl-lpuart.txt | 14 +
> drivers/tty/serial/Kconfig | 14 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/fsl_lpuart.c | 873 +++++++++++++++++++++
> include/uapi/linux/serial_core.h | 3 +
> 5 files changed, 905 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/tty/serial/fsl-lpuart.txt
> create mode 100644 drivers/tty/serial/fsl_lpuart.c
>
> diff --git a/Documentation/devicetree/bindings/tty/serial/fsl-lpuart.txt b/Documentation/devicetree/bindings/tty/serial/fsl-lpuart.txt
> new file mode 100644
> index 0000000..6fd1dd1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/tty/serial/fsl-lpuart.txt
> @@ -0,0 +1,14 @@
> +* Freescale low power universal asynchronous receiver/transmitter (lpuart)
> +
> +Required properties:
> +- compatible : Should be "fsl,<soc>-lpuart"
> +- reg : Address and length of the register set for the device
> +- interrupts : Should contain uart interrupt
> +
> +Example:
> +
> +uart0: serial@40027000 {
> + compatible = "fsl,vf610-lpuart";
> + reg = <0x40027000 0x1000>;
> + interrupts = <0 61 0x00>;
> + };
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 7e7006f..aee7030 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1484,6 +1484,20 @@ config SERIAL_RP2_NR_UARTS
> If multiple cards are present, the default limit of 32 ports may
> need to be increased.
>
> +config SERIAL_FSL_LPUART
> + bool "Freescale lpuart serial port support"
Why can't this be built as a module? I can't force users to only build
this driver into the kernel, sorry.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] tty: serial: add Freescale lpuart driver support
Date: Mon, 3 Jun 2013 10:29:08 -0700 [thread overview]
Message-ID: <20130603172908.GA3272@kroah.com> (raw)
In-Reply-To: <1369893217-27809-1-git-send-email-b35083@freescale.com>
On Thu, May 30, 2013 at 01:53:37PM +0800, Jingchang Lu wrote:
> Add Freescale lpuart driver support. The lpuart device
> can be found on Vybrid VF610 and Layerscape LS-1 SoCs.
>
> Signed-off-by: Jingchang Lu <b35083@freescale.com>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> changes in v5:
> Coding style fix, remove redundant code.
> Checking clk_prepare_enable return value.
> Using devm_ioremap_resource instead of devm_request_and_ioremap.
>
> changes in v4:
> Change Vybrid VF610 SoC compatible string to "fsl,vf610-lpuart"
>
> changes in v3:
> Use general driver name lpuart instead of mvf for further share between SoCs.
> Add bind doc in Documentation/devicetree/bindings/tty/serial.
> Remove unused #include header lines and clean up code.
>
> changes in v2:
> Remove unused variables and clean up the code.
>
> .../devicetree/bindings/tty/serial/fsl-lpuart.txt | 14 +
> drivers/tty/serial/Kconfig | 14 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/fsl_lpuart.c | 873 +++++++++++++++++++++
> include/uapi/linux/serial_core.h | 3 +
> 5 files changed, 905 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/tty/serial/fsl-lpuart.txt
> create mode 100644 drivers/tty/serial/fsl_lpuart.c
>
> diff --git a/Documentation/devicetree/bindings/tty/serial/fsl-lpuart.txt b/Documentation/devicetree/bindings/tty/serial/fsl-lpuart.txt
> new file mode 100644
> index 0000000..6fd1dd1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/tty/serial/fsl-lpuart.txt
> @@ -0,0 +1,14 @@
> +* Freescale low power universal asynchronous receiver/transmitter (lpuart)
> +
> +Required properties:
> +- compatible : Should be "fsl,<soc>-lpuart"
> +- reg : Address and length of the register set for the device
> +- interrupts : Should contain uart interrupt
> +
> +Example:
> +
> +uart0: serial at 40027000 {
> + compatible = "fsl,vf610-lpuart";
> + reg = <0x40027000 0x1000>;
> + interrupts = <0 61 0x00>;
> + };
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 7e7006f..aee7030 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1484,6 +1484,20 @@ config SERIAL_RP2_NR_UARTS
> If multiple cards are present, the default limit of 32 ports may
> need to be increased.
>
> +config SERIAL_FSL_LPUART
> + bool "Freescale lpuart serial port support"
Why can't this be built as a module? I can't force users to only build
this driver into the kernel, sorry.
greg k-h
next prev parent reply other threads:[~2013-06-03 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 5:53 [PATCH v5] tty: serial: add Freescale lpuart driver support Jingchang Lu
2013-05-30 5:53 ` Jingchang Lu
2013-05-30 8:16 ` Shawn Guo
2013-05-30 8:16 ` Shawn Guo
2013-06-03 17:29 ` Greg KH [this message]
2013-06-03 17:29 ` Greg KH
2013-06-04 2:08 ` Lu Jingchang-B35083
2013-06-04 2:08 ` Lu Jingchang-B35083
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603172908.GA3272@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b35083@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.