From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-tegra@vger.kernel.org, Joseph Lo <josephl@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH] ARM: tegra: remove the ifdef of ARCH SoC in the tegra_resume
Date: Tue, 4 Jun 2013 00:48:13 +0200 [thread overview]
Message-ID: <201306040048.13612.arnd@arndb.de> (raw)
In-Reply-To: <51ACB59D.9030005@wwwdotorg.org>
On Monday 03 June 2013, Stephen Warren wrote:
> Was that ifdef completely incorrect before? I can see why the cmp/beq
> might be ifdef'd (although it's not worth it), but I assume the code
> after that beq was intended to run on all chips after Tegra20. The ifdef
> as it was written does something rather different; it prevents any of
> that code from running unless the kernel doesn't have Tegra20 support.
> So, I think that the removal of the ifdef is more of a bug-fix that
> "because we always build with all Tegra SoCs support. Let me know, and
> I'll re-write the commit description to something more accurate...
The #ifdef was recently changed from #if TEGRA3 to #if !TEGRA2, which support
for TEGRA4 was added. I think this is where it broke.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: remove the ifdef of ARCH SoC in the tegra_resume
Date: Tue, 4 Jun 2013 00:48:13 +0200 [thread overview]
Message-ID: <201306040048.13612.arnd@arndb.de> (raw)
In-Reply-To: <51ACB59D.9030005@wwwdotorg.org>
On Monday 03 June 2013, Stephen Warren wrote:
> Was that ifdef completely incorrect before? I can see why the cmp/beq
> might be ifdef'd (although it's not worth it), but I assume the code
> after that beq was intended to run on all chips after Tegra20. The ifdef
> as it was written does something rather different; it prevents any of
> that code from running unless the kernel doesn't have Tegra20 support.
> So, I think that the removal of the ifdef is more of a bug-fix that
> "because we always build with all Tegra SoCs support. Let me know, and
> I'll re-write the commit description to something more accurate...
The #ifdef was recently changed from #if TEGRA3 to #if !TEGRA2, which support
for TEGRA4 was added. I think this is where it broke.
Arnd
next prev parent reply other threads:[~2013-06-03 22:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 8:10 [PATCH] ARM: tegra: remove the ifdef of ARCH SoC in the tegra_resume Joseph Lo
2013-06-03 8:10 ` Joseph Lo
[not found] ` <1370247004-31846-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-03 15:26 ` Stephen Warren
2013-06-03 15:26 ` Stephen Warren
2013-06-03 22:48 ` Arnd Bergmann [this message]
2013-06-03 22:48 ` Arnd Bergmann
[not found] ` <201306040048.13612.arnd-r2nGTMty4D4@public.gmane.org>
2013-06-04 1:25 ` Joseph Lo
2013-06-04 1:25 ` Joseph Lo
2013-06-05 17:44 ` Stephen Warren
2013-06-05 17:44 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306040048.13612.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.