From: Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
Joel A Fernandes <joelagnel-l0cyMroinI0@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH RFC 2/3] ARM: dts: omap4 clock data
Date: Tue, 04 Jun 2013 11:34:49 -0700 [thread overview]
Message-ID: <20130604183449.10233.48956@quantum> (raw)
In-Reply-To: <20130604145543.GK3331-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Quoting Tony Lindgren (2013-06-04 07:55:43)
> * Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> [130603 23:45]:
> > This is a first pass at creating a unique node for each clock in the
> > OMAP4 power, reset and & clock manager (PRCM). So far I have only
> > converted mux clocks & fixed-rate clocks, which coexist with the current
> > clock data in the kernel. The rest needs to be done but better to
> > publish early and often to see what others think of this approach.
>
> > +/* FIXME need to print the address directly */
> > +/*
> > +#include "../../mach-omap2/prm44xx.h"
> > +#include "../../mach-omap2/cm2_44xx.h"
> > +#include "../../mach-omap2/cm1_44xx.h"
> > +*/
>
> I don't think you're using the above includes any longer
> in this file?
>
Correct. I actually spotted this before emailing the patches out at
midnight, but by then I didn't care to fix it. The benefits of marking
a patch as "RFC" ;-)
I had a mind to use the new preprocessor capabilities of dtc for the
PRCM bit masks and shift values, but instead I ended up using the raw
hex values. I've actually come to prefer using the raw hex values for
DT, which I think makes more sense for a description of the hardware
which is not tied to any Linux implementation.
Regards,
Mike
> Regards,
>
> Tony
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 2/3] ARM: dts: omap4 clock data
Date: Tue, 04 Jun 2013 11:34:49 -0700 [thread overview]
Message-ID: <20130604183449.10233.48956@quantum> (raw)
In-Reply-To: <20130604145543.GK3331@atomide.com>
Quoting Tony Lindgren (2013-06-04 07:55:43)
> * Mike Turquette <mturquette@linaro.org> [130603 23:45]:
> > This is a first pass at creating a unique node for each clock in the
> > OMAP4 power, reset and & clock manager (PRCM). So far I have only
> > converted mux clocks & fixed-rate clocks, which coexist with the current
> > clock data in the kernel. The rest needs to be done but better to
> > publish early and often to see what others think of this approach.
>
> > +/* FIXME need to print the address directly */
> > +/*
> > +#include "../../mach-omap2/prm44xx.h"
> > +#include "../../mach-omap2/cm2_44xx.h"
> > +#include "../../mach-omap2/cm1_44xx.h"
> > +*/
>
> I don't think you're using the above includes any longer
> in this file?
>
Correct. I actually spotted this before emailing the patches out at
midnight, but by then I didn't care to fix it. The benefits of marking
a patch as "RFC" ;-)
I had a mind to use the new preprocessor capabilities of dtc for the
PRCM bit masks and shift values, but instead I ended up using the raw
hex values. I've actually come to prefer using the raw hex values for
DT, which I think makes more sense for a description of the hardware
which is not tied to any Linux implementation.
Regards,
Mike
> Regards,
>
> Tony
next prev parent reply other threads:[~2013-06-04 18:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 6:39 [PATCH RFC 0/3] first pass converting omap4 clock data to DT Mike Turquette
2013-06-04 6:39 ` Mike Turquette
2013-06-04 6:39 ` [PATCH RFC 1/3] clk: omap: introduce clock driver Mike Turquette
2013-06-04 6:39 ` Mike Turquette
2013-06-04 14:52 ` Tony Lindgren
2013-06-04 14:52 ` Tony Lindgren
2013-06-14 22:12 ` Grant Likely
2013-06-14 22:12 ` Grant Likely
2013-06-04 6:39 ` [PATCH RFC 2/3] ARM: dts: omap4 clock data Mike Turquette
2013-06-04 6:39 ` Mike Turquette
2013-06-04 14:55 ` Tony Lindgren
2013-06-04 14:55 ` Tony Lindgren
[not found] ` <20130604145543.GK3331-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-06-04 18:34 ` Mike Turquette [this message]
2013-06-04 18:34 ` Mike Turquette
2013-06-04 19:37 ` Tony Lindgren
2013-06-04 19:37 ` Tony Lindgren
2013-06-04 6:39 ` [PATCH RFC 3/3] ARM: omap4: register DT clocks & remove old data Mike Turquette
2013-06-04 6:39 ` Mike Turquette
2013-06-04 13:28 ` [PATCH RFC 0/3] first pass converting omap4 clock data to DT Tero Kristo
2013-06-04 13:28 ` Tero Kristo
2013-06-05 6:45 ` Mike Turquette
2013-06-05 6:45 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604183449.10233.48956@quantum \
--to=mturquette-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=joelagnel-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.