From: "John W. Linville" <linville@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, arend@broadcom.com
Subject: Re: pull request: wireless 2013-06-03
Date: Tue, 4 Jun 2013 16:56:30 -0400 [thread overview]
Message-ID: <20130604205630.GA11199@tuxdriver.com> (raw)
In-Reply-To: <20130604.131813.134898245916084893.davem@davemloft.net>
On Tue, Jun 04, 2013 at 01:18:13PM -0700, David Miller wrote:
> From: "John W. Linville" <linville@tuxdriver.com>
> Date: Mon, 3 Jun 2013 14:48:17 -0400
>
> > Please let me know if there are problems!
>
> Sorry, the broadcom brcmfmac changes need to go.
>
> Some of those commits are cleanups, and some of them have the worst
> commit log messages ever, the last one for example:
>
> 0017-brcmsmac-fix-regression-observed-in-3.10-rc1.patch
>
> has no explanation whatsoever of what the actual problem or regression
> is, what aspect of the logic in that function is causing the problem,
> and no explanation why making this function always return 'false' is a
> reasonable fix.
>
> That entire series is of very low quality, and even if it was in good
> shape, at least half the changes are not appropriate at all this late
> in the -rc series.
OK, sorry Dave -- I knew better...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
arend-dY08KVG/lbpWk0Htik3J/w@public.gmane.org
Subject: Re: pull request: wireless 2013-06-03
Date: Tue, 4 Jun 2013 16:56:30 -0400 [thread overview]
Message-ID: <20130604205630.GA11199@tuxdriver.com> (raw)
In-Reply-To: <20130604.131813.134898245916084893.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On Tue, Jun 04, 2013 at 01:18:13PM -0700, David Miller wrote:
> From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
> Date: Mon, 3 Jun 2013 14:48:17 -0400
>
> > Please let me know if there are problems!
>
> Sorry, the broadcom brcmfmac changes need to go.
>
> Some of those commits are cleanups, and some of them have the worst
> commit log messages ever, the last one for example:
>
> 0017-brcmsmac-fix-regression-observed-in-3.10-rc1.patch
>
> has no explanation whatsoever of what the actual problem or regression
> is, what aspect of the logic in that function is causing the problem,
> and no explanation why making this function always return 'false' is a
> reasonable fix.
>
> That entire series is of very low quality, and even if it was in good
> shape, at least half the changes are not appropriate at all this late
> in the -rc series.
OK, sorry Dave -- I knew better...
John
--
John W. Linville Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-04 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 18:48 pull request: wireless 2013-06-03 John W. Linville
2013-06-03 18:48 ` John W. Linville
2013-06-04 20:18 ` David Miller
2013-06-04 20:56 ` John W. Linville [this message]
2013-06-04 20:56 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604205630.GA11199@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=arend@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.