All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
	bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 3/3] memcg: simplify mem_cgroup_reclaim_iter
Date: Wed, 5 Jun 2013 10:50:21 -0400	[thread overview]
Message-ID: <20130605145021.GR15576@cmpxchg.org> (raw)
In-Reply-To: <20130605143949.GQ15576-druUgvl0LCNAfugRpC6u6w@public.gmane.org>

On Wed, Jun 05, 2013 at 10:39:49AM -0400, Johannes Weiner wrote:
> On Wed, Jun 05, 2013 at 01:20:23AM -0700, Tejun Heo wrote:
> > Hello, Michal.
> > 
> > On Wed, Jun 05, 2013 at 09:30:23AM +0200, Michal Hocko wrote:
> > > > We aren't talking about something gigantic or can
> > > 
> > > mem_cgroup is 888B now (depending on configuration). So I wouldn't call
> > > it negligible.
> > 
> > Do you think that the number can actually grow harmful?  Would you be
> > kind enough to share some calculations with me?
> 
> 5k cgroups * say 10 priority levels * 1k struct mem_cgroup may pin 51M
> of dead struct mem_cgroup, plus whatever else the css pins.

Bleh, ... * nr_node_ids * MAX_NR_ZONES.  So it is a couple hundred MB
in that case.

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Tejun Heo <tj@kernel.org>
Cc: Michal Hocko <mhocko@suse.cz>,
	bsingharora@gmail.com, cgroups@vger.kernel.org,
	linux-mm@kvack.org, lizefan@huawei.com
Subject: Re: [PATCH 3/3] memcg: simplify mem_cgroup_reclaim_iter
Date: Wed, 5 Jun 2013 10:50:21 -0400	[thread overview]
Message-ID: <20130605145021.GR15576@cmpxchg.org> (raw)
In-Reply-To: <20130605143949.GQ15576@cmpxchg.org>

On Wed, Jun 05, 2013 at 10:39:49AM -0400, Johannes Weiner wrote:
> On Wed, Jun 05, 2013 at 01:20:23AM -0700, Tejun Heo wrote:
> > Hello, Michal.
> > 
> > On Wed, Jun 05, 2013 at 09:30:23AM +0200, Michal Hocko wrote:
> > > > We aren't talking about something gigantic or can
> > > 
> > > mem_cgroup is 888B now (depending on configuration). So I wouldn't call
> > > it negligible.
> > 
> > Do you think that the number can actually grow harmful?  Would you be
> > kind enough to share some calculations with me?
> 
> 5k cgroups * say 10 priority levels * 1k struct mem_cgroup may pin 51M
> of dead struct mem_cgroup, plus whatever else the css pins.

Bleh, ... * nr_node_ids * MAX_NR_ZONES.  So it is a couple hundred MB
in that case.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2013-06-05 14:50 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04  0:44 [PATCHSET] memcg: fix and reimplement iterator Tejun Heo
2013-06-04  0:44 ` Tejun Heo
     [not found] ` <1370306679-13129-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-04  0:44   ` [PATCH 1/3] memcg: fix subtle memory barrier bug in mem_cgroup_iter() Tejun Heo
2013-06-04  0:44     ` Tejun Heo
2013-06-04 13:03     ` Michal Hocko
     [not found]       ` <20130604130336.GE31242-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-06-04 13:58         ` Johannes Weiner
2013-06-04 13:58           ` Johannes Weiner
2013-06-04 15:29           ` Michal Hocko
2013-06-04  0:44   ` [PATCH 2/3] memcg: restructure mem_cgroup_iter() Tejun Heo
2013-06-04  0:44     ` Tejun Heo
     [not found]     ` <1370306679-13129-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-04 13:21       ` Michal Hocko
2013-06-04 13:21         ` Michal Hocko
2013-06-04 20:51         ` Tejun Heo
2013-06-04  0:44   ` [PATCH 3/3] memcg: simplify mem_cgroup_reclaim_iter Tejun Heo
2013-06-04  0:44     ` Tejun Heo
     [not found]     ` <1370306679-13129-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-04 13:18       ` Michal Hocko
2013-06-04 13:18         ` Michal Hocko
     [not found]         ` <20130604131843.GF31242-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-06-04 20:50           ` Tejun Heo
2013-06-04 20:50             ` Tejun Heo
2013-06-04 21:28             ` Michal Hocko
2013-06-04 21:55               ` Tejun Heo
2013-06-05  7:30                 ` Michal Hocko
2013-06-05  8:20                   ` Tejun Heo
2013-06-05  8:36                     ` Michal Hocko
2013-06-05  8:44                       ` Tejun Heo
2013-06-05  8:55                         ` Michal Hocko
2013-06-05  9:03                           ` Tejun Heo
     [not found]                     ` <20130605082023.GG7303-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-05 14:39                       ` Johannes Weiner
2013-06-05 14:39                         ` Johannes Weiner
     [not found]                         ` <20130605143949.GQ15576-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-06-05 14:50                           ` Johannes Weiner [this message]
2013-06-05 14:50                             ` Johannes Weiner
2013-06-05 17:22                           ` Tejun Heo
2013-06-05 17:22                             ` Tejun Heo
     [not found]                             ` <20130605172212.GA10693-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-05 19:45                               ` Johannes Weiner
2013-06-05 19:45                                 ` Johannes Weiner
     [not found]                                 ` <20130605194552.GI15721-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-06-05 20:06                                   ` Tejun Heo
2013-06-05 20:06                                     ` Tejun Heo
2013-06-05 21:17                                     ` Johannes Weiner
2013-06-05 22:20                                       ` Tejun Heo
     [not found]                                         ` <20130605222021.GL10693-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-05 22:27                                           ` Tejun Heo
2013-06-05 22:27                                             ` Tejun Heo
2013-06-06 11:50                                             ` Michal Hocko
2013-06-07  0:52                                               ` Tejun Heo
     [not found]                                                 ` <20130607005242.GB16160-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-06-07  7:37                                                   ` Michal Hocko
2013-06-07  7:37                                                     ` Michal Hocko
2013-06-07 23:25                                                     ` Tejun Heo
     [not found]                                                       ` <20130607232557.GL14781-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-10  8:02                                                         ` Michal Hocko
2013-06-10  8:02                                                           ` Michal Hocko
2013-06-10 19:54                                                           ` Tejun Heo
2013-06-10 20:48                                                             ` Michal Hocko
     [not found]                                                               ` <20130610204801.GA21003-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-06-10 23:13                                                                 ` Tejun Heo
2013-06-10 23:13                                                                   ` Tejun Heo
2013-06-11  7:27                                                                   ` Michal Hocko
2013-06-11  7:44                                                                     ` Tejun Heo
     [not found]                                                                       ` <20130611074404.GE22530-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-06-11  7:55                                                                         ` Michal Hocko
2013-06-11  7:55                                                                           ` Michal Hocko
2013-06-11  8:00                                                                           ` Tejun Heo
2013-06-05 14:56                         ` Michal Hocko
2013-06-04 21:40             ` Johannes Weiner
     [not found]               ` <20130604214050.GP15576-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-06-04 21:49                 ` Tejun Heo
2013-06-04 21:49                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130605145021.GR15576@cmpxchg.org \
    --to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
    --cc=bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.