All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org, yongjie.ren@intel.com
Subject: Regression after "Remove support for reporting coalesced APIC IRQs"
Date: Thu, 6 Jun 2013 11:53:52 +0300	[thread overview]
Message-ID: <20130606085352.GZ4725@redhat.com> (raw)

Hi Jan,

I bisected [1] to f1ed0450a5fac7067590317cbf027f566b6ccbca. Fortunately
further investigation showed that it is not really related to removing
APIC timer interrupt reinjection and the real problem is that we cannot
assume that __apic_accept_irq() always injects interrupts like the patch
does because the function skips interrupt injection if APIC is disabled.
This misreporting screws RTC interrupt tracking, so further RTC interrupt
are stopped to be injected. The simplest solution that I see is to revert
most of the commit and only leave APIC timer interrupt reinjection.

If you have more elegant solution let me know.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=58931
--
			Gleb.

             reply	other threads:[~2013-06-06  8:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06  8:53 Gleb Natapov [this message]
2013-06-06 15:39 ` Regression after "Remove support for reporting coalesced APIC IRQs" Ren, Yongjie
2013-06-20 11:47 ` Gleb Natapov
2013-06-20 20:10   ` Jan Kiszka
2013-06-20 20:29     ` Gleb Natapov
2013-06-20 21:01       ` Jan Kiszka
2013-06-23  9:13         ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130606085352.GZ4725@redhat.com \
    --to=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=yongjie.ren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.