All of lore.kernel.org
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Alexey Kodanev <alexey.kodanev@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] configure: add configure checks to compile kernel modules
Date: Thu, 6 Jun 2013 12:57:36 +0200	[thread overview]
Message-ID: <20130606105736.GA23876@rei> (raw)
In-Reply-To: <1370433674-6838-1-git-send-email-alexey.kodanev@oracle.com>

Hi!
> There're new configure options added to tune modules building process.
> New m4 function tries to determine if kernel-devel package is available
> and sets makefile's variables (WITH_MODULES, ...) accordingly.
> 
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>

This part looks fine.

Maybe it would be better to include detected kernel version in the
configure output as well, but apart from that it's ok.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2013-06-06 10:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 12:01 [LTP] [PATCH] configure: add configure checks to compile kernel modules Alexey Kodanev
2013-06-06 10:57 ` chrubis [this message]
     [not found]   ` <51B0716B.2090107@oracle.com>
2013-06-06 13:56     ` chrubis
  -- strict thread matches above, loose matches on Subject: below --
2013-06-06 14:13 Alexey Kodanev
2013-06-06 14:21 Alexey Kodanev
2013-06-11  1:31 ` Mike Frysinger
2013-06-11  9:34   ` alexey.kodanev
2013-06-11 17:04     ` Mike Frysinger
2013-06-11  1:32 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130606105736.GA23876@rei \
    --to=chrubis@suse.cz \
    --cc=alexey.kodanev@oracle.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=vasily.isaenko@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.