Re: [LTP] [PATCH] configure: add configure checks to compile kernel modules

[alexey.kodanev@oracle.com]

On 06/11/2013 05:31 AM, Mike Frysinger wrote:
> On Thursday 06 June 2013 10:21:47 Alexey Kodanev wrote:
>
> you've apparently deleted the phrase "either version 2 of the License, or (at
> your option) any later version.".  i have no idea why you would do such a
> thing, but it's obviously not desirable.  apparently this isn't the first time
> as i see you've done it in at least 0e335dbed65afb79eab5b30e8d49d8066f165316.
>
> please send a patch to fix your previous commits, and fix this one as well.  or
> i'm afraid we'll have to revert.
>
Sure, I will fix it.
> defaulting like this won't work.  you need to check $cross_compiling is set to
> yes in order to default to `uname -r`.
>
> seems like it'd be simpler to just do:
> 	AC_ARG_WITH([linux-version], [AC_HELP_STRING(...)],,
> 		AS_IF([test "$cross_compiling" != no],
> 			[with_linux_version=`uname -r`]))
> 	LINUX_VERSION=$with_linux_version
> 	AC_SUBST(LINUX_VERSION)
>
May be defaulting it to `uname -r` when $cross_compiling is set to no?

Thanks,
Alexey

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list