From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64
Date: Thu, 6 Jun 2013 15:42:12 +0100 [thread overview]
Message-ID: <20130606144212.GK28479@arm.com> (raw)
In-Reply-To: <1471793.18ZhhAHKN9@wuerfel>
Hi Arnd,
On Wed, Jun 05, 2013 at 01:44:55PM +0100, Arnd Bergmann wrote:
> On Wednesday 05 June 2013 13:15:29 Stefano Stabellini wrote:
> > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> > index c95c5cb..79dd13d 100644
> > --- a/arch/arm64/Makefile
> > +++ b/arch/arm64/Makefile
> > @@ -37,6 +37,7 @@ TEXT_OFFSET := 0x00080000
> > export TEXT_OFFSET GZFLAGS
> >
> > core-y += arch/arm64/kernel/ arch/arm64/mm/
> > +core-$(CONFIG_XEN) += arch/arm64/xen/
> > libs-y := arch/arm64/lib/ $(libs-y)
> > libs-y += $(LIBGCC)
> >
> > diff --git a/arch/arm64/xen/Makefile b/arch/arm64/xen/Makefile
> > new file mode 100644
> > index 0000000..be24040
> > --- /dev/null
> > +++ b/arch/arm64/xen/Makefile
> > @@ -0,0 +1,2 @@
> > +xen-arm-y += $(addprefix ../../arm/xen/, enlighten.o grant-table.o)
> > +obj-y := xen-arm.o hypercall.o
>
> I think it would be nicer to redirect the entire directory, not just
> the enlighten.o and grant-table.o files. You could do in arch/arm64/Makefile:
>
> core-(CONFIG_XEN) += arch/arm/xen/
>
> That leaves a small difference in hypercall.o, which I think you can
> handle with an #ifdef.
Sorry, I missed this part. I want to keep the AArch64 assembly under
arm64, even if it is small.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64
Date: Thu, 6 Jun 2013 15:42:12 +0100 [thread overview]
Message-ID: <20130606144212.GK28479@arm.com> (raw)
In-Reply-To: <1471793.18ZhhAHKN9@wuerfel>
Hi Arnd,
On Wed, Jun 05, 2013 at 01:44:55PM +0100, Arnd Bergmann wrote:
> On Wednesday 05 June 2013 13:15:29 Stefano Stabellini wrote:
> > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> > index c95c5cb..79dd13d 100644
> > --- a/arch/arm64/Makefile
> > +++ b/arch/arm64/Makefile
> > @@ -37,6 +37,7 @@ TEXT_OFFSET := 0x00080000
> > export TEXT_OFFSET GZFLAGS
> >
> > core-y += arch/arm64/kernel/ arch/arm64/mm/
> > +core-$(CONFIG_XEN) += arch/arm64/xen/
> > libs-y := arch/arm64/lib/ $(libs-y)
> > libs-y += $(LIBGCC)
> >
> > diff --git a/arch/arm64/xen/Makefile b/arch/arm64/xen/Makefile
> > new file mode 100644
> > index 0000000..be24040
> > --- /dev/null
> > +++ b/arch/arm64/xen/Makefile
> > @@ -0,0 +1,2 @@
> > +xen-arm-y += $(addprefix ../../arm/xen/, enlighten.o grant-table.o)
> > +obj-y := xen-arm.o hypercall.o
>
> I think it would be nicer to redirect the entire directory, not just
> the enlighten.o and grant-table.o files. You could do in arch/arm64/Makefile:
>
> core-(CONFIG_XEN) += arch/arm/xen/
>
> That leaves a small difference in hypercall.o, which I think you can
> handle with an #ifdef.
Sorry, I missed this part. I want to keep the AArch64 assembly under
arm64, even if it is small.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64
Date: Thu, 6 Jun 2013 15:42:12 +0100 [thread overview]
Message-ID: <20130606144212.GK28479@arm.com> (raw)
In-Reply-To: <1471793.18ZhhAHKN9@wuerfel>
Hi Arnd,
On Wed, Jun 05, 2013 at 01:44:55PM +0100, Arnd Bergmann wrote:
> On Wednesday 05 June 2013 13:15:29 Stefano Stabellini wrote:
> > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> > index c95c5cb..79dd13d 100644
> > --- a/arch/arm64/Makefile
> > +++ b/arch/arm64/Makefile
> > @@ -37,6 +37,7 @@ TEXT_OFFSET := 0x00080000
> > export TEXT_OFFSET GZFLAGS
> >
> > core-y += arch/arm64/kernel/ arch/arm64/mm/
> > +core-$(CONFIG_XEN) += arch/arm64/xen/
> > libs-y := arch/arm64/lib/ $(libs-y)
> > libs-y += $(LIBGCC)
> >
> > diff --git a/arch/arm64/xen/Makefile b/arch/arm64/xen/Makefile
> > new file mode 100644
> > index 0000000..be24040
> > --- /dev/null
> > +++ b/arch/arm64/xen/Makefile
> > @@ -0,0 +1,2 @@
> > +xen-arm-y += $(addprefix ../../arm/xen/, enlighten.o grant-table.o)
> > +obj-y := xen-arm.o hypercall.o
>
> I think it would be nicer to redirect the entire directory, not just
> the enlighten.o and grant-table.o files. You could do in arch/arm64/Makefile:
>
> core-(CONFIG_XEN) += arch/arm/xen/
>
> That leaves a small difference in hypercall.o, which I think you can
> handle with an #ifdef.
Sorry, I missed this part. I want to keep the AArch64 assembly under
arm64, even if it is small.
--
Catalin
next prev parent reply other threads:[~2013-06-06 14:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 12:14 [PATCH v3 0/6] Introduce Xen support to ARM64 Stefano Stabellini
2013-06-05 12:14 ` Stefano Stabellini
2013-06-05 12:14 ` Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 1/6] arm/xen: define xen_remap as ioremap_cached Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 2/6] arm64/xen: introduce asm/xen header files on arm64 Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 3/6] arm64/xen: implement ioremap_cached " Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 4/6] arm64/xen: use XEN_IO_PROTO_ABI_ARM on ARM64 Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S " Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:23 ` Ian Campbell
2013-06-05 12:23 ` Ian Campbell
2013-06-05 12:23 ` Ian Campbell
2013-06-05 12:38 ` Stefano Stabellini
2013-06-05 12:38 ` Stefano Stabellini
2013-06-05 12:38 ` Stefano Stabellini
2013-06-05 12:44 ` Arnd Bergmann
2013-06-05 12:44 ` Arnd Bergmann
2013-06-05 12:50 ` Will Deacon
2013-06-05 12:50 ` Will Deacon
2013-06-05 14:43 ` Christopher Covington
2013-06-05 14:43 ` Christopher Covington
2013-06-05 13:04 ` Stefano Stabellini
2013-06-05 13:04 ` Stefano Stabellini
2013-06-05 13:04 ` Stefano Stabellini
2013-06-06 14:42 ` Catalin Marinas [this message]
2013-06-06 14:42 ` Catalin Marinas
2013-06-06 14:42 ` Catalin Marinas
2013-06-06 16:19 ` Stefano Stabellini
2013-06-06 16:19 ` Stefano Stabellini
2013-06-05 12:15 ` [PATCH v3 6/6] MAINTAINERS: add myself as arm64/xen maintainer Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:15 ` Stefano Stabellini
2013-06-05 12:23 ` Ian Campbell
2013-06-05 12:23 ` Ian Campbell
2013-06-05 12:23 ` Ian Campbell
2013-06-05 14:27 ` Konrad Rzeszutek Wilk
2013-06-05 14:27 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606144212.GK28479@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.