From: Al Viro <viro@ZenIV.linux.org.uk>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] GFS2: Add atomic_open support
Date: Thu, 6 Jun 2013 18:53:12 +0100 [thread overview]
Message-ID: <20130606175312.GG13110@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1370530212.2744.34.camel@menhir>
On Thu, Jun 06, 2013 at 03:50:12PM +0100, Steven Whitehouse wrote:
>
> The following patch implements atomic_open for GFS2. This is mostly
> straightforward, however there is one corner case which I've had to
> deal with, beyond what would normally be expected for a local
> filesystem.
Broken - what will happen if you hit a symlink, for starters? On everything
handled locally you should just return finish_no_open(file, dentry) and
let the caller deal with that; the only cases that might make sense to
handle in ->atomic_open() are regular files and directories. For gfs2 it
should be just regular files. While we are at it, do you even need
->private_data for gfs2 directories?
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Steven Whitehouse <swhiteho@redhat.com>
Cc: cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, jlayton@redhat.com,
"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: GFS2: Add atomic_open support
Date: Thu, 6 Jun 2013 18:53:12 +0100 [thread overview]
Message-ID: <20130606175312.GG13110@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1370530212.2744.34.camel@menhir>
On Thu, Jun 06, 2013 at 03:50:12PM +0100, Steven Whitehouse wrote:
>
> The following patch implements atomic_open for GFS2. This is mostly
> straightforward, however there is one corner case which I've had to
> deal with, beyond what would normally be expected for a local
> filesystem.
Broken - what will happen if you hit a symlink, for starters? On everything
handled locally you should just return finish_no_open(file, dentry) and
let the caller deal with that; the only cases that might make sense to
handle in ->atomic_open() are regular files and directories. For gfs2 it
should be just regular files. While we are at it, do you even need
->private_data for gfs2 directories?
next prev parent reply other threads:[~2013-06-06 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 14:50 [Cluster-devel] GFS2: Add atomic_open support Steven Whitehouse
2013-06-06 14:50 ` Steven Whitehouse
2013-06-06 17:53 ` Al Viro [this message]
2013-06-06 17:53 ` Al Viro
2013-06-07 10:54 ` [Cluster-devel] " Steven Whitehouse
2013-06-07 10:54 ` Steven Whitehouse
2013-06-11 14:04 ` [Cluster-devel] " Steven Whitehouse
2013-06-11 14:04 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606175312.GG13110@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.