From: Dave Jones <davej@redhat.com>
To: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
Cc: Cong Wang <amwang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data
Date: Thu, 6 Jun 2013 16:09:33 -0400 [thread overview]
Message-ID: <20130606200932.GB3837@redhat.com> (raw)
In-Reply-To: <51B0EA30.3020804@linux.vnet.ibm.com>
On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
> > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
> > + if (vi->mergeable_rx_bufs)
> > + hdr_len = sizeof hdr->mhdr;
> > + else
> > + hdr_len = sizeof hdr->hdr;
>
> All conditionals need braces.
Documentation/CodingStyle disagrees:
"Do not unnecessarily use braces where a single statement will do."
Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
"David S. Miller" <davem@davemloft.net>,
Jason Wang <jasowang@redhat.com>, Cong Wang <amwang@redhat.com>,
Amos Kong <akong@redhat.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data
Date: Thu, 6 Jun 2013 16:09:33 -0400 [thread overview]
Message-ID: <20130606200932.GB3837@redhat.com> (raw)
In-Reply-To: <51B0EA30.3020804@linux.vnet.ibm.com>
On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
> > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
> > + if (vi->mergeable_rx_bufs)
> > + hdr_len = sizeof hdr->mhdr;
> > + else
> > + hdr_len = sizeof hdr->hdr;
>
> All conditionals need braces.
Documentation/CodingStyle disagrees:
"Do not unnecessarily use braces where a single statement will do."
Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
Cc: Cong Wang <amwang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, netdev@vger.kernel.org,
Jason Wang <jasowang@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Amos Kong <akong@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data
Date: Thu, 6 Jun 2013 16:09:33 -0400 [thread overview]
Message-ID: <20130606200932.GB3837@redhat.com> (raw)
In-Reply-To: <51B0EA30.3020804@linux.vnet.ibm.com>
On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
> > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
> > + if (vi->mergeable_rx_bufs)
> > + hdr_len = sizeof hdr->mhdr;
> > + else
> > + hdr_len = sizeof hdr->hdr;
>
> All conditionals need braces.
Documentation/CodingStyle disagrees:
"Do not unnecessarily use braces where a single statement will do."
Dave
next prev parent reply other threads:[~2013-06-06 20:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 9:55 [PATCH] virtio-net: put virtio net header inline with data Michael S. Tsirkin
2013-06-06 9:55 ` [Qemu-devel] " Michael S. Tsirkin
2013-06-06 19:59 ` Jesse Larrew
2013-06-06 19:59 ` Jesse Larrew
2013-06-06 20:09 ` Dave Jones [this message]
2013-06-06 20:09 ` Dave Jones
2013-06-06 20:09 ` Dave Jones
2013-06-06 20:18 ` Jesse Larrew
2013-06-06 20:18 ` Jesse Larrew
2013-06-07 2:12 ` Rusty Russell
2013-06-07 2:12 ` [Qemu-devel] " Rusty Russell
2013-06-09 7:11 ` Michael S. Tsirkin
2013-06-09 7:11 ` [Qemu-devel] " Michael S. Tsirkin
2013-06-09 7:11 ` Michael S. Tsirkin
2013-06-07 2:52 ` Jason Wang
2013-06-07 2:52 ` [Qemu-devel] " Jason Wang
2013-06-07 2:52 ` Jason Wang
2013-06-09 6:52 ` Michael S. Tsirkin
2013-06-09 6:52 ` [Qemu-devel] " Michael S. Tsirkin
2013-06-09 6:52 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2013-07-08 10:12 Michael S. Tsirkin
2013-07-09 2:16 ` Rusty Russell
2013-07-11 13:00 ` [Qemu-devel] " Michael S. Tsirkin
2013-07-12 5:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606200932.GB3837@redhat.com \
--to=davej@redhat.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=jlarrew@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.