From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmatest: do not allow to interrupt ongoing tests
Date: Fri, 7 Jun 2013 06:15:25 +0530 [thread overview]
Message-ID: <20130607004525.GH23045@intel.com> (raw)
In-Reply-To: <20130605171001.GC26663@mudshark.cambridge.arm.com>
On Wed, Jun 05, 2013 at 06:10:01PM +0100, Will Deacon wrote:
> On Mon, May 27, 2013 at 08:11:07AM +0100, Andy Shevchenko wrote:
> > On Fri, 2013-05-24 at 23:55 +0200, Guennadi Liakhovetski wrote:
> > > On Thu, 23 May 2013, Andy Shevchenko wrote:
> > >
> > > > When user interrupts ongoing transfers the dmatest may end up with console
> > > > lockup, oops, or data mismatch. This patch prevents user to abort any ongoing
> > > > test.
> > >
> > > Personally I would be against such a change. What about interrupting the
> > > test with rmmod?
> > > Is it still possible after this your patch or not? If not
> > > - this doesn't seem like a good idea to me. Why don't we just fix those
> > > bugs, that you're describing?
> >
> > The behaviour of the module is returned to the same page by this patch
> > as it was before (w/o debugfs).
> >
> > The user can interrupt tests by rmmod, but it will take time up to
> > timeout.
> >
> > I appreciate if you can do a deeper analysis of what happened in
> > case Will reported.
>
> Did this query hold up the application of this patch? I'd really like to see
> *something* in 3.10, otherwise dmatest will be broken.
I though we had some data corruption on subsequent tests, or was that different
one?
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.jf.intel.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"djbw@fb.com" <djbw@fb.com>
Subject: Re: [PATCH] dmatest: do not allow to interrupt ongoing tests
Date: Fri, 7 Jun 2013 06:15:25 +0530 [thread overview]
Message-ID: <20130607004525.GH23045@intel.com> (raw)
In-Reply-To: <20130605171001.GC26663@mudshark.cambridge.arm.com>
On Wed, Jun 05, 2013 at 06:10:01PM +0100, Will Deacon wrote:
> On Mon, May 27, 2013 at 08:11:07AM +0100, Andy Shevchenko wrote:
> > On Fri, 2013-05-24 at 23:55 +0200, Guennadi Liakhovetski wrote:
> > > On Thu, 23 May 2013, Andy Shevchenko wrote:
> > >
> > > > When user interrupts ongoing transfers the dmatest may end up with console
> > > > lockup, oops, or data mismatch. This patch prevents user to abort any ongoing
> > > > test.
> > >
> > > Personally I would be against such a change. What about interrupting the
> > > test with rmmod?
> > > Is it still possible after this your patch or not? If not
> > > - this doesn't seem like a good idea to me. Why don't we just fix those
> > > bugs, that you're describing?
> >
> > The behaviour of the module is returned to the same page by this patch
> > as it was before (w/o debugfs).
> >
> > The user can interrupt tests by rmmod, but it will take time up to
> > timeout.
> >
> > I appreciate if you can do a deeper analysis of what happened in
> > case Will reported.
>
> Did this query hold up the application of this patch? I'd really like to see
> *something* in 3.10, otherwise dmatest will be broken.
I though we had some data corruption on subsequent tests, or was that different
one?
--
~Vinod
next prev parent reply other threads:[~2013-06-07 0:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 11:29 [PATCH] dmatest: do not allow to interrupt ongoing tests Andy Shevchenko
2013-05-23 11:29 ` Andy Shevchenko
2013-05-24 21:55 ` Guennadi Liakhovetski
2013-05-27 7:11 ` Andy Shevchenko
2013-05-27 7:11 ` Andy Shevchenko
2013-06-05 17:10 ` Will Deacon
2013-06-05 17:10 ` Will Deacon
2013-06-05 17:25 ` Guennadi Liakhovetski
2013-06-05 17:25 ` Guennadi Liakhovetski
2013-06-05 17:33 ` Andy Shevchenko
2013-06-05 17:33 ` Andy Shevchenko
2013-06-07 0:45 ` Vinod Koul [this message]
2013-06-07 0:45 ` Vinod Koul
2013-06-07 8:44 ` Will Deacon
2013-06-07 8:44 ` Will Deacon
2013-06-07 20:45 ` Vinod Koul
2013-06-07 20:45 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607004525.GH23045@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.