From: Dan Carpenter <dan.carpenter@oracle.com>
To: Simon Horman <horms@verge.net.au>
Cc: Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ipvs: info leak in __ip_vs_get_dest_entries()
Date: Fri, 07 Jun 2013 08:33:14 +0000 [thread overview]
Message-ID: <20130607083314.GQ23987@mwanda> (raw)
In-Reply-To: <20130604010327.GA23054@verge.net.au>
On Mon, Jun 03, 2013 at 06:03:27PM -0700, Simon Horman wrote:
> On Mon, Jun 03, 2013 at 12:00:49PM +0300, Dan Carpenter wrote:
> > The entry struct has a 2 byte hole after ->port and another 4 byte
> > hole after ->stats.outpkts. You must have CAP_NET_ADMIN in your
> > namespace to hit this information leak.
>
> Hi Dan,
>
> can I verify that it is actually possible to hit this and
> thus the patch is a -stable candidate?
This is a static checker fix. To me it seems like it's obviously a
real info leak.
I'm not certain of the impact though. CLONE_NEWNET requires
CAP_SYS_ADMIN but on the other hand people are making virtualization
products where they give everyone their own namespace with admin
privileges.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Simon Horman <horms@verge.net.au>
Cc: Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ipvs: info leak in __ip_vs_get_dest_entries()
Date: Fri, 7 Jun 2013 11:33:14 +0300 [thread overview]
Message-ID: <20130607083314.GQ23987@mwanda> (raw)
In-Reply-To: <20130604010327.GA23054@verge.net.au>
On Mon, Jun 03, 2013 at 06:03:27PM -0700, Simon Horman wrote:
> On Mon, Jun 03, 2013 at 12:00:49PM +0300, Dan Carpenter wrote:
> > The entry struct has a 2 byte hole after ->port and another 4 byte
> > hole after ->stats.outpkts. You must have CAP_NET_ADMIN in your
> > namespace to hit this information leak.
>
> Hi Dan,
>
> can I verify that it is actually possible to hit this and
> thus the patch is a -stable candidate?
This is a static checker fix. To me it seems like it's obviously a
real info leak.
I'm not certain of the impact though. CLONE_NEWNET requires
CAP_SYS_ADMIN but on the other hand people are making virtualization
products where they give everyone their own namespace with admin
privileges.
regards,
dan carpenter
next prev parent reply other threads:[~2013-06-07 8:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 9:00 [patch] ipvs: info leak in __ip_vs_get_dest_entries() Dan Carpenter
2013-06-03 9:00 ` Dan Carpenter
2013-06-03 20:00 ` Julian Anastasov
2013-06-03 20:00 ` Julian Anastasov
2013-06-04 1:03 ` Simon Horman
2013-06-04 1:03 ` Simon Horman
2013-06-07 8:33 ` Dan Carpenter [this message]
2013-06-07 8:33 ` Dan Carpenter
2013-06-10 8:38 ` Simon Horman
2013-06-10 8:38 ` Simon Horman
2013-06-10 12:58 ` Pablo Neira Ayuso
2013-06-10 12:58 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607083314.GQ23987@mwanda \
--to=dan.carpenter@oracle.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.