From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Nicolas Pitre <nico@fluxnic.net>,
Lior Amsalem <alior@marvell.com>,
Maen Suleiman <maen@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Shadi Ammouri <shadi@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Yehuda Yitschak <yehuday@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Ike Pan <ike.pan@canonical.com>,
Chris Van Hoof <vanhoof@canonical.com>,
Dan Frazier <dann.frazier@canonical.com>,
Leif Lindholm <leif.lindholm@arm.com>,
Jon Masters <jcm@redhat.com>, David Marlin <dmarlin@redhat.com>,
linux-kernel@vger.kernel.org, Zbigniew Bodek <zbb@semihalf.com>
Subject: Re: [PATCH 1/2] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889)
Date: Fri, 7 Jun 2013 18:25:00 +0200 [thread overview]
Message-ID: <20130607182500.10593e73@skate> (raw)
In-Reply-To: <1370620140-17177-2-git-send-email-gregory.clement@free-electrons.com>
Dear Gregory CLEMENT,
On Fri, 7 Jun 2013 17:48:59 +0200, Gregory CLEMENT wrote:
> +/*
> + * 5us delay in order to avoid repeated start
> + * timing violation on Armada XP SoC.
> + */
> +static int mv64xxx_i2c_errata_delay;
This should probably be a per-I2C controller variable, i.e in
mv64xxx_i2c_data.
> + if (!mv64xxx_i2c_errata_delay &&
> + of_machine_is_compatible("marvell,armadaxp"))
> + mv64xxx_i2c_errata_delay = 1;
I am wondering whether it should be done this way, or using a separate
DT property.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889)
Date: Fri, 7 Jun 2013 18:25:00 +0200 [thread overview]
Message-ID: <20130607182500.10593e73@skate> (raw)
In-Reply-To: <1370620140-17177-2-git-send-email-gregory.clement@free-electrons.com>
Dear Gregory CLEMENT,
On Fri, 7 Jun 2013 17:48:59 +0200, Gregory CLEMENT wrote:
> +/*
> + * 5us delay in order to avoid repeated start
> + * timing violation on Armada XP SoC.
> + */
> +static int mv64xxx_i2c_errata_delay;
This should probably be a per-I2C controller variable, i.e in
mv64xxx_i2c_data.
> + if (!mv64xxx_i2c_errata_delay &&
> + of_machine_is_compatible("marvell,armadaxp"))
> + mv64xxx_i2c_errata_delay = 1;
I am wondering whether it should be done this way, or using a separate
DT property.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-06-07 16:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 15:48 [PATCH 0/2] i2c-mv64xxx: Various fixes Gregory CLEMENT
2013-06-07 15:48 ` Gregory CLEMENT
2013-06-07 15:48 ` Gregory CLEMENT
[not found] ` <1370620140-17177-1-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-06-07 15:48 ` [PATCH 1/2] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889) Gregory CLEMENT
2013-06-07 15:48 ` Gregory CLEMENT
2013-06-07 15:48 ` Gregory CLEMENT
2013-06-07 16:25 ` Thomas Petazzoni [this message]
2013-06-07 16:25 ` Thomas Petazzoni
2013-06-14 15:24 ` Wolfram Sang
2013-06-14 15:24 ` Wolfram Sang
2013-06-14 15:24 ` Wolfram Sang
2013-06-07 15:49 ` [PATCH 2/2] i2c-mv64xxx: Abort the mv64xxx_of_config if clock-frequency is not provided Gregory CLEMENT
2013-06-07 15:49 ` Gregory CLEMENT
2013-06-07 15:49 ` Gregory CLEMENT
[not found] ` <1370620140-17177-3-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-06-14 15:23 ` Wolfram Sang
2013-06-14 15:23 ` Wolfram Sang
2013-06-14 15:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607182500.10593e73@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=benavi@marvell.com \
--cc=dann.frazier@canonical.com \
--cc=dmarlin@redhat.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=ike.pan@canonical.com \
--cc=jason@lakedaemon.net \
--cc=jcm@redhat.com \
--cc=leif.lindholm@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maen@marvell.com \
--cc=nadavh@marvell.com \
--cc=nico@fluxnic.net \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shadi@marvell.com \
--cc=tawfik@marvell.com \
--cc=vanhoof@canonical.com \
--cc=wsa@the-dreams.de \
--cc=yehuday@marvell.com \
--cc=zbb@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.