From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: andrew@lunn.ch, Bill Pemberton <wfp5p@virginia.edu>,
artem.bityutskiy@linux.intel.com,
Jingoo Han <jg1.han@samsung.com>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Emil Goode <emilgoode@gmail.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe
Date: Sun, 09 Jun 2013 20:57:47 +0000 [thread overview]
Message-ID: <20130609205747.GX23987@mwanda> (raw)
In-Reply-To: <CAHp75VcOMUVtfgXOQ+cyVpJN-XS7=yO1H8+8Nnw+LCgYWp7RPw@mail.gmail.com>
On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote:
>
> []
>
> >> What about another patch (that I guess should go first) that converts
> >> printk to dev_* or pr_*?
>
> > Huh, what? Those are two totally unrelated things. Emil's patch is
> > a bug fix.
>
> To be precise his patch is bugfix and cleanup at once.
> My proposal is to add a clean up patch.
The printk idea isn't a bad one, it's just totally unrelated to what
the patch is doing. You can't just randomly tell people to do a
bunch of work for no reason. "Good bugfix, but before we apply it
you have to mow my lawn."
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: andrew@lunn.ch, Bill Pemberton <wfp5p@virginia.edu>,
artem.bityutskiy@linux.intel.com,
Jingoo Han <jg1.han@samsung.com>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Emil Goode <emilgoode@gmail.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe
Date: Sun, 9 Jun 2013 23:57:47 +0300 [thread overview]
Message-ID: <20130609205747.GX23987@mwanda> (raw)
In-Reply-To: <CAHp75VcOMUVtfgXOQ+cyVpJN-XS7=yO1H8+8Nnw+LCgYWp7RPw@mail.gmail.com>
On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote:
>
> []
>
> >> What about another patch (that I guess should go first) that converts
> >> printk to dev_* or pr_*?
>
> > Huh, what? Those are two totally unrelated things. Emil's patch is
> > a bug fix.
>
> To be precise his patch is bugfix and cleanup at once.
> My proposal is to add a clean up patch.
The printk idea isn't a bad one, it's just totally unrelated to what
the patch is doing. You can't just randomly tell people to do a
bunch of work for no reason. "Good bugfix, but before we apply it
you have to mow my lawn."
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Emil Goode <emilgoode@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
artem.bityutskiy@linux.intel.com, andrew@lunn.ch,
Bill Pemberton <wfp5p@virginia.edu>,
Jingoo Han <jg1.han@samsung.com>,
linux-mtd@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe
Date: Sun, 9 Jun 2013 23:57:47 +0300 [thread overview]
Message-ID: <20130609205747.GX23987@mwanda> (raw)
In-Reply-To: <CAHp75VcOMUVtfgXOQ+cyVpJN-XS7=yO1H8+8Nnw+LCgYWp7RPw@mail.gmail.com>
On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote:
>
> []
>
> >> What about another patch (that I guess should go first) that converts
> >> printk to dev_* or pr_*?
>
> > Huh, what? Those are two totally unrelated things. Emil's patch is
> > a bug fix.
>
> To be precise his patch is bugfix and cleanup at once.
> My proposal is to add a clean up patch.
The printk idea isn't a bad one, it's just totally unrelated to what
the patch is doing. You can't just randomly tell people to do a
bunch of work for no reason. "Good bugfix, but before we apply it
you have to mow my lawn."
regards,
dan carpenter
next prev parent reply other threads:[~2013-06-09 20:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 9:08 [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe Emil Goode
2013-06-09 9:08 ` Emil Goode
2013-06-09 9:08 ` Emil Goode
2013-06-09 17:15 ` Andy Shevchenko
2013-06-09 17:15 ` Andy Shevchenko
2013-06-09 17:15 ` Andy Shevchenko
2013-06-09 19:17 ` Dan Carpenter
2013-06-09 19:17 ` Dan Carpenter
2013-06-09 19:17 ` Dan Carpenter
2013-06-09 19:27 ` Andy Shevchenko
2013-06-09 19:27 ` Andy Shevchenko
2013-06-09 19:27 ` Andy Shevchenko
2013-06-09 20:57 ` Dan Carpenter [this message]
2013-06-09 20:57 ` Dan Carpenter
2013-06-09 20:57 ` Dan Carpenter
2013-06-09 21:15 ` Andy Shevchenko
2013-06-09 21:15 ` Andy Shevchenko
2013-06-09 21:15 ` Andy Shevchenko
2013-06-09 22:45 ` Emil Goode
2013-06-09 22:45 ` Emil Goode
2013-06-09 22:45 ` Emil Goode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609205747.GX23987@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=emilgoode@gmail.com \
--cc=jg1.han@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.