From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
bhutchings@solarflare.com
Subject: Re: [PATCH 0/2] fix kernel crash with macvtap on top of LRO
Date: Mon, 10 Jun 2013 10:07:11 +0300 [thread overview]
Message-ID: <20130610070710.GA673@redhat.com> (raw)
In-Reply-To: <20130207.131420.1211188723341167971.davem@davemloft.net>
On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Thu, 7 Feb 2013 16:20:46 +0000
>
> > If the consensus is still that we must preserve packets exactly (aside
> > from the usual modifications by IP routers) then LRO should be disabled
> > on all devices for which forwarding is enabled.
>
> I believe this is still undoubtedly the consensus.
With virtio we are getting packets from a linux host,
so we could thinkably preserve packets exactly
even with LRO. I am guessing other hardware could be
doing this as well.
I am not sure what information would need to be preserved -
could someone help clarify please?
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: bhutchings@solarflare.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 0/2] fix kernel crash with macvtap on top of LRO
Date: Mon, 10 Jun 2013 10:07:11 +0300 [thread overview]
Message-ID: <20130610070710.GA673@redhat.com> (raw)
In-Reply-To: <20130207.131420.1211188723341167971.davem@davemloft.net>
On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Thu, 7 Feb 2013 16:20:46 +0000
>
> > If the consensus is still that we must preserve packets exactly (aside
> > from the usual modifications by IP routers) then LRO should be disabled
> > on all devices for which forwarding is enabled.
>
> I believe this is still undoubtedly the consensus.
With virtio we are getting packets from a linux host,
so we could thinkably preserve packets exactly
even with LRO. I am guessing other hardware could be
doing this as well.
I am not sure what information would need to be preserved -
could someone help clarify please?
--
MST
next prev parent reply other threads:[~2013-06-10 7:07 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 23:02 [PATCH 0/2] fix kernel crash with macvtap on top of LRO Michael S. Tsirkin
2013-02-06 23:02 ` Michael S. Tsirkin
2013-02-06 23:02 ` [PATCH 1/2] ixgbe: fix gso type Michael S. Tsirkin
2013-02-06 23:02 ` Michael S. Tsirkin
2013-02-07 3:21 ` Eric Dumazet
2013-02-06 23:02 ` [PATCH 2/2] qlcnic: set gso_type Michael S. Tsirkin
2013-02-06 23:02 ` Michael S. Tsirkin
2013-02-07 3:20 ` Eric Dumazet
2013-02-07 8:16 ` Michael S. Tsirkin
2013-02-07 8:16 ` Michael S. Tsirkin
2013-02-06 23:34 ` [PATCH 0/2] fix kernel crash with macvtap on top of LRO Ben Hutchings
2013-02-06 23:34 ` Ben Hutchings
2013-02-07 3:18 ` Eric Dumazet
2013-02-07 3:18 ` Eric Dumazet
2013-02-07 16:20 ` Ben Hutchings
2013-02-07 16:20 ` Ben Hutchings
2013-02-07 18:14 ` David Miller
2013-02-07 18:14 ` David Miller
2013-02-07 21:33 ` Michael S. Tsirkin
2013-02-07 21:33 ` Michael S. Tsirkin
2013-02-07 22:31 ` Ben Hutchings
2013-02-07 22:31 ` Ben Hutchings
2013-02-11 1:15 ` David Miller
2013-06-10 7:07 ` Michael S. Tsirkin [this message]
2013-06-10 7:07 ` Michael S. Tsirkin
2013-06-12 14:56 ` Ben Hutchings
2013-06-12 14:56 ` Ben Hutchings
2013-06-12 19:00 ` Michael S. Tsirkin
2013-06-12 19:00 ` Michael S. Tsirkin
2013-06-17 1:35 ` Rusty Russell
2013-06-17 1:35 ` Rusty Russell
2013-06-17 16:20 ` Ben Hutchings
2013-06-17 16:20 ` Ben Hutchings
2013-06-18 5:12 ` Rusty Russell
2013-06-18 5:12 ` Rusty Russell
2013-02-07 3:25 ` Cong Wang
2013-02-07 3:25 ` Cong Wang
2013-02-07 8:15 ` Michael S. Tsirkin
2013-02-07 8:15 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610070710.GA673@redhat.com \
--to=mst@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.