All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/06] ARM: shmobile: Remove old SCU boot code
Date: Mon, 10 Jun 2013 09:20:25 +0000	[thread overview]
Message-ID: <20130610092025.18944.77279.sendpatchset@w520> (raw)
In-Reply-To: <20130610091925.18944.68117.sendpatchset@w520>

From: Magnus Damm <damm@opensource.se>

Remove shmobile_secondary_vector_scu now when all SCU enabled
SMP platforms instead make use of shmobile_boot_scu. This
removes two inline virtual to physical address conversions.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 arch/arm/mach-shmobile/headsmp-scu.S         |   22 +---------------------
 arch/arm/mach-shmobile/include/mach/common.h |    1 -
 2 files changed, 1 insertion(+), 22 deletions(-)

--- 0028/arch/arm/mach-shmobile/headsmp-scu.S
+++ work/arch/arm/mach-shmobile/headsmp-scu.S	2013-06-05 14:36:41.000000000 +0900
@@ -25,32 +25,12 @@
 
 	__CPUINIT
 /*
- * Reset vector for secondary CPUs.
+ * Boot code for secondary CPUs.
  *
  * First we turn on L1 cache coherency for our CPU. Then we jump to
  * shmobile_invalidate_start that invalidates the cache and hands over control
  * to the common ARM startup code.
- * This function will be mapped to address 0 by the SBAR register.
- * A normal branch is out of range here so we need a long jump. We jump to
- * the physical address as the MMU is still turned off.
  */
-	.align	12
-ENTRY(shmobile_secondary_vector_scu)
-	mrc     p15, 0, r0, c0, c0, 5	@ read MIPDR
-	and	r0, r0, #3		@ mask out cpu ID
-	lsl	r0, r0, #3		@ we will shift by cpu_id * 8 bits
-	ldr	r1, 2f
-	ldr	r1, [r1]		@ SCU base address
-	ldr	r2, [r1, #8]		@ SCU Power Status Register
-	mov	r3, #3
-	bic	r2, r2, r3, lsl r0	@ Clear bits of our CPU (Run Mode)
-	str	r2, [r1, #8]		@ write back
-
-	ldr	pc, 1f
-1:	.long shmobile_invalidate_start - PAGE_OFFSET + PLAT_PHYS_OFFSET
-2:	.long shmobile_scu_base - PAGE_OFFSET + PLAT_PHYS_OFFSET
-ENDPROC(shmobile_secondary_vector_scu)
-
 ENTRY(shmobile_boot_scu)
 					@ r0 = SCU base address
 	mrc     p15, 0, r1, c0, c0, 5	@ read MIPDR
--- 0028/arch/arm/mach-shmobile/include/mach/common.h
+++ work/arch/arm/mach-shmobile/include/mach/common.h	2013-06-05 14:35:54.000000000 +0900
@@ -10,7 +10,6 @@ extern void shmobile_setup_console(void)
 extern void shmobile_boot_vector(void);
 extern unsigned long shmobile_boot_fn;
 extern unsigned long shmobile_boot_arg;
-extern void shmobile_secondary_vector_scu(void);
 extern void shmobile_boot_scu(void);
 struct clk;
 extern int shmobile_clk_init(void);

WARNING: multiple messages have this Message-ID (diff)
From: magnus.damm@gmail.com (Magnus Damm)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/06] ARM: shmobile: Remove old SCU boot code
Date: Mon, 10 Jun 2013 18:20:25 +0900	[thread overview]
Message-ID: <20130610092025.18944.77279.sendpatchset@w520> (raw)
In-Reply-To: <20130610091925.18944.68117.sendpatchset@w520>

From: Magnus Damm <damm@opensource.se>

Remove shmobile_secondary_vector_scu now when all SCU enabled
SMP platforms instead make use of shmobile_boot_scu. This
removes two inline virtual to physical address conversions.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 arch/arm/mach-shmobile/headsmp-scu.S         |   22 +---------------------
 arch/arm/mach-shmobile/include/mach/common.h |    1 -
 2 files changed, 1 insertion(+), 22 deletions(-)

--- 0028/arch/arm/mach-shmobile/headsmp-scu.S
+++ work/arch/arm/mach-shmobile/headsmp-scu.S	2013-06-05 14:36:41.000000000 +0900
@@ -25,32 +25,12 @@
 
 	__CPUINIT
 /*
- * Reset vector for secondary CPUs.
+ * Boot code for secondary CPUs.
  *
  * First we turn on L1 cache coherency for our CPU. Then we jump to
  * shmobile_invalidate_start that invalidates the cache and hands over control
  * to the common ARM startup code.
- * This function will be mapped to address 0 by the SBAR register.
- * A normal branch is out of range here so we need a long jump. We jump to
- * the physical address as the MMU is still turned off.
  */
-	.align	12
-ENTRY(shmobile_secondary_vector_scu)
-	mrc     p15, 0, r0, c0, c0, 5	@ read MIPDR
-	and	r0, r0, #3		@ mask out cpu ID
-	lsl	r0, r0, #3		@ we will shift by cpu_id * 8 bits
-	ldr	r1, 2f
-	ldr	r1, [r1]		@ SCU base address
-	ldr	r2, [r1, #8]		@ SCU Power Status Register
-	mov	r3, #3
-	bic	r2, r2, r3, lsl r0	@ Clear bits of our CPU (Run Mode)
-	str	r2, [r1, #8]		@ write back
-
-	ldr	pc, 1f
-1:	.long shmobile_invalidate_start - PAGE_OFFSET + PLAT_PHYS_OFFSET
-2:	.long shmobile_scu_base - PAGE_OFFSET + PLAT_PHYS_OFFSET
-ENDPROC(shmobile_secondary_vector_scu)
-
 ENTRY(shmobile_boot_scu)
 					@ r0 = SCU base address
 	mrc     p15, 0, r1, c0, c0, 5	@ read MIPDR
--- 0028/arch/arm/mach-shmobile/include/mach/common.h
+++ work/arch/arm/mach-shmobile/include/mach/common.h	2013-06-05 14:35:54.000000000 +0900
@@ -10,7 +10,6 @@ extern void shmobile_setup_console(void)
 extern void shmobile_boot_vector(void);
 extern unsigned long shmobile_boot_fn;
 extern unsigned long shmobile_boot_arg;
-extern void shmobile_secondary_vector_scu(void);
 extern void shmobile_boot_scu(void);
 struct clk;
 extern int shmobile_clk_init(void);

  parent reply	other threads:[~2013-06-10  9:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10  9:19 [PATCH 00/06] ARM: shmobile: SMP virt_to_phys() conversion Magnus Damm
2013-06-10  9:19 ` Magnus Damm
2013-06-10  9:19 ` [PATCH 01/06] ARM: shmobile: Add SMP boot function and argument Magnus Damm
2013-06-10  9:19   ` Magnus Damm
2013-06-12 14:09   ` Simon Horman
2013-06-12 14:09     ` Simon Horman
2013-06-10  9:19 ` [PATCH 02/06] ARM: shmobile: Add SCU boot function using argument Magnus Damm
2013-06-10  9:19   ` Magnus Damm
2013-06-12 14:09   ` Simon Horman
2013-06-12 14:09     ` Simon Horman
2013-06-10  9:19 ` [PATCH 03/06] ARM: shmobile: r8a7779 SMP with SCU boot fn and args Magnus Damm
2013-06-10  9:19   ` Magnus Damm
2013-06-12 14:09   ` Simon Horman
2013-06-12 14:09     ` Simon Horman
2013-06-10  9:20 ` [PATCH 04/06] ARM: shmobile: sh73a0 " Magnus Damm
2013-06-10  9:20   ` Magnus Damm
2013-06-12 14:09   ` Simon Horman
2013-06-12 14:09     ` Simon Horman
2013-06-10  9:20 ` [PATCH 05/06] ARM: shmobile: EMEV2 " Magnus Damm
2013-06-10  9:20   ` Magnus Damm
2013-06-12 14:09   ` Simon Horman
2013-06-12 14:09     ` Simon Horman
2013-06-10  9:20 ` Magnus Damm [this message]
2013-06-10  9:20   ` [PATCH 06/06] ARM: shmobile: Remove old SCU boot code Magnus Damm
2013-06-12 14:10   ` Simon Horman
2013-06-12 14:10     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130610092025.18944.77279.sendpatchset@w520 \
    --to=magnus.damm@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.