From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Dave Hansen <dave@sr71.net>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Hugh Dickins <hughd@google.com>,
Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Hillf Danton <dhillf@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] thp, mm: avoid PageUnevictable on active/inactive lru lists
Date: Tue, 11 Jun 2013 19:27:07 +0300 (EEST) [thread overview]
Message-ID: <20130611162707.53DCBE0090@blue.fi.intel.com> (raw)
In-Reply-To: <51B74A7A.1040707@sr71.net>
Dave Hansen wrote:
> On 06/11/2013 08:35 AM, Kirill A. Shutemov wrote:
> > active/inactive lru lists can contain unevicable pages (i.e. ramfs pages
> > that have been placed on the LRU lists when first allocated), but these
> > pages must not have PageUnevictable set - otherwise shrink_[in]active_list
> > goes crazy:
>
> I think it's also important here to note if this is a bug that can be
> hit _currently_, or if this really is just a preparatory patch for
> transparent huge page cache.
I've mentioned in cover letter, that don't think the bug can be triggered on
current upstream code.
> From what I can see, this is _needed_ preparatory work, but it can also
> stand on its own because it simplifies things. It should go in sooner
> rather than later.
Right.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Dave Hansen <dave@sr71.net>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Hugh Dickins <hughd@google.com>,
Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Hillf Danton <dhillf@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] thp, mm: avoid PageUnevictable on active/inactive lru lists
Date: Tue, 11 Jun 2013 19:27:07 +0300 (EEST) [thread overview]
Message-ID: <20130611162707.53DCBE0090@blue.fi.intel.com> (raw)
In-Reply-To: <51B74A7A.1040707@sr71.net>
Dave Hansen wrote:
> On 06/11/2013 08:35 AM, Kirill A. Shutemov wrote:
> > active/inactive lru lists can contain unevicable pages (i.e. ramfs pages
> > that have been placed on the LRU lists when first allocated), but these
> > pages must not have PageUnevictable set - otherwise shrink_[in]active_list
> > goes crazy:
>
> I think it's also important here to note if this is a bug that can be
> hit _currently_, or if this really is just a preparatory patch for
> transparent huge page cache.
I've mentioned in cover letter, that don't think the bug can be triggered on
current upstream code.
> From what I can see, this is _needed_ preparatory work, but it can also
> stand on its own because it simplifies things. It should go in sooner
> rather than later.
Right.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2013-06-11 16:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 15:35 [PATCH 0/8] Transparent huge page cache: phase 0, prep work Kirill A. Shutemov
2013-06-11 15:35 ` Kirill A. Shutemov
2013-06-11 15:35 ` [PATCH 1/8] mm: drop actor argument of do_generic_file_read() Kirill A. Shutemov
2013-06-11 15:35 ` Kirill A. Shutemov
2013-06-11 15:35 ` [PATCH 2/8] thp, mm: avoid PageUnevictable on active/inactive lru lists Kirill A. Shutemov
2013-06-11 15:35 ` Kirill A. Shutemov
2013-06-11 16:04 ` Dave Hansen
2013-06-11 16:04 ` Dave Hansen
2013-06-11 16:27 ` Kirill A. Shutemov [this message]
2013-06-11 16:27 ` Kirill A. Shutemov
2013-06-11 15:35 ` [PATCH 3/8] thp: account anon transparent huge pages into NR_ANON_PAGES Kirill A. Shutemov
2013-06-11 15:35 ` Kirill A. Shutemov
2013-06-11 15:35 ` [PATCH 4/8] mm: cleanup add_to_page_cache_locked() Kirill A. Shutemov
2013-06-11 15:35 ` Kirill A. Shutemov
2013-06-11 15:35 ` [PATCH 5/8] thp, mm: locking tail page is a bug Kirill A. Shutemov
2013-06-11 15:35 ` Kirill A. Shutemov
2013-06-11 15:35 ` [PATCH 6/8] thp: move maybe_pmd_mkwrite() out of mk_huge_pmd() Kirill A. Shutemov
2013-06-11 15:35 ` Kirill A. Shutemov
2013-06-11 15:35 ` [PATCH 7/8] thp: do_huge_pmd_anonymous_page() cleanup Kirill A. Shutemov
2013-06-11 15:35 ` Kirill A. Shutemov
2013-06-11 15:35 ` [PATCH 8/8] thp: consolidate code between handle_mm_fault() and do_huge_pmd_anonymous_page() Kirill A. Shutemov
2013-06-11 15:35 ` Kirill A. Shutemov
2013-06-17 15:31 ` [PATCH 0/8] Transparent huge page cache: phase 0, prep work Kirill A. Shutemov
2013-06-17 15:31 ` Kirill A. Shutemov
2013-06-17 15:31 ` Kirill A. Shutemov
2013-06-25 13:57 ` [PING] " Kirill A. Shutemov
2013-06-25 13:57 ` Kirill A. Shutemov
-- strict thread matches above, loose matches on Subject: below --
2013-07-15 10:47 [PATCH, REBASED 0/8] " Kirill A. Shutemov
2013-07-15 10:47 ` [PATCH 2/8] thp, mm: avoid PageUnevictable on active/inactive lru lists Kirill A. Shutemov
2013-07-15 10:47 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130611162707.53DCBE0090@blue.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=dhillf@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.