* [PATCH 0/3] ARM: OMAP2+: devices: Silence hwmod lookup failures (dmic/mcpdm)
@ 2013-06-11 8:31 ` Peter Ujfalusi
0 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2013-06-11 8:31 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Small patches to silence the hwmod lookup failures in case when we boot the
kernel on boards where the IPs are not present (OMAP2/3 vs McPDM, DMIC,
HDMI audio).
Regards,
Peter
---
Peter Ujfalusi (3):
ARM: OMAP2+: devices: Do not print error when McPDM hwmod lookup fails
ARM: OMAP2+: devices: Do not print error when DMIC hwmod lookup fails
ARM: OMAP2+: devices: Do not print error when dss_hdmi hwmod lookup
fails
arch/arm/mach-omap2/devices.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
--
1.8.2.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/3] ARM: OMAP2+: devices: Do not print error when McPDM hwmod lookup fails
2013-06-11 8:31 ` Peter Ujfalusi
@ 2013-06-11 8:31 ` Peter Ujfalusi
-1 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2013-06-11 8:31 UTC (permalink / raw)
To: Tony Lindgren, Paul Walmsley; +Cc: linux-omap, linux-arm-kernel, patches
It means that the SoC does not have McPDM IP.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/devices.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 4269fc1..b82538d 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -374,10 +374,8 @@ static void __init omap_init_mcpdm(void)
struct platform_device *pdev;
oh = omap_hwmod_lookup("mcpdm");
- if (!oh) {
- printk(KERN_ERR "Could not look up mcpdm hw_mod\n");
+ if (!oh)
return;
- }
pdev = omap_device_build("omap-mcpdm", -1, oh, NULL, 0);
WARN(IS_ERR(pdev), "Can't build omap_device for omap-mcpdm.\n");
--
1.8.2.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/3] ARM: OMAP2+: devices: Do not print error when McPDM hwmod lookup fails
@ 2013-06-11 8:31 ` Peter Ujfalusi
0 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2013-06-11 8:31 UTC (permalink / raw)
To: linux-arm-kernel
It means that the SoC does not have McPDM IP.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/devices.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 4269fc1..b82538d 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -374,10 +374,8 @@ static void __init omap_init_mcpdm(void)
struct platform_device *pdev;
oh = omap_hwmod_lookup("mcpdm");
- if (!oh) {
- printk(KERN_ERR "Could not look up mcpdm hw_mod\n");
+ if (!oh)
return;
- }
pdev = omap_device_build("omap-mcpdm", -1, oh, NULL, 0);
WARN(IS_ERR(pdev), "Can't build omap_device for omap-mcpdm.\n");
--
1.8.2.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/3] ARM: OMAP2+: devices: Do not print error when DMIC hwmod lookup fails
2013-06-11 8:31 ` Peter Ujfalusi
@ 2013-06-11 8:31 ` Peter Ujfalusi
-1 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2013-06-11 8:31 UTC (permalink / raw)
To: Tony Lindgren, Paul Walmsley; +Cc: linux-omap, linux-arm-kernel, patches
It means that the SoC does not have DMIC IP
.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/devices.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index b82538d..8f268b4 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -393,10 +393,8 @@ static void __init omap_init_dmic(void)
struct platform_device *pdev;
oh = omap_hwmod_lookup("dmic");
- if (!oh) {
- pr_err("Could not look up dmic hw_mod\n");
+ if (!oh)
return;
- }
pdev = omap_device_build("omap-dmic", -1, oh, NULL, 0);
WARN(IS_ERR(pdev), "Can't build omap_device for omap-dmic.\n");
--
1.8.2.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/3] ARM: OMAP2+: devices: Do not print error when DMIC hwmod lookup fails
@ 2013-06-11 8:31 ` Peter Ujfalusi
0 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2013-06-11 8:31 UTC (permalink / raw)
To: linux-arm-kernel
It means that the SoC does not have DMIC IP
.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/devices.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index b82538d..8f268b4 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -393,10 +393,8 @@ static void __init omap_init_dmic(void)
struct platform_device *pdev;
oh = omap_hwmod_lookup("dmic");
- if (!oh) {
- pr_err("Could not look up dmic hw_mod\n");
+ if (!oh)
return;
- }
pdev = omap_device_build("omap-dmic", -1, oh, NULL, 0);
WARN(IS_ERR(pdev), "Can't build omap_device for omap-dmic.\n");
--
1.8.2.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] ARM: OMAP2+: devices: Do not print error when dss_hdmi hwmod lookup fails
2013-06-11 8:31 ` Peter Ujfalusi
@ 2013-06-11 8:32 ` Peter Ujfalusi
-1 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2013-06-11 8:32 UTC (permalink / raw)
To: Tony Lindgren, Paul Walmsley; +Cc: linux-omap, linux-arm-kernel, patches
The dss_hdmi hwmod is used to create the HDMI audio device for OMAP4+
When we boot the kernel we can silently ignore the failure since the IP
does not exist on them.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/devices.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 8f268b4..daa0ff6 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -417,10 +417,8 @@ static void __init omap_init_hdmi_audio(void)
struct platform_device *pdev;
oh = omap_hwmod_lookup("dss_hdmi");
- if (!oh) {
- printk(KERN_ERR "Could not look up dss_hdmi hw_mod\n");
+ if (!oh)
return;
- }
pdev = omap_device_build("omap-hdmi-audio-dai", -1, oh, NULL, 0);
WARN(IS_ERR(pdev),
--
1.8.2.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/3] ARM: OMAP2+: devices: Do not print error when dss_hdmi hwmod lookup fails
@ 2013-06-11 8:32 ` Peter Ujfalusi
0 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2013-06-11 8:32 UTC (permalink / raw)
To: linux-arm-kernel
The dss_hdmi hwmod is used to create the HDMI audio device for OMAP4+
When we boot the kernel we can silently ignore the failure since the IP
does not exist on them.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
arch/arm/mach-omap2/devices.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 8f268b4..daa0ff6 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -417,10 +417,8 @@ static void __init omap_init_hdmi_audio(void)
struct platform_device *pdev;
oh = omap_hwmod_lookup("dss_hdmi");
- if (!oh) {
- printk(KERN_ERR "Could not look up dss_hdmi hw_mod\n");
+ if (!oh)
return;
- }
pdev = omap_device_build("omap-hdmi-audio-dai", -1, oh, NULL, 0);
WARN(IS_ERR(pdev),
--
1.8.2.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] ARM: OMAP2+: devices: Silence hwmod lookup failures (dmic/mcpdm)
2013-06-11 8:31 ` Peter Ujfalusi
@ 2013-06-12 14:10 ` Tony Lindgren
-1 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2013-06-12 14:10 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: Paul Walmsley, linux-omap, linux-arm-kernel, patches
* Peter Ujfalusi <peter.ujfalusi@ti.com> [130611 01:37]:
> Hi,
>
> Small patches to silence the hwmod lookup failures in case when we boot the
> kernel on boards where the IPs are not present (OMAP2/3 vs McPDM, DMIC,
> HDMI audio).
Thanks applying into omap-for-v3.11/fixes-non-critical.
Regards,
Tony
> Peter Ujfalusi (3):
> ARM: OMAP2+: devices: Do not print error when McPDM hwmod lookup fails
> ARM: OMAP2+: devices: Do not print error when DMIC hwmod lookup fails
> ARM: OMAP2+: devices: Do not print error when dss_hdmi hwmod lookup
> fails
>
> arch/arm/mach-omap2/devices.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> --
> 1.8.2.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/3] ARM: OMAP2+: devices: Silence hwmod lookup failures (dmic/mcpdm)
@ 2013-06-12 14:10 ` Tony Lindgren
0 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2013-06-12 14:10 UTC (permalink / raw)
To: linux-arm-kernel
* Peter Ujfalusi <peter.ujfalusi@ti.com> [130611 01:37]:
> Hi,
>
> Small patches to silence the hwmod lookup failures in case when we boot the
> kernel on boards where the IPs are not present (OMAP2/3 vs McPDM, DMIC,
> HDMI audio).
Thanks applying into omap-for-v3.11/fixes-non-critical.
Regards,
Tony
> Peter Ujfalusi (3):
> ARM: OMAP2+: devices: Do not print error when McPDM hwmod lookup fails
> ARM: OMAP2+: devices: Do not print error when DMIC hwmod lookup fails
> ARM: OMAP2+: devices: Do not print error when dss_hdmi hwmod lookup
> fails
>
> arch/arm/mach-omap2/devices.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> --
> 1.8.2.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread