From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: linux@arm.linux.org.uk, balbi@ti.com, shc_work@mail.ru,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: omap-usb-host: Fix memory leaks
Date: Wed, 12 Jun 2013 10:04:57 -0700 [thread overview]
Message-ID: <20130612170457.GJ8164@atomide.com> (raw)
In-Reply-To: <51A84E7A.106@ti.com>
* Roger Quadros <rogerq@ti.com> [130531 00:23]:
> Hi Tony,
>
> On 05/31/2013 12:00 AM, Tony Lindgren wrote:
> > Hi Roger,
> >
> > * Roger Quadros <rogerq@ti.com> [130524 06:12]:
> >> Fix memory leaks in the error path.
> >> Also, use platform_device_register_full() to allocate
> >> the platform devices and set platform data.
> >
> > If you need this for the v3.10-rc, you should describe why this patch
> > is needed and ideally have some oops or regression causing commit
> > listed. Care to update the description for that?
>
> There is no oops or regression happening. Just that there will be a
> small memory leak if any of the memory allocations fail or if the
> platform device is destroyed.
>
> If it doesn't look that serious to you then it can wait.
> But if we move to device tree only boot then this patch and the file
> "usb-host.c" might not be required at all.
OK, applying into omap-for-v3.11/fixes-non-critical as we cannot
remove it yet.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: omap-usb-host: Fix memory leaks
Date: Wed, 12 Jun 2013 10:04:57 -0700 [thread overview]
Message-ID: <20130612170457.GJ8164@atomide.com> (raw)
In-Reply-To: <51A84E7A.106@ti.com>
* Roger Quadros <rogerq@ti.com> [130531 00:23]:
> Hi Tony,
>
> On 05/31/2013 12:00 AM, Tony Lindgren wrote:
> > Hi Roger,
> >
> > * Roger Quadros <rogerq@ti.com> [130524 06:12]:
> >> Fix memory leaks in the error path.
> >> Also, use platform_device_register_full() to allocate
> >> the platform devices and set platform data.
> >
> > If you need this for the v3.10-rc, you should describe why this patch
> > is needed and ideally have some oops or regression causing commit
> > listed. Care to update the description for that?
>
> There is no oops or regression happening. Just that there will be a
> small memory leak if any of the memory allocations fail or if the
> platform device is destroyed.
>
> If it doesn't look that serious to you then it can wait.
> But if we move to device tree only boot then this patch and the file
> "usb-host.c" might not be required at all.
OK, applying into omap-for-v3.11/fixes-non-critical as we cannot
remove it yet.
Regards,
Tony
next prev parent reply other threads:[~2013-06-12 17:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 13:06 [PATCH] ARM: OMAP2+: omap-usb-host: Fix memory leaks Roger Quadros
2013-05-24 13:06 ` Roger Quadros
2013-05-24 13:06 ` Roger Quadros
2013-05-30 21:00 ` Tony Lindgren
2013-05-30 21:00 ` Tony Lindgren
2013-05-31 7:17 ` Roger Quadros
2013-05-31 7:17 ` Roger Quadros
2013-05-31 7:17 ` Roger Quadros
2013-06-12 17:04 ` Tony Lindgren [this message]
2013-06-12 17:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612170457.GJ8164@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rogerq@ti.com \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.