All of lore.kernel.org
 help / color / mirror / Atom feed
From: s.trumtrar@pengutronix.de (Steffen Trumtrar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] arm: dt: zynq: Add support for the zed platform
Date: Wed, 12 Jun 2013 20:23:45 +0200	[thread overview]
Message-ID: <20130612182345.GA1656@pengutronix.de> (raw)
In-Reply-To: <1371055268-32337-4-git-send-email-soren.brinkmann@xilinx.com>

On Wed, Jun 12, 2013 at 09:41:08AM -0700, Soren Brinkmann wrote:
> Add a DT fragment for the Zed Zynq platform and a corresponding
> target to the Makefile
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> I used the 'xlnx,...' compat strings since it seems this is what is
> used in the Xilinx and Digilent vendor trees.
> 
> +/include/ "zynq-7000.dtsi"
> +
> +/ {
> +	model = "Zynq Zed Development Board";
> +	compatible = "xlnx,zynq-zed", "xlnx,zynq-7000";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0x20000000>;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyPS1,115200 earlyprintk";
> +	};
> +
> +};

Hi!

This looks a little bit to basic. No?! Not even an UART?
The compatible should include digilent or avnet. Digilent only sells to academic
customers, Avnet doesn't.
I personally don't care what they do out of tree.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Soren Brinkmann <soren.brinkmann@xilinx.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
	Russell King <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Dinh Nguyen <dinguyen@altera.com>,
	Olof Johansson <olof@lixom.net>, Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH v2 3/3] arm: dt: zynq: Add support for the zed platform
Date: Wed, 12 Jun 2013 20:23:45 +0200	[thread overview]
Message-ID: <20130612182345.GA1656@pengutronix.de> (raw)
In-Reply-To: <1371055268-32337-4-git-send-email-soren.brinkmann@xilinx.com>

On Wed, Jun 12, 2013 at 09:41:08AM -0700, Soren Brinkmann wrote:
> Add a DT fragment for the Zed Zynq platform and a corresponding
> target to the Makefile
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> I used the 'xlnx,...' compat strings since it seems this is what is
> used in the Xilinx and Digilent vendor trees.
> 
> +/include/ "zynq-7000.dtsi"
> +
> +/ {
> +	model = "Zynq Zed Development Board";
> +	compatible = "xlnx,zynq-zed", "xlnx,zynq-7000";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0x20000000>;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyPS1,115200 earlyprintk";
> +	};
> +
> +};

Hi!

This looks a little bit to basic. No?! Not even an UART?
The compatible should include digilent or avnet. Digilent only sells to academic
customers, Avnet doesn't.
I personally don't care what they do out of tree.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2013-06-12 18:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 16:41 [PATCH v2 0/3] Zynq: Support more boards Soren Brinkmann
2013-06-12 16:41 ` Soren Brinkmann
2013-06-12 16:41 ` [PATCH v2 1/3] arm: zynq: Remove board specific compatibility string Soren Brinkmann
2013-06-12 16:41   ` Soren Brinkmann
2013-06-12 16:41 ` [PATCH v2 2/3] arm: dt: zynq: Add support for the zc706 platform Soren Brinkmann
2013-06-12 16:41   ` Soren Brinkmann
2013-06-12 16:41 ` [PATCH v2 3/3] arm: dt: zynq: Add support for the zed platform Soren Brinkmann
2013-06-12 16:41   ` Soren Brinkmann
2013-06-12 18:23   ` Steffen Trumtrar [this message]
2013-06-12 18:23     ` Steffen Trumtrar
2013-06-12 18:26     ` Sören Brinkmann
2013-06-12 18:26       ` Sören Brinkmann
2013-06-12 19:33       ` Steffen Trumtrar
2013-06-12 19:33         ` Steffen Trumtrar
2013-06-12 20:16         ` Sören Brinkmann
2013-06-12 20:16           ` Sören Brinkmann
2013-06-13  5:02           ` Michal Simek
2013-06-13  5:02             ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130612182345.GA1656@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.