All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: "Steven J. Hill" <Steven.Hill@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset.
Date: Thu, 13 Jun 2013 16:18:20 +0200	[thread overview]
Message-ID: <20130613141820.GB22906@linux-mips.org> (raw)
In-Reply-To: <1371075656-21374-1-git-send-email-Steven.Hill@imgtec.com>

On Wed, Jun 12, 2013 at 05:20:56PM -0500, Steven J. Hill wrote:

>   * Reset register.
>   */
> -#define SOFTRES_REG	  0x1f000500
> -#define GORESET		  0x42
> +#define SOFTRES_REG	  0x1f000050
> +#define GORESET		  0x4d

I think this is going to break Malta.  We used to have:

    #define SOFTRES_REG       0x1e800050
    #define GORESET           0x4d

for SEAD and

    #define SOFTRES_REG       0x1f000500
    #define GORESET           0x42

for Atlas (no longer supported) and Malta.

  Ralf

  reply	other threads:[~2013-06-13 14:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 22:20 [PATCH] MIPS: sead3: Fix incorrect values for soft reset Steven J. Hill
2013-06-13 14:18 ` Ralf Baechle [this message]
2013-06-13 21:00   ` Steven J. Hill
2013-06-13 21:00     ` Steven J. Hill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130613141820.GB22906@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=Steven.Hill@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.