From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset.
Date: Thu, 13 Jun 2013 16:00:19 -0500 [thread overview]
Message-ID: <51BA32E3.7090006@imgtec.com> (raw)
In-Reply-To: <20130613141820.GB22906@linux-mips.org>
On 06/13/2013 09:18 AM, Ralf Baechle wrote:
> On Wed, Jun 12, 2013 at 05:20:56PM -0500, Steven J. Hill wrote:
>
> I think this is going to break Malta. We used to have:
>
> #define SOFTRES_REG 0x1e800050
> #define GORESET 0x4d
>
> for SEAD
>
Yes, it does break Malta. The #define values are defined in two places
and I missed one of them. I have submitted a patchset to these cleaned
up. Both platforms can now perform soft resets. Also, the 0x1e800050 is
not correct. I check all the way back in our 2.6.32.15 tree and that
value does not show up anywhere. The value in the patchset for SEAD-3 is
the correct one.
-Steve
WARNING: multiple messages have this Message-ID (diff)
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset.
Date: Thu, 13 Jun 2013 16:00:19 -0500 [thread overview]
Message-ID: <51BA32E3.7090006@imgtec.com> (raw)
Message-ID: <20130613210019.hSaVMQxWtFgdy6L3VFMM5G8R2b9NO-LnkA60Mt8IrT0@z> (raw)
In-Reply-To: <20130613141820.GB22906@linux-mips.org>
On 06/13/2013 09:18 AM, Ralf Baechle wrote:
> On Wed, Jun 12, 2013 at 05:20:56PM -0500, Steven J. Hill wrote:
>
> I think this is going to break Malta. We used to have:
>
> #define SOFTRES_REG 0x1e800050
> #define GORESET 0x4d
>
> for SEAD
>
Yes, it does break Malta. The #define values are defined in two places
and I missed one of them. I have submitted a patchset to these cleaned
up. Both platforms can now perform soft resets. Also, the 0x1e800050 is
not correct. I check all the way back in our 2.6.32.15 tree and that
value does not show up anywhere. The value in the patchset for SEAD-3 is
the correct one.
-Steve
next prev parent reply other threads:[~2013-06-13 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 22:20 [PATCH] MIPS: sead3: Fix incorrect values for soft reset Steven J. Hill
2013-06-13 14:18 ` Ralf Baechle
2013-06-13 21:00 ` Steven J. Hill [this message]
2013-06-13 21:00 ` Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BA32E3.7090006@imgtec.com \
--to=steven.hill@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.