* [PATCH] MIPS: sead3: Fix incorrect values for soft reset.
@ 2013-06-12 22:20 Steven J. Hill
2013-06-13 14:18 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Steven J. Hill @ 2013-06-12 22:20 UTC (permalink / raw)
To: linux-mips; +Cc: Steven J. Hill, ralf
The soft reset register address and reset value to be written to
the register are incorrect for the SEAD-3 platform. This patch
fixes them such that the SEAD-3 can actually perform a soft reset
instead of causing a NMI exception.
Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
arch/mips/include/asm/mips-boards/generic.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/include/asm/mips-boards/generic.h b/arch/mips/include/asm/mips-boards/generic.h
index bd9746f..61db690 100644
--- a/arch/mips/include/asm/mips-boards/generic.h
+++ b/arch/mips/include/asm/mips-boards/generic.h
@@ -26,8 +26,8 @@
/*
* Reset register.
*/
-#define SOFTRES_REG 0x1f000500
-#define GORESET 0x42
+#define SOFTRES_REG 0x1f000050
+#define GORESET 0x4d
/*
* Revision register.
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset.
2013-06-12 22:20 [PATCH] MIPS: sead3: Fix incorrect values for soft reset Steven J. Hill
@ 2013-06-13 14:18 ` Ralf Baechle
2013-06-13 21:00 ` Steven J. Hill
0 siblings, 1 reply; 4+ messages in thread
From: Ralf Baechle @ 2013-06-13 14:18 UTC (permalink / raw)
To: Steven J. Hill; +Cc: linux-mips
On Wed, Jun 12, 2013 at 05:20:56PM -0500, Steven J. Hill wrote:
> * Reset register.
> */
> -#define SOFTRES_REG 0x1f000500
> -#define GORESET 0x42
> +#define SOFTRES_REG 0x1f000050
> +#define GORESET 0x4d
I think this is going to break Malta. We used to have:
#define SOFTRES_REG 0x1e800050
#define GORESET 0x4d
for SEAD and
#define SOFTRES_REG 0x1f000500
#define GORESET 0x42
for Atlas (no longer supported) and Malta.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset.
@ 2013-06-13 21:00 ` Steven J. Hill
0 siblings, 0 replies; 4+ messages in thread
From: Steven J. Hill @ 2013-06-13 21:00 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
On 06/13/2013 09:18 AM, Ralf Baechle wrote:
> On Wed, Jun 12, 2013 at 05:20:56PM -0500, Steven J. Hill wrote:
>
> I think this is going to break Malta. We used to have:
>
> #define SOFTRES_REG 0x1e800050
> #define GORESET 0x4d
>
> for SEAD
>
Yes, it does break Malta. The #define values are defined in two places
and I missed one of them. I have submitted a patchset to these cleaned
up. Both platforms can now perform soft resets. Also, the 0x1e800050 is
not correct. I check all the way back in our 2.6.32.15 tree and that
value does not show up anywhere. The value in the patchset for SEAD-3 is
the correct one.
-Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: sead3: Fix incorrect values for soft reset.
@ 2013-06-13 21:00 ` Steven J. Hill
0 siblings, 0 replies; 4+ messages in thread
From: Steven J. Hill @ 2013-06-13 21:00 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
On 06/13/2013 09:18 AM, Ralf Baechle wrote:
> On Wed, Jun 12, 2013 at 05:20:56PM -0500, Steven J. Hill wrote:
>
> I think this is going to break Malta. We used to have:
>
> #define SOFTRES_REG 0x1e800050
> #define GORESET 0x4d
>
> for SEAD
>
Yes, it does break Malta. The #define values are defined in two places
and I missed one of them. I have submitted a patchset to these cleaned
up. Both platforms can now perform soft resets. Also, the 0x1e800050 is
not correct. I check all the way back in our 2.6.32.15 tree and that
value does not show up anywhere. The value in the patchset for SEAD-3 is
the correct one.
-Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-13 21:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-12 22:20 [PATCH] MIPS: sead3: Fix incorrect values for soft reset Steven J. Hill
2013-06-13 14:18 ` Ralf Baechle
2013-06-13 21:00 ` Steven J. Hill
2013-06-13 21:00 ` Steven J. Hill
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.