From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port
Date: Fri, 14 Jun 2013 13:02:59 +0200 [thread overview]
Message-ID: <20130614110259.GQ16699@lukather> (raw)
In-Reply-To: <24013808.T2v7Fa5NMK@wuerfel>
Hi Arnd,
On Fri, Jun 14, 2013 at 12:06:51AM +0200, Arnd Bergmann wrote:
> On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote:
> > +
> > + ahb at 80080000 {
> > + usb0: usb at 80080000 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&usb0_otg_cfa10036>;
> > + status = "okay";
> > };
> > };
> >
>
> The patches all look good, just one trivial comment about the fragment above:
>
> There is already a "usb0" label in the imx28.dtsi file for the same
> node. When you refer to the node from a board.dts file, either leave
> out the redundant label, or use it to simplify the statements above
> to the brief version:
>
> &usb0 {
> pinctrl-names = "default";
> pinctrl-0 = <&usb0_otg_cfa10036>;
> status = "okay";
> };
>
Good to know, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawn.guo@linaro.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port
Date: Fri, 14 Jun 2013 13:02:59 +0200 [thread overview]
Message-ID: <20130614110259.GQ16699@lukather> (raw)
In-Reply-To: <24013808.T2v7Fa5NMK@wuerfel>
Hi Arnd,
On Fri, Jun 14, 2013 at 12:06:51AM +0200, Arnd Bergmann wrote:
> On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote:
> > +
> > + ahb@80080000 {
> > + usb0: usb@80080000 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&usb0_otg_cfa10036>;
> > + status = "okay";
> > };
> > };
> >
>
> The patches all look good, just one trivial comment about the fragment above:
>
> There is already a "usb0" label in the imx28.dtsi file for the same
> node. When you refer to the node from a board.dts file, either leave
> out the redundant label, or use it to simplify the statements above
> to the brief version:
>
> &usb0 {
> pinctrl-names = "default";
> pinctrl-0 = <&usb0_otg_cfa10036>;
> status = "okay";
> };
>
Good to know, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-06-14 11:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 13:43 [PATCH 0/4] ARM: mxs: Various Crystalfontz DT additions Maxime Ripard
2013-06-13 13:43 ` Maxime Ripard
2013-06-13 13:43 ` [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port Maxime Ripard
2013-06-13 13:43 ` Maxime Ripard
2013-06-13 22:06 ` Arnd Bergmann
2013-06-13 22:06 ` Arnd Bergmann
2013-06-14 6:30 ` Shawn Guo
2013-06-14 6:30 ` Shawn Guo
2013-06-14 6:39 ` Shawn Guo
2013-06-14 6:39 ` Shawn Guo
2013-06-14 11:02 ` Maxime Ripard [this message]
2013-06-14 11:02 ` Maxime Ripard
2013-06-13 13:43 ` [PATCH 2/4] ARM: cfa10049: Switch the chip select pin of the LCD controller Maxime Ripard
2013-06-13 13:43 ` Maxime Ripard
2013-06-13 13:43 ` [PATCH 3/4] ARM: mxs: dt: Add the Crystalfontz CFA-10055 device tree Maxime Ripard
2013-06-13 13:43 ` Maxime Ripard
2013-06-16 11:51 ` Thomas Petazzoni
2013-06-16 11:51 ` Thomas Petazzoni
2013-06-13 13:43 ` [PATCH 4/4] ARM: mxs: dt: Add Crystalfontz CFA-10057 " Maxime Ripard
2013-06-13 13:43 ` Maxime Ripard
2013-06-14 6:51 ` [PATCH 0/4] ARM: mxs: Various Crystalfontz DT additions Shawn Guo
2013-06-14 6:51 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130614110259.GQ16699@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.