From: Simon Horman <horms@verge.net.au>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
SH-Linux <linux-sh@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
John Stultz <john.stultz@linaro.org>,
Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH/RFC] arm: arch_timer: Do not set C3STOP in case CPU_IDLE=n
Date: Mon, 17 Jun 2013 02:57:05 +0000 [thread overview]
Message-ID: <20130617025704.GA27933@verge.net.au> (raw)
In-Reply-To: <CANqRtoTfiWFv0JWwJysi47gsSjJx9g3-FFMMzCYROWDPbndnYQ@mail.gmail.com>
On Mon, Jun 17, 2013 at 11:47:11AM +0900, Magnus Damm wrote:
> Hi Simon,
>
> On Mon, Jun 17, 2013 at 11:13 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Jun 17, 2013 at 09:20:56AM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Modify the ARM architected timer driver to not set C3STOP
> >> in case CPU_IDLE is disabled. This is a short term fix that
> >> allows use of high resolution timers even though no additional
> >> clock event is registered.
> >>
> >> Not-really-Signed-off-by: Magnus Damm <damm@opensource.se>
> >> ---
> >>
> >> If someone cares about this case then perhaps it should be
> >> moved up to the clock event main code. The same issue should
> >> in theory trigger on all architectures, perhaps x86 people
> >> hunting for low latency may try to disable CPU_IDLE?
> >>
> >> I propose carrying this patch locally to enable high resolution
> >> timers until CPU_IDLE and an additional clock event is supported.
> >>
> >> Observed on r8a73a4 and APE6EVM.
> >
> > Hi Magnus,
> >
> > Is this patch intended to be picked up by me for the LTSI-3.4.25 based
> > backports that live in my renesas-backports tree?
>
> Yes, correct.
>
> The patch was mainly written to satisfy a feature request for your
> backports, but I noticed that the same issue exists in upstream as
> well.
>
> Ideally I'd like to use the same code for the backport and upstream,
> but I am not sure if anyone in upstream really cares. The more long
> term solution is obviously to install a second clock event, perhaps
> that's good enough.
>
> > If so, could you clearly state this (below the '---' is fine) and
> > include a proper Sob line to indicate that it is fit to be merged
> > even if that merge is not into mainline.
>
> Sure, but I'd like to hear opinions from other people before
> resending. I will follow your recommendation in next version.
Thanks, I understand. I'll wait for discussion and a new version.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
SH-Linux <linux-sh@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
John Stultz <john.stultz@linaro.org>,
Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH/RFC] arm: arch_timer: Do not set C3STOP in case CPU_IDLE=n
Date: Mon, 17 Jun 2013 11:57:05 +0900 [thread overview]
Message-ID: <20130617025704.GA27933@verge.net.au> (raw)
In-Reply-To: <CANqRtoTfiWFv0JWwJysi47gsSjJx9g3-FFMMzCYROWDPbndnYQ@mail.gmail.com>
On Mon, Jun 17, 2013 at 11:47:11AM +0900, Magnus Damm wrote:
> Hi Simon,
>
> On Mon, Jun 17, 2013 at 11:13 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Jun 17, 2013 at 09:20:56AM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Modify the ARM architected timer driver to not set C3STOP
> >> in case CPU_IDLE is disabled. This is a short term fix that
> >> allows use of high resolution timers even though no additional
> >> clock event is registered.
> >>
> >> Not-really-Signed-off-by: Magnus Damm <damm@opensource.se>
> >> ---
> >>
> >> If someone cares about this case then perhaps it should be
> >> moved up to the clock event main code. The same issue should
> >> in theory trigger on all architectures, perhaps x86 people
> >> hunting for low latency may try to disable CPU_IDLE?
> >>
> >> I propose carrying this patch locally to enable high resolution
> >> timers until CPU_IDLE and an additional clock event is supported.
> >>
> >> Observed on r8a73a4 and APE6EVM.
> >
> > Hi Magnus,
> >
> > Is this patch intended to be picked up by me for the LTSI-3.4.25 based
> > backports that live in my renesas-backports tree?
>
> Yes, correct.
>
> The patch was mainly written to satisfy a feature request for your
> backports, but I noticed that the same issue exists in upstream as
> well.
>
> Ideally I'd like to use the same code for the backport and upstream,
> but I am not sure if anyone in upstream really cares. The more long
> term solution is obviously to install a second clock event, perhaps
> that's good enough.
>
> > If so, could you clearly state this (below the '---' is fine) and
> > include a proper Sob line to indicate that it is fit to be merged
> > even if that merge is not into mainline.
>
> Sure, but I'd like to hear opinions from other people before
> resending. I will follow your recommendation in next version.
Thanks, I understand. I'll wait for discussion and a new version.
next prev parent reply other threads:[~2013-06-17 2:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 0:20 [PATCH/RFC] arm: arch_timer: Do not set C3STOP in case CPU_IDLE=n Magnus Damm
2013-06-17 0:20 ` Magnus Damm
2013-06-17 2:13 ` Simon Horman
2013-06-17 2:13 ` Simon Horman
2013-06-17 2:47 ` Magnus Damm
2013-06-17 2:47 ` Magnus Damm
2013-06-17 2:57 ` Simon Horman [this message]
2013-06-17 2:57 ` Simon Horman
2013-06-17 14:53 ` Mark Rutland
2013-06-17 14:53 ` Mark Rutland
2013-06-18 7:32 ` Magnus Damm
2013-06-18 7:32 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617025704.GA27933@verge.net.au \
--to=horms@verge.net.au \
--cc=catalin.marinas@arm.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=shinya.kuribayashi.px@renesas.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.