From: fabio.baltieri@linaro.org (Fabio Baltieri)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: ux500: set coherent_dma_mask for dma40
Date: Tue, 18 Jun 2013 10:53:16 +0200 [thread overview]
Message-ID: <20130618085316.GA7239@balto.lan> (raw)
In-Reply-To: <CACRpkdYOP0xTJo3sLbRz5D=b4Vb1484a1qfE3aVAKRTM4+Y7QQ@mail.gmail.com>
On Mon, Jun 17, 2013 at 05:42:48PM +0200, Linus Walleij wrote:
> On Thu, Jun 13, 2013 at 3:56 PM, Fabio Baltieri
> <fabio.baltieri@linaro.org> wrote:
>
> > Set coherent_dma_mask to DMA_BIT_MASK(32) for dma40 platform_device, as
> > without this DMA allocations were failing with the error:
> >
> > dma40 dma40.0: coherent DMA mask is unset
> >
> > when booting without device-tree.
> >
> > Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
> > ---
> >
> > Hi Linus, Lee,
> >
> > I found this while removing the last hack I was keeping in my ASoC tree.
> > I originally thought that I had to set this on the driver's pdata, but
> > it turns out it's needed on the DMA controller one instead.
> >
> > When booting with device-tree enabled the mask seems to be set
> > automatically.
> >
> > Would you consider applying this with the other dma40 patches?
>
> Those are now upstream in the ARM SoC tree, you'd have to send it
> to arm at kernel.org and ask Olof/Arnd to apply it directly to
> the next/drivers branch (I think).
Ok I can resend it but I'd like to have Lee's Ack before doing that.
Lee: have you had a chance to look at this patch?
> I have also queued it on ux500-fixes so it won't be lost.
That's nice!
Thanks,
Fabio
--
Fabio Baltieri
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Baltieri <fabio.baltieri@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Vinod Koul <vinod.koul@intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: ux500: set coherent_dma_mask for dma40
Date: Tue, 18 Jun 2013 10:53:16 +0200 [thread overview]
Message-ID: <20130618085316.GA7239@balto.lan> (raw)
In-Reply-To: <CACRpkdYOP0xTJo3sLbRz5D=b4Vb1484a1qfE3aVAKRTM4+Y7QQ@mail.gmail.com>
On Mon, Jun 17, 2013 at 05:42:48PM +0200, Linus Walleij wrote:
> On Thu, Jun 13, 2013 at 3:56 PM, Fabio Baltieri
> <fabio.baltieri@linaro.org> wrote:
>
> > Set coherent_dma_mask to DMA_BIT_MASK(32) for dma40 platform_device, as
> > without this DMA allocations were failing with the error:
> >
> > dma40 dma40.0: coherent DMA mask is unset
> >
> > when booting without device-tree.
> >
> > Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
> > ---
> >
> > Hi Linus, Lee,
> >
> > I found this while removing the last hack I was keeping in my ASoC tree.
> > I originally thought that I had to set this on the driver's pdata, but
> > it turns out it's needed on the DMA controller one instead.
> >
> > When booting with device-tree enabled the mask seems to be set
> > automatically.
> >
> > Would you consider applying this with the other dma40 patches?
>
> Those are now upstream in the ARM SoC tree, you'd have to send it
> to arm@kernel.org and ask Olof/Arnd to apply it directly to
> the next/drivers branch (I think).
Ok I can resend it but I'd like to have Lee's Ack before doing that.
Lee: have you had a chance to look at this patch?
> I have also queued it on ux500-fixes so it won't be lost.
That's nice!
Thanks,
Fabio
--
Fabio Baltieri
next prev parent reply other threads:[~2013-06-18 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 13:56 [PATCH] ARM: ux500: set coherent_dma_mask for dma40 Fabio Baltieri
2013-06-13 13:56 ` Fabio Baltieri
2013-06-17 15:42 ` Linus Walleij
2013-06-17 15:42 ` Linus Walleij
2013-06-18 8:53 ` Fabio Baltieri [this message]
2013-06-18 8:53 ` Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618085316.GA7239@balto.lan \
--to=fabio.baltieri@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.