From: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Tuomas Tynkkynen
<ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 1/2] mfd: tps65910: Fix crash in i2c_driver .probe
Date: Tue, 18 Jun 2013 11:16:10 +0200 [thread overview]
Message-ID: <20130618091610.GG7161@zurbaran> (raw)
In-Reply-To: <51BF5281.2030105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Mon, Jun 17, 2013 at 12:16:33PM -0600, Stephen Warren wrote:
> On 06/17/2013 11:47 AM, Tuomas Tynkkynen wrote:
> > Commit "i2c: core: make it possible to match a pure device tree driver"
> > changed semantics of the i2c probing for device tree devices.
> > Device tree probed devices now get a NULL i2c_device_id pointer.
> > This caused kernel panics due to NULL dereference.
>
> Tested-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> (although I imagine I'd need to retest if there was a v2 to address my
> previous comments)
I would prefer seeing a v2, especially to address the pmic_plat_data
overwriting issue.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Ortiz <sameo@linux.intel.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Tuomas Tynkkynen <ttynkkynen@nvidia.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/2] mfd: tps65910: Fix crash in i2c_driver .probe
Date: Tue, 18 Jun 2013 11:16:10 +0200 [thread overview]
Message-ID: <20130618091610.GG7161@zurbaran> (raw)
In-Reply-To: <51BF5281.2030105@wwwdotorg.org>
On Mon, Jun 17, 2013 at 12:16:33PM -0600, Stephen Warren wrote:
> On 06/17/2013 11:47 AM, Tuomas Tynkkynen wrote:
> > Commit "i2c: core: make it possible to match a pure device tree driver"
> > changed semantics of the i2c probing for device tree devices.
> > Device tree probed devices now get a NULL i2c_device_id pointer.
> > This caused kernel panics due to NULL dereference.
>
> Tested-by: Stephen Warren <swarren@nvidia.com>
>
> (although I imagine I'd need to retest if there was a v2 to address my
> previous comments)
I would prefer seeing a v2, especially to address the pmic_plat_data
overwriting issue.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-06-18 9:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 17:47 [PATCH 0/2] Fix kernel panics with certain I2C tps6* chips Tuomas Tynkkynen
2013-06-17 17:47 ` Tuomas Tynkkynen
[not found] ` <1371491257-23791-1-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-17 17:47 ` [PATCH 1/2] mfd: tps65910: Fix crash in i2c_driver .probe Tuomas Tynkkynen
2013-06-17 17:47 ` Tuomas Tynkkynen
[not found] ` <1371491257-23791-2-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-17 18:07 ` Stephen Warren
2013-06-17 18:07 ` Stephen Warren
[not found] ` <51BF5060.8060001-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-18 9:35 ` Tuomas Tynkkynen
2013-06-18 9:35 ` Tuomas Tynkkynen
2013-06-17 18:16 ` Stephen Warren
2013-06-17 18:16 ` Stephen Warren
[not found] ` <51BF5281.2030105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-18 9:16 ` Samuel Ortiz [this message]
2013-06-18 9:16 ` Samuel Ortiz
2013-06-17 17:47 ` [PATCH 2/2] regulator: tps62360: " Tuomas Tynkkynen
2013-06-17 17:47 ` Tuomas Tynkkynen
2013-06-17 18:16 ` Stephen Warren
2013-06-18 7:52 ` [PATCH 0/2] Fix kernel panics with certain I2C tps6* chips Linus Walleij
2013-06-18 7:52 ` Linus Walleij
2013-06-18 15:58 ` Wolfram Sang
2013-06-18 15:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618091610.GG7161@zurbaran \
--to=sameo-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.