All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Florian Vaussard <florian.vaussard@epfl.ch>
Cc: Steve Sakoman <sakoman@gmail.com>,
	Mike Rapoport <mike@compulab.co.il>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: omap: board-overo: reset GPIO for SMSC911x
Date: Tue, 18 Jun 2013 03:09:46 -0700	[thread overview]
Message-ID: <20130618100945.GI5523@atomide.com> (raw)
In-Reply-To: <1369144071-10673-1-git-send-email-florian.vaussard@epfl.ch>

* Florian Vaussard <florian.vaussard@epfl.ch> [130521 07:01]:
> The reset GPIO should be set for the SMSC911x, otherwise the controller
> will not work and probing will fail. In the case of the tobi-duo
> expansion board, the second controller shares the same GPIO, thus no
> more changes are required (not tested).
> 
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>

Thanks applying into omap-for-v3.11/board.

Regards,

Tony

> ---
>  arch/arm/mach-omap2/board-overo.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
> index 4ca6b68..5748b5d 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -68,6 +68,7 @@
>  
>  #define OVERO_SMSC911X_CS      5
>  #define OVERO_SMSC911X_GPIO    176
> +#define OVERO_SMSC911X_NRESET  64
>  #define OVERO_SMSC911X2_CS     4
>  #define OVERO_SMSC911X2_GPIO   65
>  
> @@ -122,7 +123,7 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
>  	.id		= 0,
>  	.cs             = OVERO_SMSC911X_CS,
>  	.gpio_irq       = OVERO_SMSC911X_GPIO,
> -	.gpio_reset     = -EINVAL,
> +	.gpio_reset     = OVERO_SMSC911X_NRESET,
>  	.flags		= SMSC911X_USE_32BIT,
>  };
>  
> -- 
> 1.7.5.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap: board-overo: reset GPIO for SMSC911x
Date: Tue, 18 Jun 2013 03:09:46 -0700	[thread overview]
Message-ID: <20130618100945.GI5523@atomide.com> (raw)
In-Reply-To: <1369144071-10673-1-git-send-email-florian.vaussard@epfl.ch>

* Florian Vaussard <florian.vaussard@epfl.ch> [130521 07:01]:
> The reset GPIO should be set for the SMSC911x, otherwise the controller
> will not work and probing will fail. In the case of the tobi-duo
> expansion board, the second controller shares the same GPIO, thus no
> more changes are required (not tested).
> 
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>

Thanks applying into omap-for-v3.11/board.

Regards,

Tony

> ---
>  arch/arm/mach-omap2/board-overo.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
> index 4ca6b68..5748b5d 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -68,6 +68,7 @@
>  
>  #define OVERO_SMSC911X_CS      5
>  #define OVERO_SMSC911X_GPIO    176
> +#define OVERO_SMSC911X_NRESET  64
>  #define OVERO_SMSC911X2_CS     4
>  #define OVERO_SMSC911X2_GPIO   65
>  
> @@ -122,7 +123,7 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
>  	.id		= 0,
>  	.cs             = OVERO_SMSC911X_CS,
>  	.gpio_irq       = OVERO_SMSC911X_GPIO,
> -	.gpio_reset     = -EINVAL,
> +	.gpio_reset     = OVERO_SMSC911X_NRESET,
>  	.flags		= SMSC911X_USE_32BIT,
>  };
>  
> -- 
> 1.7.5.4
> 

  reply	other threads:[~2013-06-18 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 13:47 [PATCH] arm: omap: board-overo: reset GPIO for SMSC911x Florian Vaussard
2013-05-21 13:47 ` Florian Vaussard
2013-06-18 10:09 ` Tony Lindgren [this message]
2013-06-18 10:09   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130618100945.GI5523@atomide.com \
    --to=tony@atomide.com \
    --cc=florian.vaussard@epfl.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mike@compulab.co.il \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.