From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer
Date: Tue, 18 Jun 2013 15:11:23 +0200 [thread overview]
Message-ID: <201306181511.24004.arnd@arndb.de> (raw)
In-Reply-To: <1371514129-22801-2-git-send-email-dinguyen@altera.com>
On Tuesday 18 June 2013, dinguyen at altera.com wrote:
> @@ -476,27 +476,31 @@
> };
>
> timer0: timer0 at ffc08000 {
> - compatible = "snps,dw-apb-timer-sp";
> + compatible = "snps,dw-apb-timer";
> interrupts = <0 167 4>;
> reg = <0xffc08000 0x1000>;
> + clocks = <&osc>;
> };
>
> timer1: timer1 at ffc09000 {
> - compatible = "snps,dw-apb-timer-sp";
> + compatible = "snps,dw-apb-timer";
> interrupts = <0 168 4>;
> reg = <0xffc09000 0x1000>;
> + clocks = <&osc>;
> };
I think it would make sense to fix the device name as well, they should
all be named "timer", not "timer0", so I would add
- timer0: timer0 at ffc08000 {
+ timer0: timer at ffc08000 {
for all the timers in the dts file here.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: dinguyen@altera.com
Cc: dinh.linux@gmail.com, Pavel Machek <pavel@denx.de>,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>,
Olof Johansson <olof@lixom.net>,
John Stultz <john.stultz@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Jamie Iles <jamie@jamieiles.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer
Date: Tue, 18 Jun 2013 15:11:23 +0200 [thread overview]
Message-ID: <201306181511.24004.arnd@arndb.de> (raw)
In-Reply-To: <1371514129-22801-2-git-send-email-dinguyen@altera.com>
On Tuesday 18 June 2013, dinguyen@altera.com wrote:
> @@ -476,27 +476,31 @@
> };
>
> timer0: timer0@ffc08000 {
> - compatible = "snps,dw-apb-timer-sp";
> + compatible = "snps,dw-apb-timer";
> interrupts = <0 167 4>;
> reg = <0xffc08000 0x1000>;
> + clocks = <&osc>;
> };
>
> timer1: timer1@ffc09000 {
> - compatible = "snps,dw-apb-timer-sp";
> + compatible = "snps,dw-apb-timer";
> interrupts = <0 168 4>;
> reg = <0xffc09000 0x1000>;
> + clocks = <&osc>;
> };
I think it would make sense to fix the device name as well, they should
all be named "timer", not "timer0", so I would add
- timer0: timer0@ffc08000 {
+ timer0: timer@ffc08000 {
for all the timers in the dts file here.
Arnd
next prev parent reply other threads:[~2013-06-18 13:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 0:08 [PATCH 0/2] Fix potential merge conflict for dw_apb_timer_of dinguyen at altera.com
2013-06-18 0:08 ` dinguyen-EIB2kfCEclfQT0dZR+AlfA
2013-06-18 0:08 ` [PATCH 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer dinguyen at altera.com
2013-06-18 0:08 ` dinguyen-EIB2kfCEclfQT0dZR+AlfA
2013-06-18 13:11 ` Arnd Bergmann [this message]
2013-06-18 13:11 ` Arnd Bergmann
2013-06-18 0:08 ` [PATCH 2/2] clocksource: dw_apb_timer_of: Fix read_sched_clock dinguyen at altera.com
2013-06-18 9:23 ` Jamie Iles
2013-06-18 0:38 ` [PATCH 0/2] Fix potential merge conflict for dw_apb_timer_of John Stultz
2013-06-18 0:38 ` John Stultz
2013-06-18 2:11 ` Dinh Nguyen
2013-06-18 2:11 ` Dinh Nguyen
2013-06-18 15:02 ` Pavel Machek
2013-06-18 15:02 ` Pavel Machek
2013-06-18 15:38 ` Heiko Stübner
2013-06-18 15:38 ` Heiko Stübner
2013-06-18 18:28 ` Heiko Stübner
2013-06-18 18:28 ` Heiko Stübner
2013-06-18 18:40 ` John Stultz
2013-06-18 18:40 ` John Stultz
2013-06-18 20:11 ` Olof Johansson
2013-06-18 20:11 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2013-07-25 3:43 [PATCH 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer dinguyen at altera.com
2013-07-25 3:43 ` dinguyen
2013-07-29 18:25 ` Pavel Machek
2013-07-29 18:25 ` Pavel Machek
2013-08-11 21:45 ` Olof Johansson
2013-08-11 21:45 ` Olof Johansson
2013-08-12 11:57 ` Pavel Machek
2013-08-12 11:57 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306181511.24004.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.