From: Tony Lindgren <tony@atomide.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: Roger Quadros <rogerq@ti.com>,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] ARM: dts: omap4-panda: Add USB Host support
Date: Wed, 19 Jun 2013 05:44:13 -0700 [thread overview]
Message-ID: <20130619124412.GC5523@atomide.com> (raw)
In-Reply-To: <51C1A55E.9040500@ti.com>
* Benoit Cousson <b-cousson@ti.com> [130619 05:41]:
> Hi Tony,
>
> On 06/19/2013 07:27 AM, Tony Lindgren wrote:
> >* Benoit Cousson <b-cousson@ti.com> [130619 03:17]:
> >>On 06/19/2013 02:46 AM, Tony Lindgren wrote:
> >>>
> >>>We have a similar issue with the MMC1 PBIAS. I think in the long run we
> >>>should expand regulator (and possibly pinctrl) framework(s) to handle
> >>>comparators. We could just assume that a comparatator is a regulator,
> >>>and have a comparator binding that just uses the regulator code.
> >>
> >>In the case of pbias, the pinctrl seems to be a much better fit for
> >>my point of view. pinctrl can handle pin configuration and this is
> >>what the pbias is in the case of MMC pins.
> >
> >Well just recently Linus W specifically wanted us to use regulator
> >framework for the MMC1 PBIAS rather than pinctrl. That's because
> >from consumer driver point of view, it changes voltage and there's
> >a delay involved. So I guess no conclusion yet, and it's best to
> >do stand alone drivers to deal with those that use pinctrl for the
> >pinctrl specific parts and export it as a regulator for the consumer
> >devices.
>
> In the case of pbias, the boundary is not that clear, and it is true
> that writing a complete pinctrl driver is really overkill.
> I've tried in the past, and gave up due to the complexity of fmwk
> and the lack of time. I still think, it is a much better fmwk to
> handle pin configuration than the regulator fmwk.
For omaps, these kind of registers can already be handled by
pinctrl-single,bits. What's missing is the capability to create
a regulator out of the voltage mux + comparator bits.
> >That's pretty much along the lines what Roger has done,
> >except the transceiver could use the pinctrl-single,bits for the
> >muxing and pinconf.
>
> Well, in that case, this is a reset line, so it does not have
> anything to do with voltage :-)
>
> Anyway, thanks to Florian, we know that there is a real solution to
> that problem. It is just not merged now :-(
Right. Meanwhile, sounds like the transceiver driver needs to
deal with the GPIO directly.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] ARM: dts: omap4-panda: Add USB Host support
Date: Wed, 19 Jun 2013 05:44:13 -0700 [thread overview]
Message-ID: <20130619124412.GC5523@atomide.com> (raw)
In-Reply-To: <51C1A55E.9040500@ti.com>
* Benoit Cousson <b-cousson@ti.com> [130619 05:41]:
> Hi Tony,
>
> On 06/19/2013 07:27 AM, Tony Lindgren wrote:
> >* Benoit Cousson <b-cousson@ti.com> [130619 03:17]:
> >>On 06/19/2013 02:46 AM, Tony Lindgren wrote:
> >>>
> >>>We have a similar issue with the MMC1 PBIAS. I think in the long run we
> >>>should expand regulator (and possibly pinctrl) framework(s) to handle
> >>>comparators. We could just assume that a comparatator is a regulator,
> >>>and have a comparator binding that just uses the regulator code.
> >>
> >>In the case of pbias, the pinctrl seems to be a much better fit for
> >>my point of view. pinctrl can handle pin configuration and this is
> >>what the pbias is in the case of MMC pins.
> >
> >Well just recently Linus W specifically wanted us to use regulator
> >framework for the MMC1 PBIAS rather than pinctrl. That's because
> >from consumer driver point of view, it changes voltage and there's
> >a delay involved. So I guess no conclusion yet, and it's best to
> >do stand alone drivers to deal with those that use pinctrl for the
> >pinctrl specific parts and export it as a regulator for the consumer
> >devices.
>
> In the case of pbias, the boundary is not that clear, and it is true
> that writing a complete pinctrl driver is really overkill.
> I've tried in the past, and gave up due to the complexity of fmwk
> and the lack of time. I still think, it is a much better fmwk to
> handle pin configuration than the regulator fmwk.
For omaps, these kind of registers can already be handled by
pinctrl-single,bits. What's missing is the capability to create
a regulator out of the voltage mux + comparator bits.
> >That's pretty much along the lines what Roger has done,
> >except the transceiver could use the pinctrl-single,bits for the
> >muxing and pinconf.
>
> Well, in that case, this is a reset line, so it does not have
> anything to do with voltage :-)
>
> Anyway, thanks to Florian, we know that there is a real solution to
> that problem. It is just not merged now :-(
Right. Meanwhile, sounds like the transceiver driver needs to
deal with the GPIO directly.
Regards,
Tony
next prev parent reply other threads:[~2013-06-19 12:44 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 16:04 [PATCH v2 0/4] ARM: OMAP2+: Panda USB Host support and DVI EDID fix Roger Quadros
2013-06-18 16:04 ` Roger Quadros
2013-06-18 16:04 ` Roger Quadros
[not found] ` <1371571487-14389-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-06-18 16:04 ` [PATCH v2 1/4] ARM: dts: omap4-panda: Add USB Host support Roger Quadros
2013-06-18 16:04 ` Roger Quadros
2013-06-18 16:04 ` Roger Quadros
2013-06-19 1:17 ` Benoit Cousson
2013-06-19 1:17 ` Benoit Cousson
2013-06-19 1:17 ` Benoit Cousson
2013-06-19 7:36 ` Roger Quadros
2013-06-19 7:36 ` Roger Quadros
2013-06-19 7:36 ` Roger Quadros
2013-06-19 7:46 ` Tony Lindgren
2013-06-19 7:46 ` Tony Lindgren
2013-06-19 10:10 ` Benoit Cousson
2013-06-19 10:10 ` Benoit Cousson
2013-06-19 10:10 ` Benoit Cousson
2013-06-19 11:03 ` Roger Quadros
2013-06-19 11:03 ` Roger Quadros
2013-06-19 11:03 ` Roger Quadros
2013-06-19 11:30 ` Benoit Cousson
2013-06-19 11:30 ` Benoit Cousson
2013-06-19 11:30 ` Benoit Cousson
2013-06-19 14:02 ` Roger Quadros
2013-06-19 14:02 ` Roger Quadros
2013-06-19 14:02 ` Roger Quadros
2013-06-19 12:05 ` Florian Vaussard
2013-06-19 12:05 ` Florian Vaussard
2013-06-19 12:23 ` Benoit Cousson
2013-06-19 12:23 ` Benoit Cousson
2013-06-19 12:23 ` Benoit Cousson
2013-06-19 12:32 ` Tony Lindgren
2013-06-19 12:32 ` Tony Lindgren
2013-06-19 14:05 ` Roger Quadros
2013-06-19 14:05 ` Roger Quadros
2013-06-19 14:05 ` Roger Quadros
[not found] ` <51C1BA8C.6000703-l0cyMroinI0@public.gmane.org>
2013-06-19 18:17 ` Benoit Cousson
2013-06-19 18:17 ` Benoit Cousson
2013-06-19 18:17 ` Benoit Cousson
2013-06-19 22:40 ` Benoit Cousson
2013-06-19 22:40 ` Benoit Cousson
2013-06-19 22:40 ` Benoit Cousson
2013-06-20 11:49 ` Roger Quadros
2013-06-20 11:49 ` Roger Quadros
2013-06-20 11:49 ` Roger Quadros
2013-06-19 12:27 ` Tony Lindgren
2013-06-19 12:27 ` Tony Lindgren
2013-06-19 12:34 ` Benoit Cousson
2013-06-19 12:34 ` Benoit Cousson
2013-06-19 12:34 ` Benoit Cousson
2013-06-19 12:44 ` Tony Lindgren [this message]
2013-06-19 12:44 ` Tony Lindgren
2013-06-18 16:04 ` [PATCH v2 2/4] ARM: dts: omap4-panda: Fix DVI EDID reads Roger Quadros
2013-06-18 16:04 ` Roger Quadros
2013-06-18 16:04 ` Roger Quadros
2013-06-18 16:04 ` [PATCH v2 3/4] ARM: dts: omap5-uevm: Provide USB Host PHY clock frequency Roger Quadros
2013-06-18 16:04 ` Roger Quadros
2013-06-18 16:04 ` Roger Quadros
2013-06-18 16:04 ` [PATCH v2 4/4] ARM: OMAP2+: Provide alias to USB PHY clock Roger Quadros
2013-06-18 16:04 ` Roger Quadros
2013-06-18 16:04 ` Roger Quadros
2013-07-15 14:05 ` Roger Quadros
2013-07-15 14:05 ` Roger Quadros
2013-07-15 14:05 ` Roger Quadros
2013-07-16 12:32 ` Tony Lindgren
2013-07-16 12:32 ` Tony Lindgren
2013-07-16 13:39 ` Roger Quadros
2013-07-16 13:39 ` Roger Quadros
2013-07-16 13:39 ` Roger Quadros
2013-07-16 13:43 ` Tony Lindgren
2013-07-16 13:43 ` Tony Lindgren
2013-07-16 13:12 ` Arend van Spriel
2013-07-16 13:12 ` Arend van Spriel
2013-07-16 13:18 ` Arend van Spriel
2013-07-16 13:18 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619124412.GC5523@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.