From: Nishanth Menon <nm@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, mturquette@linaro.org,
paul@pwsan.com, tony@atomide.com, rnayak@ti.com,
linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org,
Eduardo Valentin <eduardo.valentin@ti.com>
Subject: Re: [PATCHv2 10/11] ARM: dts: omap4 clock data
Date: Wed, 19 Jun 2013 08:56:30 -0500 [thread overview]
Message-ID: <20130619135629.GA2236@kahuna> (raw)
In-Reply-To: <51C1B707.5090603@ti.com>
On 16:49-20130619, Tero Kristo wrote:
> On 06/19/2013 04:30 PM, Nishanth Menon wrote:
> >On 16:19-20130619, Tero Kristo wrote:
> >[...]
> >>+
> >>+/*
> >>+ * clocks specific to omap4460
> >>+ */
> >>+/*
> >>+ * clocks specific to omap4430
> >>+ */
> >>+/*
> >>+ * clocks common to omap44xx
> >>+ */
> >could be dropped?
>
> Same.
>
> >
> >btw, are we differentiating 4430 and 4460?A
> >Example:
> >bandgap_fclk in 4430
> >Vs
> >div_ts_ck, bandgap_ts_fclk in 4460?
>
> Both nodes are available for both SoCs as of now. Driver should
> differentiate which clock node to use though. Added Eduardo for
> commenting this part, maybe we should add a couple of entries to the
> list in cclock44xx_data.c...?
How about this:
we do have 443x.dtsi and 4460.dtsi -> add the corresponding clock nodes
there?
ideally, driver should just do devm_clk_get and should not worry about
what SoC revision it is running on.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 10/11] ARM: dts: omap4 clock data
Date: Wed, 19 Jun 2013 08:56:30 -0500 [thread overview]
Message-ID: <20130619135629.GA2236@kahuna> (raw)
In-Reply-To: <51C1B707.5090603@ti.com>
On 16:49-20130619, Tero Kristo wrote:
> On 06/19/2013 04:30 PM, Nishanth Menon wrote:
> >On 16:19-20130619, Tero Kristo wrote:
> >[...]
> >>+
> >>+/*
> >>+ * clocks specific to omap4460
> >>+ */
> >>+/*
> >>+ * clocks specific to omap4430
> >>+ */
> >>+/*
> >>+ * clocks common to omap44xx
> >>+ */
> >could be dropped?
>
> Same.
>
> >
> >btw, are we differentiating 4430 and 4460?A
> >Example:
> >bandgap_fclk in 4430
> >Vs
> >div_ts_ck, bandgap_ts_fclk in 4460?
>
> Both nodes are available for both SoCs as of now. Driver should
> differentiate which clock node to use though. Added Eduardo for
> commenting this part, maybe we should add a couple of entries to the
> list in cclock44xx_data.c...?
How about this:
we do have 443x.dtsi and 4460.dtsi -> add the corresponding clock nodes
there?
ideally, driver should just do devm_clk_get and should not worry about
what SoC revision it is running on.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-06-19 13:56 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 13:18 [PATCHv2 00/11] ARM: OMAP4 clock data conversion to DT Tero Kristo
2013-06-19 13:18 ` Tero Kristo
2013-06-19 13:18 ` [PATCHv2 01/11] CLK: clkdev: add support for looking up clocks from DT Tero Kristo
2013-06-19 13:18 ` Tero Kristo
2013-06-19 13:18 ` [PATCHv2 02/11] CLK: use of_property_read_u32 instead of read_u8 Tero Kristo
2013-06-19 13:18 ` Tero Kristo
[not found] ` <1371647942-4811-3-git-send-email-t-kristo-l0cyMroinI0@public.gmane.org>
2013-06-21 0:57 ` Mike Turquette
2013-06-21 0:57 ` Mike Turquette
2013-06-21 12:45 ` Nishanth Menon
2013-06-21 12:45 ` Nishanth Menon
2013-06-21 16:21 ` Mike Turquette
2013-06-21 16:21 ` Mike Turquette
2013-06-19 13:18 ` [PATCHv2 03/11] CLK: divider: fix table parsing logic for DT Tero Kristo
2013-06-19 13:18 ` Tero Kristo
2013-06-19 13:18 ` [PATCHv2 04/11] clk: omap: introduce clock driver Tero Kristo
2013-06-19 13:18 ` Tero Kristo
2013-06-19 13:18 ` [PATCHv2 05/11] CLK: OMAP4: Add DPLL clock support Tero Kristo
2013-06-19 13:18 ` Tero Kristo
2013-06-19 13:18 ` [PATCHv2 06/11] CLK: omap: move part of the machine specific clock header contents to driver Tero Kristo
2013-06-19 13:18 ` Tero Kristo
2013-06-21 7:32 ` Tony Lindgren
2013-06-21 7:32 ` Tony Lindgren
2013-06-24 7:42 ` Tero Kristo
2013-06-24 7:42 ` Tero Kristo
2013-06-19 13:18 ` [PATCHv2 07/11] ARM: OMAP: clock: add DT duplicate clock registration mechanism Tero Kristo
2013-06-19 13:18 ` Tero Kristo
2013-06-19 13:18 ` [PATCHv2 08/11] CLK: omap: add autoidle support Tero Kristo
2013-06-19 13:18 ` Tero Kristo
2013-06-19 13:19 ` [PATCHv2 09/11] CLK: omap: add support for OMAP gate clock Tero Kristo
2013-06-19 13:19 ` Tero Kristo
2013-06-19 13:19 ` [PATCHv2 10/11] ARM: dts: omap4 clock data Tero Kristo
2013-06-19 13:19 ` Tero Kristo
2013-06-19 13:30 ` Nishanth Menon
2013-06-19 13:30 ` Nishanth Menon
2013-06-19 13:49 ` Tero Kristo
2013-06-19 13:49 ` Tero Kristo
2013-06-19 13:56 ` Nishanth Menon [this message]
2013-06-19 13:56 ` Nishanth Menon
2013-06-21 1:24 ` Stephen Boyd
2013-06-21 1:24 ` Stephen Boyd
2013-06-24 7:39 ` Tero Kristo
2013-06-24 7:39 ` Tero Kristo
2013-06-19 13:19 ` [PATCHv2 11/11] ARM: OMAP4: register DT clocks and remove old data Tero Kristo
2013-06-19 13:19 ` Tero Kristo
2013-06-21 7:25 ` Tony Lindgren
2013-06-21 7:25 ` Tony Lindgren
2013-06-24 7:45 ` Tero Kristo
2013-06-24 7:45 ` Tero Kristo
2013-06-24 7:50 ` Tony Lindgren
2013-06-24 7:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619135629.GA2236@kahuna \
--to=nm@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eduardo.valentin@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.