All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alessandro Rubini <rubini@gnudd.com>
To: joe@perches.com
Cc: dan.carpenter@oracle.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] FMC: NULL dereference on allocation failure
Date: Wed, 19 Jun 2013 17:57:58 +0000	[thread overview]
Message-ID: <20130619175758.GA23533@mail.gnudd.com> (raw)
In-Reply-To: <1371658504.2038.25.camel@joe-AO722>

>> +	arr->record = kzalloc(sizeof(arr->record[0]) * n, GFP_KERNEL);
>> +	arr->subtree = kzalloc(sizeof(arr->subtree[0]) * n, GFP_KERNEL);

> n comes from the hardware no?

Yes. Length of hardware description array.

> Maybe make these kcalloc too.

I'm not a fan of kcalloc. I think it removes readability. I remeber
kernel patches to swap the arguments, because people get them wrong.
Even Kernighan said it was a design error (in "the practice of
programming").  That said, I'm not the leader here.

thanks
/alessandro

WARNING: multiple messages have this Message-ID (diff)
From: Alessandro Rubini <rubini@gnudd.com>
To: joe@perches.com
Cc: dan.carpenter@oracle.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] FMC: NULL dereference on allocation failure
Date: Wed, 19 Jun 2013 19:57:58 +0200	[thread overview]
Message-ID: <20130619175758.GA23533@mail.gnudd.com> (raw)
In-Reply-To: <1371658504.2038.25.camel@joe-AO722>

>> +	arr->record = kzalloc(sizeof(arr->record[0]) * n, GFP_KERNEL);
>> +	arr->subtree = kzalloc(sizeof(arr->subtree[0]) * n, GFP_KERNEL);

> n comes from the hardware no?

Yes. Length of hardware description array.

> Maybe make these kcalloc too.

I'm not a fan of kcalloc. I think it removes readability. I remeber
kernel patches to swap the arguments, because people get them wrong.
Even Kernighan said it was a design error (in "the practice of
programming").  That said, I'm not the leader here.

thanks
/alessandro

  reply	other threads:[~2013-06-19 17:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19 14:49 [patch] FMC: NULL dereference on allocation failure Dan Carpenter
2013-06-19 14:49 ` Dan Carpenter
2013-06-19 15:25 ` Alessandro Rubini
2013-06-19 15:25   ` Alessandro Rubini
2013-06-19 15:57   ` Dan Carpenter
2013-06-19 15:57     ` Dan Carpenter
2013-06-19 16:01     ` [patch -next] " Dan Carpenter
2013-06-19 16:01       ` Dan Carpenter
2013-06-19 16:15       ` Joe Perches
2013-06-19 16:15         ` Joe Perches
2013-06-19 17:57         ` Alessandro Rubini [this message]
2013-06-19 17:57           ` Alessandro Rubini
2013-06-19 18:09           ` Joe Perches
2013-06-19 18:09             ` Joe Perches
2013-06-20  8:06           ` Dan Carpenter
2013-06-20  8:06             ` Dan Carpenter
2013-06-19 17:57     ` [patch] " Alessandro Rubini
2013-06-19 17:57       ` Alessandro Rubini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130619175758.GA23533@mail.gnudd.com \
    --to=rubini@gnudd.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.