From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: nomadik: implement the Nomadik clocks properly
Date: Wed, 19 Jun 2013 23:38:01 -0700 [thread overview]
Message-ID: <20130620063801.9136.80841@quantum> (raw)
In-Reply-To: <1370775348-7440-1-git-send-email-linus.walleij@linaro.org>
Quoting Linus Walleij (2013-06-09 03:55:47)
> +static void pll_clk_disable(struct clk_hw *hw)
> +{
> + struct clk_pll *pll = to_pll(hw);
> + u32 val;
> +
> + return;
Is the early return intentional? Everything else looks good.
Acked-by: Mike Turquette <mturquette@linaro.org>
> +
> + spin_lock(&src_lock);
> + val = readl(src_base + SRC_PLLCR);
> + if (pll->id == 1) {
> + if (val & SRC_PLLCR_PLL1OVER) {
> + val &= ~SRC_PLLCR_PLL1EN;
> + writel(val, src_base + SRC_PLLCR);
> + }
> + } else if (pll->id == 2) {
> + val &= ~SRC_PLLCR_PLL2EN;
> + writel(val, src_base + SRC_PLLCR);
> + }
> + spin_unlock(&src_lock);
> +}
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/2] clk: nomadik: implement the Nomadik clocks properly
Date: Wed, 19 Jun 2013 23:38:01 -0700 [thread overview]
Message-ID: <20130620063801.9136.80841@quantum> (raw)
In-Reply-To: <1370775348-7440-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Quoting Linus Walleij (2013-06-09 03:55:47)
> +static void pll_clk_disable(struct clk_hw *hw)
> +{
> + struct clk_pll *pll = to_pll(hw);
> + u32 val;
> +
> + return;
Is the early return intentional? Everything else looks good.
Acked-by: Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> +
> + spin_lock(&src_lock);
> + val = readl(src_base + SRC_PLLCR);
> + if (pll->id == 1) {
> + if (val & SRC_PLLCR_PLL1OVER) {
> + val &= ~SRC_PLLCR_PLL1EN;
> + writel(val, src_base + SRC_PLLCR);
> + }
> + } else if (pll->id == 2) {
> + val &= ~SRC_PLLCR_PLL2EN;
> + writel(val, src_base + SRC_PLLCR);
> + }
> + spin_unlock(&src_lock);
> +}
next prev parent reply other threads:[~2013-06-20 6:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 10:55 [PATCH 1/2] clk: nomadik: implement the Nomadik clocks properly Linus Walleij
2013-06-09 10:55 ` Linus Walleij
2013-06-09 10:55 ` [PATCH 2/2] ARM: nomadik: add the new clocks to the device tree Linus Walleij
2013-06-09 10:55 ` Linus Walleij
2013-06-09 14:21 ` Arnd Bergmann
2013-06-09 14:21 ` Arnd Bergmann
[not found] ` <CAJAp7OiYZx46aWRsXc+CmS+5F0STz5P+rdYnJEoaRRMUnkD1Cg@mail.gmail.com>
2013-06-10 5:12 ` Bjorn Andersson
2013-06-10 5:12 ` Bjorn Andersson
2013-06-10 12:29 ` Linus Walleij
2013-06-10 12:29 ` Linus Walleij
2013-06-10 7:43 ` Linus Walleij
2013-06-10 7:43 ` Linus Walleij
2013-06-12 13:24 ` Grant Likely
2013-06-12 13:24 ` Grant Likely
2013-06-13 8:37 ` Linus Walleij
2013-06-13 8:37 ` Linus Walleij
2013-06-16 19:08 ` [PATCH 1/2] clk: nomadik: implement the Nomadik clocks properly Linus Walleij
2013-06-16 19:08 ` Linus Walleij
2013-06-20 6:38 ` Mike Turquette [this message]
2013-06-20 6:38 ` Mike Turquette
2013-06-20 8:21 ` Linus Walleij
2013-06-20 8:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620063801.9136.80841@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.