Issues with Qt5/mesa and eglfs

Issues with Qt5/mesa and eglfs

[Nicolas Dechesne]

hi there,

i am trying to build Qt5/meta-qt5 with dylan branch in a non X11 distro,
and i got failures during the Qt5 configure step (when auto-detecting EGL
feature). Looking into the issue, the good news is that it seems to be
fixed in oe-core/master with:

d7033f4 mesa: upgrade to 9.1.3

thanks to this :

    Add EGL-Mutate-NativeDisplayType-depending-on-config.patch to build
correctly in
    a non-X11 environment.

    Drop dont-fail-if-libX11-isnt-installed.patch and
    fix-egl-compilation-without-x11-headers.patch as they were backports.


Would you guys consider 'backporting' this patch onto dylan a viable thing?
I will make the backport, but it would be nice if you can confirm that it
can be merged in dylan.

thanks

nico

Re: Issues with Qt5/mesa and eglfs

[Burton, Ross]

On 20 June 2013 14:15, Nicolas Dechesne <nicolas.dechesne@linaro.org> wrote:
> Would you guys consider 'backporting' this patch onto dylan a viable thing?
> I will make the backport, but it would be nice if you can confirm that it
> can be merged in dylan.

One of those patches is actually being debated upstream, but more
importantly this thread should be on openembedded-core@ (cc'ing Paul
Eggleton, who is the Dylan maintainer).

Ross

Re: Issues with Qt5/mesa and eglfs

[Nicolas Dechesne]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

resending on proper mailling list, +cc Paul as it's dylan related.


On Thu, Jun 20, 2013 at 9:15 AM, Nicolas Dechesne <
nicolas.dechesne@linaro.org> wrote:

> hi there,
>
> i am trying to build Qt5/meta-qt5 with dylan branch in a non X11 distro,
> and i got failures during the Qt5 configure step (when auto-detecting EGL
> feature). Looking into the issue, the good news is that it seems to be
> fixed in oe-core/master with:
>
> d7033f4 mesa: upgrade to 9.1.3
>
> thanks to this :
>
>     Add EGL-Mutate-NativeDisplayType-depending-on-config.patch to build
> correctly in
>     a non-X11 environment.
>
>     Drop dont-fail-if-libX11-isnt-installed.patch and
>     fix-egl-compilation-without-x11-headers.patch as they were backports.
>
>
> Would you guys consider 'backporting' this patch onto dylan a viable
> thing? I will make the backport, but it would be nice if you can confirm
> that it can be merged in dylan.
>
> thanks
>
> nico
>

[-- Attachment #2: Type: text/html, Size: 1512 bytes --]

Re: Issues with Qt5/mesa and eglfs

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

On Thu, Jun 20, 2013 at 09:15:24AM -0400, Nicolas Dechesne wrote:
> hi there,
> 
> i am trying to build Qt5/meta-qt5 with dylan branch in a non X11 distro,
> and i got failures during the Qt5 configure step (when auto-detecting EGL
> feature). Looking into the issue, the good news is that it seems to be
> fixed in oe-core/master with:
> 
> d7033f4 mesa: upgrade to 9.1.3
> 
> thanks to this :
> 
>     Add EGL-Mutate-NativeDisplayType-depending-on-config.patch to build
> correctly in
>     a non-X11 environment.
> 
>     Drop dont-fail-if-libX11-isnt-installed.patch and
>     fix-egl-compilation-without-x11-headers.patch as they were backports.
> 
> 
> Would you guys consider 'backporting' this patch onto dylan a viable thing?
> I will make the backport, but it would be nice if you can confirm that it
> can be merged in dylan.

You should be able to build qtbase with mesa from dylan if you add
CFLAGS_append = " -DMESA_EGL_NO_X11_HEADERS"

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: Issues with Qt5/mesa and eglfs

[Nicolas Dechesne]

On Thu, Jun 20, 2013 at 11:06 AM, Martin Jansa <martin.jansa@gmail.com>wrote:

> You should be able to build qtbase with mesa from dylan if you add
> CFLAGS_append = " -DMESA_EGL_NO_X11_HEADERS"
>

yes, that works too, but that doesn't really fix the original problem in
the dylan branch, which from that perspective is broken, right? how do you
recommend that to be fixed?

btw, i also tried to cherry-pick the new patch from master that i mentioned
earlier, and that worked too.

Re: Issues with Qt5/mesa and eglfs

[Paul Eggleton]

Hi Nicolas,

On Thursday 20 June 2013 09:46:36 Nicolas Dechesne wrote:
> resending on proper mailling list, +cc Paul as it's dylan related.
> 
> 
> On Thu, Jun 20, 2013 at 9:15 AM, Nicolas Dechesne <
> 
> nicolas.dechesne@linaro.org> wrote:
> > hi there,
> > 
> > i am trying to build Qt5/meta-qt5 with dylan branch in a non X11 distro,
> > and i got failures during the Qt5 configure step (when auto-detecting EGL
> > feature). Looking into the issue, the good news is that it seems to be
> > fixed in oe-core/master with:
> > 
> > d7033f4 mesa: upgrade to 9.1.3
> > 
> > thanks to this :
> >     Add EGL-Mutate-NativeDisplayType-depending-on-config.patch to build
> > 
> > correctly in
> > 
> >     a non-X11 environment.
> >     
> >     Drop dont-fail-if-libX11-isnt-installed.patch and
> >     fix-egl-compilation-without-x11-headers.patch as they were backports.
> > 
> > Would you guys consider 'backporting' this patch onto dylan a viable
> > thing? I will make the backport, but it would be nice if you can confirm
> > that it can be merged in dylan.

I wasn't watching closely but my impression is there were a large number of 
changes associated with the mesa upgrade. Is the upgrade itself necessary for 
the fix?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: Issues with Qt5/mesa and eglfs

[Nicolas Dechesne]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

On Thu, Jun 20, 2013 at 11:42 AM, Paul Eggleton <
paul.eggleton@linux.intel.com> wrote:

> I wasn't watching closely but my impression is there were a large number of
> changes associated with the mesa upgrade. Is the upgrade itself necessary
> for
> the fix?
>

no, i don't think so. I think we might be able to just update the patches
that deal with the X11/no X11 support. but i haven't tested that yet. i
just did a quick test by cherry picking the complete commit (e.g. mesa
upgrade) to verify that it's actually fixing my problem. now that i know it
does, i will try to just upgrade the patches without the mesa upgrade and
report how it goes.

nicolas

[-- Attachment #2: Type: text/html, Size: 1098 bytes --]

Re: Issues with Qt5/mesa and eglfs

[Nicolas Dechesne]

[-- Attachment #1: Type: text/plain, Size: 1715 bytes --]

On Thu, Jun 20, 2013 at 11:46 AM, Nicolas Dechesne <
nicolas.dechesne@linaro.org> wrote:

> On Thu, Jun 20, 2013 at 11:42 AM, Paul Eggleton <
> paul.eggleton@linux.intel.com> wrote:
>
>> I wasn't watching closely but my impression is there were a large number
>> of
>> changes associated with the mesa upgrade. Is the upgrade itself necessary
>> for
>> the fix?
>>
>
> no, i don't think so. I think we might be able to just update the patches
> that deal with the X11/no X11 support. but i haven't tested that yet. i
> just did a quick test by cherry picking the complete commit (e.g. mesa
> upgrade) to verify that it's actually fixing my problem. now that i know it
> does, i will try to just upgrade the patches without the mesa upgrade and
> report how it goes.


ok, i was able to backport the mesa patch from 9.1.3 to 9.0.2
(EGL-Mutate-NativeDisplayType-depending-on-config.patch) , the backport was
more or less trivial. and then i did this in dylan branch:

--- a/meta/recipes-graphics/mesa/mesa-9.0.2.inc
+++ b/meta/recipes-graphics/mesa/mesa-9.0.2.inc
@@ -2,7 +2,7 @@ SRC_URI = "
ftp://ftp.freedesktop.org/pub/mesa/${PV}/MesaLib-${PV}.tar.bz2 \
            file://0002-cross-compile.patch \
            file://cross-glsl.patch \
            file://dont-fail-if-libX11-isnt-installed.patch \
-           file://fix-egl-compilation-without-x11-headers.patch \
+           file://EGL-Mutate-NativeDisplayType-depending-on-config.patch \
            "

and it does fix the build issue i had (mesa/qt5/non X11 distro).

should that be merged into dylan (since it's merged in master already) or
do we need to wait for the 'final' patch in upstream to be ready?

thanks

[-- Attachment #2: Type: text/html, Size: 3018 bytes --]

Re: Issues with Qt5/mesa and eglfs

[Nicolas Dechesne]

[-- Attachment #1: Type: text/plain, Size: 2033 bytes --]

On Thu, Jun 20, 2013 at 8:15 PM, Nicolas Dechesne <
nicolas.dechesne@linaro.org> wrote:

>
> On Thu, Jun 20, 2013 at 11:46 AM, Nicolas Dechesne <
> nicolas.dechesne@linaro.org> wrote:
>
>> On Thu, Jun 20, 2013 at 11:42 AM, Paul Eggleton <
>> paul.eggleton@linux.intel.com> wrote:
>>
>>> I wasn't watching closely but my impression is there were a large number
>>> of
>>> changes associated with the mesa upgrade. Is the upgrade itself
>>> necessary for
>>> the fix?
>>>
>>
>> no, i don't think so. I think we might be able to just update the patches
>> that deal with the X11/no X11 support. but i haven't tested that yet. i
>> just did a quick test by cherry picking the complete commit (e.g. mesa
>> upgrade) to verify that it's actually fixing my problem. now that i know it
>> does, i will try to just upgrade the patches without the mesa upgrade and
>> report how it goes.
>
>
> ok, i was able to backport the mesa patch from 9.1.3 to 9.0.2
> (EGL-Mutate-NativeDisplayType-depending-on-config.patch) , the backport was
> more or less trivial. and then i did this in dylan branch:
>
> --- a/meta/recipes-graphics/mesa/mesa-9.0.2.inc
> +++ b/meta/recipes-graphics/mesa/mesa-9.0.2.inc
> @@ -2,7 +2,7 @@ SRC_URI = "
> ftp://ftp.freedesktop.org/pub/mesa/${PV}/MesaLib-${PV}.tar.bz2 \
>             file://0002-cross-compile.patch \
>             file://cross-glsl.patch \
>             file://dont-fail-if-libX11-isnt-installed.patch \
> -           file://fix-egl-compilation-without-x11-headers.patch \
> +           file://EGL-Mutate-NativeDisplayType-depending-on-config.patch \
>             "
>
> and it does fix the build issue i had (mesa/qt5/non X11 distro).
>
> should that be merged into dylan (since it's merged in master already) or
> do we need to wait for the 'final' patch in upstream to be ready?
>


Paul, Martin, what do you think about this? i have the (trivial) dylan
backport ready. Do you think it's the right time to get it merged?



>
> thanks
>
>
>

[-- Attachment #2: Type: text/html, Size: 3848 bytes --]

Re: Issues with Qt5/mesa and eglfs

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Tue, Jun 25, 2013 at 01:59:55PM +0200, Nicolas Dechesne wrote:
> On Thu, Jun 20, 2013 at 8:15 PM, Nicolas Dechesne <
> nicolas.dechesne@linaro.org> wrote:
> 
> > @@ -2,7 +2,7 @@ SRC_URI = "
> > ftp://ftp.freedesktop.org/pub/mesa/${PV}/MesaLib-${PV}.tar.bz2 \
> >             file://0002-cross-compile.patch \
> >             file://cross-glsl.patch \
> >             file://dont-fail-if-libX11-isnt-installed.patch \
> > -           file://fix-egl-compilation-without-x11-headers.patch \
> > +           file://EGL-Mutate-NativeDisplayType-depending-on-config.patch \
> >             "
> >
> > and it does fix the build issue i had (mesa/qt5/non X11 distro).
> >
> > should that be merged into dylan (since it's merged in master already) or
> > do we need to wait for the 'final' patch in upstream to be ready?
> >
> 
> 
> Paul, Martin, what do you think about this? i have the (trivial) dylan
> backport ready. Do you think it's the right time to get it merged?

I don't have strong opinion about this one, I'm already using that
CFLAGS change in all recipes where it was needed (only few of them) so I
don't mind waiting for upstream for final solution. On other hand this
backport doesn't cause more work for me, so I don't mind if it gets
merged.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: Issues with Qt5/mesa and eglfs

[Paul Eggleton]

On Tuesday 25 June 2013 13:59:55 Nicolas Dechesne wrote:
> On Thu, Jun 20, 2013 at 8:15 PM, Nicolas Dechesne <
> nicolas.dechesne@linaro.org> wrote:
> > On Thu, Jun 20, 2013 at 11:46 AM, Nicolas Dechesne <
> > 
> > nicolas.dechesne@linaro.org> wrote:
> >> On Thu, Jun 20, 2013 at 11:42 AM, Paul Eggleton <
> >> 
> >> paul.eggleton@linux.intel.com> wrote:
> >>> I wasn't watching closely but my impression is there were a large number
> >>> of
> >>> changes associated with the mesa upgrade. Is the upgrade itself
> >>> necessary for
> >>> the fix?
> >> 
> >> no, i don't think so. I think we might be able to just update the patches
> >> that deal with the X11/no X11 support. but i haven't tested that yet. i
> >> just did a quick test by cherry picking the complete commit (e.g. mesa
> >> upgrade) to verify that it's actually fixing my problem. now that i know
> >> it
> >> does, i will try to just upgrade the patches without the mesa upgrade and
> >> report how it goes.
> > 
> > ok, i was able to backport the mesa patch from 9.1.3 to 9.0.2
> > (EGL-Mutate-NativeDisplayType-depending-on-config.patch) , the backport
> > was
> > more or less trivial. and then i did this in dylan branch:
> > 
> > --- a/meta/recipes-graphics/mesa/mesa-9.0.2.inc
> > +++ b/meta/recipes-graphics/mesa/mesa-9.0.2.inc
> > @@ -2,7 +2,7 @@ SRC_URI = "
> > ftp://ftp.freedesktop.org/pub/mesa/${PV}/MesaLib-${PV}.tar.bz2 \
> > 
> >             file://0002-cross-compile.patch \
> >             file://cross-glsl.patch \
> >             file://dont-fail-if-libX11-isnt-installed.patch \
> > 
> > -           file://fix-egl-compilation-without-x11-headers.patch \
> > +           file://EGL-Mutate-NativeDisplayType-depending-on-config.patch
> > \
> > 
> >             "
> > 
> > and it does fix the build issue i had (mesa/qt5/non X11 distro).
> > should that be merged into dylan (since it's merged in master already) or
> > do we need to wait for the 'final' patch in upstream to be ready?
> 
> Paul, Martin, what do you think about this? i have the (trivial) dylan
> backport ready. Do you think it's the right time to get it merged?

I'd say please send the patch to the mailing list (marked with [dylan]) and 
then we can review it. By the sounds of things it should be OK.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre