From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Alex Williamson
<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RESEND PATCH] iommu: Split iommu_unmaps
Date: Thu, 20 Jun 2013 17:27:11 +0200 [thread overview]
Message-ID: <20130620152711.GG3589@8bytes.org> (raw)
In-Reply-To: <20130618015642.20826.30187.stgit-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
On Mon, Jun 17, 2013 at 07:57:34PM -0600, Alex Williamson wrote:
> iommu_map splits requests into pages that the iommu driver reports
> that it can handle. The iommu_unmap path does not do the same. This
> can cause problems not only from callers that might expect the same
> behavior as the map path, but even from the failure path of iommu_map,
> should it fail at a point where it has mapped and needs to unwind a
> set of pages that the iommu driver cannot handle directly. amd_iommu,
> for example, will BUG_ON if asked to unmap a non power of 2 size.
>
> Fix this by extracting and generalizing the sizing code from the
> iommu_map path and use it for both map and unmap.
Very true, thanks for fixing this.
Applied to the core branch.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] iommu: Split iommu_unmaps
Date: Thu, 20 Jun 2013 17:27:11 +0200 [thread overview]
Message-ID: <20130620152711.GG3589@8bytes.org> (raw)
In-Reply-To: <20130618015642.20826.30187.stgit@bling.home>
On Mon, Jun 17, 2013 at 07:57:34PM -0600, Alex Williamson wrote:
> iommu_map splits requests into pages that the iommu driver reports
> that it can handle. The iommu_unmap path does not do the same. This
> can cause problems not only from callers that might expect the same
> behavior as the map path, but even from the failure path of iommu_map,
> should it fail at a point where it has mapped and needs to unwind a
> set of pages that the iommu driver cannot handle directly. amd_iommu,
> for example, will BUG_ON if asked to unmap a non power of 2 size.
>
> Fix this by extracting and generalizing the sizing code from the
> iommu_map path and use it for both map and unmap.
Very true, thanks for fixing this.
Applied to the core branch.
next prev parent reply other threads:[~2013-06-20 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 1:57 [RESEND PATCH] iommu: Split iommu_unmaps Alex Williamson
2013-06-18 1:57 ` Alex Williamson
[not found] ` <20130618015642.20826.30187.stgit-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2013-06-20 15:27 ` Joerg Roedel [this message]
2013-06-20 15:27 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620152711.GG3589@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.