All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.cz>,
	David Rientjes <rientjes@google.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Rik van Riel <riel@redhat.com>,
	Andrew Shewmaker <agshew@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>, Namjae Jeon <linkinjeon@gmail.com>,
	Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/6] mm/writeback: Don't check force_wait to handle bdi->work_list
Date: Fri, 21 Jun 2013 08:31:03 +0800	[thread overview]
Message-ID: <20130621003103.GC11033@localhost> (raw)
In-Reply-To: <20130620233724.GA26898@hacker.(null)>

On Fri, Jun 21, 2013 at 07:37:25AM +0800, Wanpeng Li wrote:
> On Thu, Jun 20, 2013 at 09:46:15PM +0800, Fengguang Wu wrote:
> >>  fs/fs-writeback.c |   10 ++--------
> >>  1 files changed, 2 insertions(+), 8 deletions(-)
> >
> >The header file should be changed, too. Otherwise looks fine to me.
> >
> >include/linux/writeback.h:97:long wb_do_writeback(struct bdi_writeback *wb, int force_wait);
> 
> Thanks for your review, Fengguang. ;-)
> 
> The line in header file has already been removed by commit(836f29bbb0:
> fs/fs-writeback.c: : make wb_do_writeback() as static) in -next tree
> since there is just one caller in fs/fs-writeback.c.

Ah OK. I was reading the upstream kernel.. However it still presents a
tricky situation (for Andrew Morton) that commit 836f29bbb0 MUST be
merged before your patch in the next merge window. Otherwise it will
lead to a range of build failure commits.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.cz>,
	David Rientjes <rientjes@google.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Rik van Riel <riel@redhat.com>,
	Andrew Shewmaker <agshew@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>, Namjae Jeon <linkinjeon@gmail.com>,
	Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/6] mm/writeback: Don't check force_wait to handle bdi->work_list
Date: Fri, 21 Jun 2013 08:31:03 +0800	[thread overview]
Message-ID: <20130621003103.GC11033@localhost> (raw)
In-Reply-To: <20130620233724.GA26898@hacker.(null)>

On Fri, Jun 21, 2013 at 07:37:25AM +0800, Wanpeng Li wrote:
> On Thu, Jun 20, 2013 at 09:46:15PM +0800, Fengguang Wu wrote:
> >>  fs/fs-writeback.c |   10 ++--------
> >>  1 files changed, 2 insertions(+), 8 deletions(-)
> >
> >The header file should be changed, too. Otherwise looks fine to me.
> >
> >include/linux/writeback.h:97:long wb_do_writeback(struct bdi_writeback *wb, int force_wait);
> 
> Thanks for your review, Fengguang. ;-)
> 
> The line in header file has already been removed by commit(836f29bbb0:
> fs/fs-writeback.c: : make wb_do_writeback() as static) in -next tree
> since there is just one caller in fs/fs-writeback.c.

Ah OK. I was reading the upstream kernel.. However it still presents a
tricky situation (for Andrew Morton) that commit 836f29bbb0 MUST be
merged before your patch in the next merge window. Otherwise it will
lead to a range of build failure commits.

Thanks,
Fengguang

  reply	other threads:[~2013-06-21  0:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 23:52 [PATCH v4 1/6] mm/writeback: remove wb_reason_name Wanpeng Li
2013-06-18 23:52 ` Wanpeng Li
2013-06-18 23:52 ` [PATCH v4 2/6] mm/writeback: Don't check force_wait to handle bdi->work_list Wanpeng Li
2013-06-18 23:52   ` Wanpeng Li
2013-06-20 13:46   ` Fengguang Wu
2013-06-20 13:46     ` Fengguang Wu
2013-06-20 23:37     ` Wanpeng Li
2013-06-20 23:37     ` Wanpeng Li
2013-06-21  0:31       ` Fengguang Wu [this message]
2013-06-21  0:31         ` Fengguang Wu
2013-06-18 23:52 ` [PATCH v4 3/6] mm/writeback: commit reason of WB_REASON_FORKER_THREAD mismatch name Wanpeng Li
2013-06-18 23:52   ` Wanpeng Li
2013-06-20 13:57   ` Fengguang Wu
2013-06-20 13:57     ` Fengguang Wu
2013-06-20 23:39     ` Wanpeng Li
2013-06-20 23:39     ` Wanpeng Li
2013-06-18 23:52 ` [PATCH v4 4/6] mm/page_alloc: fix doc for numa_zonelist_order Wanpeng Li
2013-06-18 23:52   ` Wanpeng Li
2013-06-18 23:52 ` [PATCH v4 5/6] mm/thp: fix doc for transparent huge zero page Wanpeng Li
2013-06-18 23:52   ` Wanpeng Li
2013-06-18 23:52 ` [PATCH v4 6/6] mm/pgtable: Don't accumulate addr during pgd prepopulate pmd Wanpeng Li
2013-06-18 23:52   ` Wanpeng Li
2013-06-19  1:31   ` Zhang Yanfei
2013-06-19  1:31     ` Zhang Yanfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130621003103.GC11033@localhost \
    --to=fengguang.wu@intel.com \
    --cc=agshew@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=jkosina@suse.cz \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linkinjeon@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liwanp@linux.vnet.ibm.com \
    --cc=mhocko@suse.cz \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.