From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: PL08x: Avoid collisions with get_signal() macro
Date: Fri, 21 Jun 2013 11:31:58 +0530 [thread overview]
Message-ID: <20130621060158.GD23141@intel.com> (raw)
In-Reply-To: <1371670708-26161-1-git-send-email-broonie@linaro.org>
On Wed, Jun 19, 2013 at 08:38:28PM +0100, Mark Brown wrote:
> As pointed out by Arnd Bergmann there is a get_signal macro definied in
> linux/signal.h which can conflict with the platform data callback
> function of the same name leading to confusing errors from the compiler
> (especially if signal.h manages to get pulled into the driver itself due
> to header dependencies). Avoid such errors by renaming get_signal and
> put_signal in the platform data to get_xfer_signal and put_xfer_signal.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@linaro.org>
Cc: Dan Williams <djbw@fb.com>, Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Tomasz Figa <tomasz.figa@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: PL08x: Avoid collisions with get_signal() macro
Date: Fri, 21 Jun 2013 11:31:58 +0530 [thread overview]
Message-ID: <20130621060158.GD23141@intel.com> (raw)
In-Reply-To: <1371670708-26161-1-git-send-email-broonie@linaro.org>
On Wed, Jun 19, 2013 at 08:38:28PM +0100, Mark Brown wrote:
> As pointed out by Arnd Bergmann there is a get_signal macro definied in
> linux/signal.h which can conflict with the platform data callback
> function of the same name leading to confusing errors from the compiler
> (especially if signal.h manages to get pulled into the driver itself due
> to header dependencies). Avoid such errors by renaming get_signal and
> put_signal in the platform data to get_xfer_signal and put_xfer_signal.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2013-06-21 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 19:38 [PATCH] dmaengine: PL08x: Avoid collisions with get_signal() macro Mark Brown
2013-06-19 19:38 ` Mark Brown
2013-06-19 21:52 ` Arnd Bergmann
2013-06-19 21:52 ` Arnd Bergmann
2013-06-21 6:01 ` Vinod Koul [this message]
2013-06-21 6:01 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621060158.GD23141@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.