From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/3] iommu/amd: IOMMU Error Reporting/Handling/Filtering
Date: Mon, 24 Jun 2013 09:41:17 +0200 [thread overview]
Message-ID: <20130624074117.GA26766@pd.tnic> (raw)
In-Reply-To: <20130624072648.GQ11309-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
On Mon, Jun 24, 2013 at 09:26:48AM +0200, Joerg Roedel wrote:
> On Fri, Jun 21, 2013 at 07:36:25PM +0200, Borislav Petkov wrote:
>
> > IOW, what specific functionality in EDAC are you actually thinking of?
>
> Okay, my believe until yesterday was that EDAC provides a consistent way
> to report hardware errors to userspace. That seems to be wrong. This in
> mind I think having a trace-point for that makes sense.
>
> But this trace-point must not be specific to a single IOMMU driver, I
> want it generic enough so that it can be used by all common IOMMU
> drivers to report hardware misbehaviors to userspace.
Yep, either that or you define a TRACE_EVENT_CLASS which contains common
error info which all iommu drivers report, and those which want to
report more specific information pertaining only to them, then they need
to define a tracepoint based on the iommu event class.
Check the sources for examples.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Joerg Roedel <joro@8bytes.org>
Cc: suravee.suthikulpanit@amd.com, iommu@lists.linux-foundation.org,
ddutile@redhat.com, alex.williamson@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] iommu/amd: IOMMU Error Reporting/Handling/Filtering
Date: Mon, 24 Jun 2013 09:41:17 +0200 [thread overview]
Message-ID: <20130624074117.GA26766@pd.tnic> (raw)
In-Reply-To: <20130624072648.GQ11309@8bytes.org>
On Mon, Jun 24, 2013 at 09:26:48AM +0200, Joerg Roedel wrote:
> On Fri, Jun 21, 2013 at 07:36:25PM +0200, Borislav Petkov wrote:
>
> > IOW, what specific functionality in EDAC are you actually thinking of?
>
> Okay, my believe until yesterday was that EDAC provides a consistent way
> to report hardware errors to userspace. That seems to be wrong. This in
> mind I think having a trace-point for that makes sense.
>
> But this trace-point must not be specific to a single IOMMU driver, I
> want it generic enough so that it can be used by all common IOMMU
> drivers to report hardware misbehaviors to userspace.
Yep, either that or you define a TRACE_EVENT_CLASS which contains common
error info which all iommu drivers report, and those which want to
report more specific information pertaining only to them, then they need
to define a tracepoint based on the iommu event class.
Check the sources for examples.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-06-24 7:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 19:15 [PATCH 0/3] iommu/amd: IOMMU Error Reporting/Handling/Filtering suravee.suthikulpanit-5C7GfCeVMHo
2013-05-22 19:15 ` suravee.suthikulpanit
2013-05-22 19:15 ` [PATCH 1/3] iommu/amd: Adding amd_iommu_log cmdline option suravee.suthikulpanit
2013-05-22 19:15 ` suravee.suthikulpanit
[not found] ` <1369250155-12226-1-git-send-email-suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2013-05-22 19:15 ` [PATCH 2/3] iommu/amd: Add error handling/reporting/filtering logic suravee.suthikulpanit-5C7GfCeVMHo
2013-05-22 19:15 ` suravee.suthikulpanit
2013-05-22 19:15 ` [PATCH 3/3] iommu/amd: Remove old event printing logic suravee.suthikulpanit-5C7GfCeVMHo
2013-05-22 19:15 ` suravee.suthikulpanit
2013-06-04 5:27 ` [PATCH 0/3] iommu/amd: IOMMU Error Reporting/Handling/Filtering Suravee Suthikulpanit
2013-06-04 5:27 ` Suravee Suthikulpanit
2013-06-21 15:15 ` Joerg Roedel
2013-06-21 15:15 ` Joerg Roedel
[not found] ` <20130621151459.GK11309-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-06-21 15:59 ` Borislav Petkov
2013-06-21 15:59 ` Borislav Petkov
[not found] ` <20130621155933.GA24385-fF5Pk5pvG8Y@public.gmane.org>
2013-06-21 16:24 ` Joerg Roedel
2013-06-21 16:24 ` Joerg Roedel
[not found] ` <20130621162455.GN11309-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-06-21 16:44 ` Shuah Khan
2013-06-21 16:44 ` Shuah Khan
2013-06-21 17:36 ` Borislav Petkov
2013-06-21 17:36 ` Borislav Petkov
[not found] ` <20130621173625.GH22006-fF5Pk5pvG8Y@public.gmane.org>
2013-06-24 7:26 ` Joerg Roedel
2013-06-24 7:26 ` Joerg Roedel
[not found] ` <20130624072648.GQ11309-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-06-24 7:41 ` Borislav Petkov [this message]
2013-06-24 7:41 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624074117.GA26766@pd.tnic \
--to=bp-gina5biwoiwzqb+pc5nmwq@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.