From: Gleb Natapov <gleb@redhat.com>
To: "Ren, Yongjie" <yongjie.ren@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 1/3] x86-run: correct a typo 'qemsystem' -> 'qemusystem'
Date: Mon, 24 Jun 2013 11:03:13 +0300 [thread overview]
Message-ID: <20130624080313.GA18508@redhat.com> (raw)
In-Reply-To: <1B4B44D9196EFF41AE41FDA404FC0A1001B1DAB6@SHSMSX102.ccr.corp.intel.com>
On Mon, Jun 24, 2013 at 06:10:59AM +0000, Ren, Yongjie wrote:
> x86-run: correct a typo 'qemsystem' -> 'qemusystem'
> Before this fix, you should always get error info as below when running 'x86-run' script.
> "QEMU binary has no support for test device. Exiting."
>
Patch is whitespace damaged.
> Signed-off-by: Yongjie Ren <yongjie.ren@intel.com>
> ---
> x86-run | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86-run b/x86-run
> index 2cf1f38..9526a0b 100755
> --- a/x86-run
> +++ b/x86-run
> @@ -8,7 +8,7 @@ then
> qemu="${qemukvm}"
> else
> if
> - ${qemsystem} -device '?' 2>&1 | fgrep -e \"testdev\" -e \"pc-testdev\" > /dev/null;
> + ${qemusystem} -device '?' 2>&1 | fgrep -e \"testdev\" -e \"pc-testdev\" > /dev/null;
While you are at is lets replace fgrep invocation, which is deprecated,
with grep -F.
> then
> qemu="${qemusystem}"
> else
> --
> 1.7.9.5
--
Gleb.
next prev parent reply other threads:[~2013-06-24 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 6:10 [PATCH kvm-unit-tests 1/3] x86-run: correct a typo 'qemsystem' -> 'qemusystem' Ren, Yongjie
2013-06-24 8:03 ` Gleb Natapov [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-24 8:17 Ren, Yongjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624080313.GA18508@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yongjie.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.