From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH 2/2] fb: fix atyfb unused data warnings
Date: Mon, 24 Jun 2013 14:37:37 +0000 [thread overview]
Message-ID: <20130624143737.GI305@game.jcrosoft.org> (raw)
In-Reply-To: <51C26B56.20802@infradead.org>
On 19:39 Wed 19 Jun , Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix compiler warnings of data defined but not used. They are only used
> with certain kconfig settings.
>
> drivers/video/aty/atyfb_base.c:534:13: warning: 'ram_dram' defined but not used [-Wunused-variable]
> drivers/video/aty/atyfb_base.c:535:13: warning: 'ram_resv' defined but not used [-Wunused-variable]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: linux-fbdev@vger.kernel.org
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> drivers/video/aty/atyfb_base.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20130619.orig/drivers/video/aty/atyfb_base.c
> +++ linux-next-20130619/drivers/video/aty/atyfb_base.c
> @@ -531,8 +531,10 @@ static int correct_chipset(struct atyfb_
> return 0;
> }
>
> +#if defined(CONFIG_FB_ATY_GX) || defined(CONFIG_FB_ATY_CT)
> static char ram_dram[] = "DRAM";
> static char ram_resv[] = "RESV";
use __maybe_unused macro instead of the ifdef
> +#endif
> #ifdef CONFIG_FB_ATY_GX
> static char ram_vram[] = "VRAM";
> #endif /* CONFIG_FB_ATY_GX */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH 2/2] fb: fix atyfb unused data warnings
Date: Mon, 24 Jun 2013 16:37:37 +0200 [thread overview]
Message-ID: <20130624143737.GI305@game.jcrosoft.org> (raw)
In-Reply-To: <51C26B56.20802@infradead.org>
On 19:39 Wed 19 Jun , Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix compiler warnings of data defined but not used. They are only used
> with certain kconfig settings.
>
> drivers/video/aty/atyfb_base.c:534:13: warning: 'ram_dram' defined but not used [-Wunused-variable]
> drivers/video/aty/atyfb_base.c:535:13: warning: 'ram_resv' defined but not used [-Wunused-variable]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: linux-fbdev@vger.kernel.org
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> drivers/video/aty/atyfb_base.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20130619.orig/drivers/video/aty/atyfb_base.c
> +++ linux-next-20130619/drivers/video/aty/atyfb_base.c
> @@ -531,8 +531,10 @@ static int correct_chipset(struct atyfb_
> return 0;
> }
>
> +#if defined(CONFIG_FB_ATY_GX) || defined(CONFIG_FB_ATY_CT)
> static char ram_dram[] = "DRAM";
> static char ram_resv[] = "RESV";
use __maybe_unused macro instead of the ifdef
> +#endif
> #ifdef CONFIG_FB_ATY_GX
> static char ram_vram[] = "VRAM";
> #endif /* CONFIG_FB_ATY_GX */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-24 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 2:39 [PATCH 2/2] fb: fix atyfb unused data warnings Randy Dunlap
2013-06-20 2:39 ` Randy Dunlap
2013-06-24 14:37 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-06-24 14:37 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-24 17:54 ` [PATCH 2/2 v2] " Randy Dunlap
2013-06-24 17:54 ` Randy Dunlap
2013-06-26 12:15 ` Tomi Valkeinen
2013-06-26 12:15 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624143737.GI305@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rdunlap@infradead.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.