From: Mike Turquette <mturquette@linaro.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-tegra@vger.kernel.org, Olof Johansson <olof@lixom.net>,
Stephen Warren <swarren@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: tegra: fix ifdef for tegra_periph_reset_assert inline
Date: Mon, 24 Jun 2013 14:03:33 -0700 [thread overview]
Message-ID: <20130624210333.23972.95491@quantum> (raw)
In-Reply-To: <1372100756-10448-1-git-send-email-swarren@wwwdotorg.org>
Quoting Stephen Warren (2013-06-24 12:05:56)
> From: Stephen Warren <swarren@nvidia.com>
>
> Commit 7064f6b "clk: tegra: provide tegra_periph_reset_assert
> alternative" added ifdef'd static inline versions of some functions,
> but tested ARCH_TEGRA rather than CONFIG_ARCH_TEGRA, thus disabling
> these function in all cases. In some cases, this caused HW modules to
> misbehave; for example, the Tegra I2C driver BUG()d during boot on
> Seaboard.
>
> Reported-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Thanks for the fixup. I had already published the offending commit and
can't rebase it, so I just applied this patch on top.
Pulled into clk-next for 3.11.
Regards,
Mike
> ---
> include/linux/clk/tegra.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/clk/tegra.h b/include/linux/clk/tegra.h
> index e3cc872..23a0cee 100644
> --- a/include/linux/clk/tegra.h
> +++ b/include/linux/clk/tegra.h
> @@ -120,7 +120,7 @@ static inline void tegra_cpu_clock_resume(void)
> }
> #endif
>
> -#ifdef ARCH_TEGRA
> +#ifdef CONFIG_ARCH_TEGRA
> void tegra_periph_reset_deassert(struct clk *c);
> void tegra_periph_reset_assert(struct clk *c);
> #else
> --
> 1.8.1.5
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: tegra: fix ifdef for tegra_periph_reset_assert inline
Date: Mon, 24 Jun 2013 14:03:33 -0700 [thread overview]
Message-ID: <20130624210333.23972.95491@quantum> (raw)
In-Reply-To: <1372100756-10448-1-git-send-email-swarren@wwwdotorg.org>
Quoting Stephen Warren (2013-06-24 12:05:56)
> From: Stephen Warren <swarren@nvidia.com>
>
> Commit 7064f6b "clk: tegra: provide tegra_periph_reset_assert
> alternative" added ifdef'd static inline versions of some functions,
> but tested ARCH_TEGRA rather than CONFIG_ARCH_TEGRA, thus disabling
> these function in all cases. In some cases, this caused HW modules to
> misbehave; for example, the Tegra I2C driver BUG()d during boot on
> Seaboard.
>
> Reported-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Thanks for the fixup. I had already published the offending commit and
can't rebase it, so I just applied this patch on top.
Pulled into clk-next for 3.11.
Regards,
Mike
> ---
> include/linux/clk/tegra.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/clk/tegra.h b/include/linux/clk/tegra.h
> index e3cc872..23a0cee 100644
> --- a/include/linux/clk/tegra.h
> +++ b/include/linux/clk/tegra.h
> @@ -120,7 +120,7 @@ static inline void tegra_cpu_clock_resume(void)
> }
> #endif
>
> -#ifdef ARCH_TEGRA
> +#ifdef CONFIG_ARCH_TEGRA
> void tegra_periph_reset_deassert(struct clk *c);
> void tegra_periph_reset_assert(struct clk *c);
> #else
> --
> 1.8.1.5
next prev parent reply other threads:[~2013-06-24 21:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 19:05 [PATCH] clk: tegra: fix ifdef for tegra_periph_reset_assert inline Stephen Warren
2013-06-24 19:05 ` Stephen Warren
2013-06-24 21:03 ` Mike Turquette [this message]
2013-06-24 21:03 ` Mike Turquette
2013-06-27 22:59 ` Stephen Warren
2013-06-27 22:59 ` Stephen Warren
2013-06-28 22:29 ` Mike Turquette
2013-06-28 22:29 ` Mike Turquette
[not found] ` <1372100756-10448-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-24 21:07 ` Paul Walmsley
2013-06-24 21:07 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624210333.23972.95491@quantum \
--to=mturquette@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.