From: Tony Lindgren <tony@atomide.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: paul@pwsan.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 0/4] Cleanup PRM and CM regbit headers
Date: Tue, 25 Jun 2013 00:14:28 -0700 [thread overview]
Message-ID: <20130625071428.GC5523@atomide.com> (raw)
In-Reply-To: <1372076143-12955-1-git-send-email-rnayak@ti.com>
* Rajendra Nayak <rnayak@ti.com> [130624 05:24]:
> Hi,
>
> Over the years the PRM and CM headers for OMAP have been growing largely
> due to autogeneration which creates headers for complete PRM and
> CM register space, regardless of the actual usage of these registers in
> software.
Thanks for working on this. Yes most of this should no longer be needed.
> The latest master on linux-omap (which also happens to have the OMAP5 data)
> show these stats for the prm-regbits-*.h and cm-regbits-*.h alone. Not to mention
> there are other PRM/CM related headers which I am yet to look at.
>
> a0131687@ula0131687:~/oldhome/repos/github/linux$ cat arch/arm/mach-omap2/prm-regbits-*.h | wc -l
> 6285
> a0131687@ula0131687:~/oldhome/repos/github/linux$ cat arch/arm/mach-omap2/cm-regbits-*.h | wc -l
> 5556
>
> Using some simple awk/grep scripting I cleaned these headers to retain only the defines that
> are currently used and that changes the stats to this below.
>
> a0131687@ula0131687:~/oldhome/repos/github/linux$ cat arch/arm/mach-omap2/prm-regbits-*.h | wc -l
> 352
> a0131687@ula0131687:~/oldhome/repos/github/linux$ cat arch/arm/mach-omap2/cm-regbits-*.h | wc -l
> 661
>
> I am sharing this RFC just to take the discussion forward on how to handle these files, and many
> others which are also autogenerated, given we have newer SoCs coming up for which the autogen output
> ends up creating even larger files.
Yes we should get to the point where adding new SoCs is just few
hundred lines of code plus the new device drivers.
> Rajendra Nayak (4):
> ARM: OMAP2: PRM/CM: Cleanup unused header contents
> ARM: OMAP3: PRM/CM: Cleanup unused header contents
> ARM: OMAP4: PRM/CM: Cleanup unused header contents
> ARM: OMAP5: PRM/CM: Cleanup unused header contents
>
> arch/arm/mach-omap2/cm-regbits-24xx.h | 317 ----
> arch/arm/mach-omap2/cm-regbits-33xx.h | 758 ---------
> arch/arm/mach-omap2/cm-regbits-34xx.h | 631 --------
> arch/arm/mach-omap2/cm-regbits-44xx.h | 1557 -------------------
> arch/arm/mach-omap2/cm-regbits-54xx.h | 1632 -------------------
> arch/arm/mach-omap2/prm-regbits-24xx.h | 246 ---
> arch/arm/mach-omap2/prm-regbits-33xx.h | 305 ----
> arch/arm/mach-omap2/prm-regbits-34xx.h | 480 ------
> arch/arm/mach-omap2/prm-regbits-44xx.h | 2225 --------------------------
> arch/arm/mach-omap2/prm-regbits-54xx.h | 2677 --------------------------------
> 10 files changed, 10828 deletions(-)
If things build and work after applying this, I suggest we send them
as a clean-up branch right after -rc1.
It seems that build testing and then randconfig testing
should be enough for these if they are unused and only
removal.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 0/4] Cleanup PRM and CM regbit headers
Date: Tue, 25 Jun 2013 00:14:28 -0700 [thread overview]
Message-ID: <20130625071428.GC5523@atomide.com> (raw)
In-Reply-To: <1372076143-12955-1-git-send-email-rnayak@ti.com>
* Rajendra Nayak <rnayak@ti.com> [130624 05:24]:
> Hi,
>
> Over the years the PRM and CM headers for OMAP have been growing largely
> due to autogeneration which creates headers for complete PRM and
> CM register space, regardless of the actual usage of these registers in
> software.
Thanks for working on this. Yes most of this should no longer be needed.
> The latest master on linux-omap (which also happens to have the OMAP5 data)
> show these stats for the prm-regbits-*.h and cm-regbits-*.h alone. Not to mention
> there are other PRM/CM related headers which I am yet to look at.
>
> a0131687 at ula0131687:~/oldhome/repos/github/linux$ cat arch/arm/mach-omap2/prm-regbits-*.h | wc -l
> 6285
> a0131687 at ula0131687:~/oldhome/repos/github/linux$ cat arch/arm/mach-omap2/cm-regbits-*.h | wc -l
> 5556
>
> Using some simple awk/grep scripting I cleaned these headers to retain only the defines that
> are currently used and that changes the stats to this below.
>
> a0131687 at ula0131687:~/oldhome/repos/github/linux$ cat arch/arm/mach-omap2/prm-regbits-*.h | wc -l
> 352
> a0131687 at ula0131687:~/oldhome/repos/github/linux$ cat arch/arm/mach-omap2/cm-regbits-*.h | wc -l
> 661
>
> I am sharing this RFC just to take the discussion forward on how to handle these files, and many
> others which are also autogenerated, given we have newer SoCs coming up for which the autogen output
> ends up creating even larger files.
Yes we should get to the point where adding new SoCs is just few
hundred lines of code plus the new device drivers.
> Rajendra Nayak (4):
> ARM: OMAP2: PRM/CM: Cleanup unused header contents
> ARM: OMAP3: PRM/CM: Cleanup unused header contents
> ARM: OMAP4: PRM/CM: Cleanup unused header contents
> ARM: OMAP5: PRM/CM: Cleanup unused header contents
>
> arch/arm/mach-omap2/cm-regbits-24xx.h | 317 ----
> arch/arm/mach-omap2/cm-regbits-33xx.h | 758 ---------
> arch/arm/mach-omap2/cm-regbits-34xx.h | 631 --------
> arch/arm/mach-omap2/cm-regbits-44xx.h | 1557 -------------------
> arch/arm/mach-omap2/cm-regbits-54xx.h | 1632 -------------------
> arch/arm/mach-omap2/prm-regbits-24xx.h | 246 ---
> arch/arm/mach-omap2/prm-regbits-33xx.h | 305 ----
> arch/arm/mach-omap2/prm-regbits-34xx.h | 480 ------
> arch/arm/mach-omap2/prm-regbits-44xx.h | 2225 --------------------------
> arch/arm/mach-omap2/prm-regbits-54xx.h | 2677 --------------------------------
> 10 files changed, 10828 deletions(-)
If things build and work after applying this, I suggest we send them
as a clean-up branch right after -rc1.
It seems that build testing and then randconfig testing
should be enough for these if they are unused and only
removal.
Regards,
Tony
next prev parent reply other threads:[~2013-06-25 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 12:15 [RFC 0/4] Cleanup PRM and CM regbit headers Rajendra Nayak
2013-06-24 12:15 ` Rajendra Nayak
2013-06-24 12:15 ` [RFC 1/4] ARM: OMAP2: PRM/CM: Cleanup unused header contents Rajendra Nayak
2013-06-24 12:15 ` [RFC 2/4] ARM: OMAP3: " Rajendra Nayak
2013-06-25 7:14 ` Tony Lindgren [this message]
2013-06-25 7:14 ` [RFC 0/4] Cleanup PRM and CM regbit headers Tony Lindgren
2013-06-25 8:43 ` Rajendra Nayak
2013-06-25 8:43 ` Rajendra Nayak
2013-07-04 11:58 ` Tony Lindgren
2013-07-04 11:58 ` Tony Lindgren
2013-07-04 12:14 ` Rajendra Nayak
2013-07-04 12:14 ` Rajendra Nayak
2013-07-04 16:44 ` Paul Walmsley
2013-07-04 16:44 ` Paul Walmsley
2013-07-05 5:43 ` Rajendra Nayak
2013-07-05 5:43 ` Rajendra Nayak
2013-07-05 7:03 ` Tony Lindgren
2013-07-05 7:03 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625071428.GC5523@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.