From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, cornelia.huck@de.ibm.com,
mtosatti@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
linux-s390@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs
Date: Tue, 25 Jun 2013 11:09:28 +0200 [thread overview]
Message-ID: <20130625090928.GA8981@osiris> (raw)
In-Reply-To: <51C94599.1020707@asianux.com>
On Tue, Jun 25, 2013 at 03:24:09PM +0800, Chen Gang wrote:
> On 06/25/2013 02:48 PM, Heiko Carstens wrote:
> > On Tue, Jun 25, 2013 at 09:46:45AM +0800, Chen Gang wrote:
> >> > When smp_add_present_cpu() fails, it has reset all things excluding
> >> > 'c->hotpluggable', so need reset it as original state completely.
> >> >
> >> > + c->hotpluggable = 0;
> >> > return rc;
> > No, that doesn't make sense. All cpus on s390 are always hotplugable.
> > It really doesn't matter if the value of this field is 0 or 1 after
> > an error.
> >
>
> If so, is it better to set 'c->hotpluggable' for all cpus on s390 during
> initializing ?
No, just leave the code as it is.
next prev parent reply other threads:[~2013-06-25 9:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 1:46 [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs Chen Gang
2013-06-25 1:54 ` [Suggestion] arch: s390: mm: the warnings with allmodconfig and "EXTRA_CFLAGS=-W" Chen Gang
2013-06-25 1:54 ` Chen Gang
2013-06-25 1:54 ` Chen Gang
2013-06-25 6:50 ` Martin Schwidefsky
2013-06-25 6:50 ` Martin Schwidefsky
2013-06-25 7:25 ` Chen Gang
2013-06-25 7:25 ` Chen Gang
2013-06-25 6:48 ` [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs Heiko Carstens
2013-06-25 7:24 ` Chen Gang
2013-06-25 9:09 ` Heiko Carstens [this message]
2013-06-25 9:31 ` Chen Gang
2013-06-26 1:44 ` Chen Gang
2013-06-27 2:43 ` [PATCH v2] arch: s390: kernel: scan all present cpu forcely Chen Gang
2013-06-27 8:18 ` Heiko Carstens
2013-06-27 9:22 ` Chen Gang
2013-06-28 1:23 ` [PATCH] include/linux/interrupt.h: add dummy irq_set_irq_wake() for "!GENERIC_HARDIRQS" Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625090928.GA8981@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gang.chen@asianux.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mtosatti@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.