From: Chen Gang <gang.chen@asianux.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, cornelia.huck@de.ibm.com,
mtosatti@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
linux-s390@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: [PATCH v2] arch: s390: kernel: scan all present cpu forcely.
Date: Thu, 27 Jun 2013 10:43:02 +0800 [thread overview]
Message-ID: <51CBA6B6.1010809@asianux.com> (raw)
In-Reply-To: <20130625090928.GA8981@osiris>
The architectures which may support 'hotpluggable', can scan all cpus
during subsys_initcall(). the upper caller will skip the return value.
It also can initialize hotpluggable flag of all cpus in time, no matter
whether any cpus fail or not.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/s390/kernel/smp.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c
index d386c4e..75a118f 100644
--- a/arch/s390/kernel/smp.c
+++ b/arch/s390/kernel/smp.c
@@ -1064,8 +1064,9 @@ static int __init s390_smp_init(void)
#endif
for_each_present_cpu(cpu) {
rc = smp_add_present_cpu(cpu);
- if (rc)
- return rc;
+ if (unlikely(rc))
+ printk(KERN_WARNING "%s: add cpu %d failed (%d)\n",
+ __func__, cpu, rc);
}
return 0;
}
--
1.7.7.6
next prev parent reply other threads:[~2013-06-27 2:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 1:46 [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs Chen Gang
2013-06-25 1:54 ` [Suggestion] arch: s390: mm: the warnings with allmodconfig and "EXTRA_CFLAGS=-W" Chen Gang
2013-06-25 1:54 ` Chen Gang
2013-06-25 1:54 ` Chen Gang
2013-06-25 6:50 ` Martin Schwidefsky
2013-06-25 6:50 ` Martin Schwidefsky
2013-06-25 7:25 ` Chen Gang
2013-06-25 7:25 ` Chen Gang
2013-06-25 6:48 ` [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs Heiko Carstens
2013-06-25 7:24 ` Chen Gang
2013-06-25 9:09 ` Heiko Carstens
2013-06-25 9:31 ` Chen Gang
2013-06-26 1:44 ` Chen Gang
2013-06-27 2:43 ` Chen Gang [this message]
2013-06-27 8:18 ` [PATCH v2] arch: s390: kernel: scan all present cpu forcely Heiko Carstens
2013-06-27 9:22 ` Chen Gang
2013-06-28 1:23 ` [PATCH] include/linux/interrupt.h: add dummy irq_set_irq_wake() for "!GENERIC_HARDIRQS" Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CBA6B6.1010809@asianux.com \
--to=gang.chen@asianux.com \
--cc=cornelia.huck@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mtosatti@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.