From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@linaro.org, hpa@linux.intel.com, tglx@linutronix.de,
matt.fleming@intel.com
Subject: Re: [PATCH 3/4] arm: Add [U]EFI runtime services support
Date: Tue, 25 Jun 2013 19:20:21 +0100 [thread overview]
Message-ID: <20130625182021.GA29955@srcf.ucam.org> (raw)
In-Reply-To: <1372183863-11333-4-git-send-email-leif.lindholm@linaro.org>
On Tue, Jun 25, 2013 at 07:11:02PM +0100, Leif Lindholm wrote:
> This patch implements basic support for UEFI runtime services in the
> ARM architecture - a requirement for using efibootmgr to read and update
> the system boot configuration.
>
> It also locates any presented SMBIOS configuration table and stores it
> for potential later use by DMI.
This appears to duplicate code that's already duplicated between x86 and
ia64. We made a mistake there originally - let's not do it again. Having
this code in three places is inevitably going to lead to skew and missed
bugfixes.
--
Matthew Garrett | mjg59@srcf.ucam.org
WARNING: multiple messages have this Message-ID (diff)
From: mjg59@srcf.ucam.org (Matthew Garrett)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] arm: Add [U]EFI runtime services support
Date: Tue, 25 Jun 2013 19:20:21 +0100 [thread overview]
Message-ID: <20130625182021.GA29955@srcf.ucam.org> (raw)
In-Reply-To: <1372183863-11333-4-git-send-email-leif.lindholm@linaro.org>
On Tue, Jun 25, 2013 at 07:11:02PM +0100, Leif Lindholm wrote:
> This patch implements basic support for UEFI runtime services in the
> ARM architecture - a requirement for using efibootmgr to read and update
> the system boot configuration.
>
> It also locates any presented SMBIOS configuration table and stores it
> for potential later use by DMI.
This appears to duplicate code that's already duplicated between x86 and
ia64. We made a mistake there originally - let's not do it again. Having
this code in three places is inevitably going to lead to skew and missed
bugfixes.
--
Matthew Garrett | mjg59 at srcf.ucam.org
next prev parent reply other threads:[~2013-06-25 18:20 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 18:10 [PATCH 0/4] arm: [U]EFI runtime services support Leif Lindholm
2013-06-25 18:10 ` Leif Lindholm
2013-06-25 18:11 ` [PATCH 1/4] Documentation: arm: [U]EFI runtime services Leif Lindholm
2013-06-25 18:11 ` Leif Lindholm
[not found] ` <1372183863-11333-2-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-25 18:46 ` Christopher Covington
2013-06-25 18:46 ` Christopher Covington
2013-06-25 18:46 ` Christopher Covington
2013-06-25 23:42 ` Stephen Warren
2013-06-25 23:42 ` Stephen Warren
2013-06-25 23:42 ` Stephen Warren
[not found] ` <51CA2B03.4080106-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-26 13:20 ` Grant Likely
2013-06-26 13:20 ` Grant Likely
2013-06-26 13:20 ` Grant Likely
[not found] ` <CACxGe6vsBKnbipR-Zd1T9Ox1J2ugFmShrGXGUzPa_=D9TJvFQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-26 13:53 ` Leif Lindholm
2013-06-26 13:53 ` Leif Lindholm
2013-06-26 13:53 ` Leif Lindholm
[not found] ` <20130626135311.GA9078-GZEopFhza0F985/tl1ce8aaDwS/vmuI7@public.gmane.org>
2013-06-26 13:59 ` Matt Fleming
2013-06-26 13:59 ` Matt Fleming
2013-06-26 13:59 ` Matt Fleming
2013-06-26 14:38 ` James Bottomley
2013-06-26 14:38 ` James Bottomley
2013-06-27 1:32 ` Matthew Garrett
2013-06-27 1:32 ` Matthew Garrett
2013-06-27 6:23 ` Grant Likely
2013-06-27 6:23 ` Grant Likely
2013-06-27 6:33 ` James Bottomley
2013-06-27 6:33 ` James Bottomley
2013-06-27 6:33 ` James Bottomley
2013-06-27 14:37 ` Matthew Garrett
2013-06-27 14:37 ` Matthew Garrett
2013-06-27 15:09 ` James Bottomley
2013-06-27 15:09 ` James Bottomley
2013-06-27 15:37 ` Grant Likely
2013-06-27 15:37 ` Grant Likely
2013-06-27 15:37 ` Grant Likely
2013-06-27 17:28 ` Matthew Garrett
2013-06-27 17:28 ` Matthew Garrett
2013-06-27 14:54 ` Grant Likely
2013-06-27 14:54 ` Grant Likely
2013-06-27 14:54 ` Grant Likely
2013-06-27 15:04 ` James Bottomley
2013-06-27 15:04 ` James Bottomley
2013-06-27 18:32 ` Russell King - ARM Linux
2013-06-27 18:32 ` Russell King - ARM Linux
2013-06-27 18:32 ` Russell King - ARM Linux
2013-06-27 9:00 ` Leif Lindholm
2013-06-27 9:00 ` Leif Lindholm
[not found] ` <20130627090050.GC18151-GZEopFhza0F985/tl1ce8aaDwS/vmuI7@public.gmane.org>
2013-06-27 14:38 ` Matthew Garrett
2013-06-27 14:38 ` Matthew Garrett
2013-06-27 14:38 ` Matthew Garrett
2013-06-27 18:32 ` H. Peter Anvin
2013-06-27 18:32 ` H. Peter Anvin
2013-06-26 18:32 ` Stephen Warren
2013-06-26 18:32 ` Stephen Warren
2013-06-26 19:31 ` Leif Lindholm
2013-06-26 19:31 ` Leif Lindholm
[not found] ` <20130626193158.GF9078-GZEopFhza0F985/tl1ce8aaDwS/vmuI7@public.gmane.org>
2013-06-27 18:04 ` Stephen Warren
2013-06-27 18:04 ` Stephen Warren
2013-06-27 18:04 ` Stephen Warren
2013-06-27 20:11 ` Grant Likely
2013-06-27 20:11 ` Grant Likely
2013-06-30 3:21 ` Rob Landley
2013-06-30 3:21 ` Rob Landley
2013-06-30 3:21 ` Rob Landley
2013-06-26 13:13 ` Grant Likely
2013-06-26 13:13 ` Grant Likely
[not found] ` <CACxGe6tUpo31p6N0BZt_jdonuPP8ijvLBygC76wQ044EFsqOwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-26 14:04 ` Leif Lindholm
2013-06-26 14:04 ` Leif Lindholm
2013-06-26 14:04 ` Leif Lindholm
[not found] ` <20130626140459.GB9078-GZEopFhza0F985/tl1ce8aaDwS/vmuI7@public.gmane.org>
2013-06-26 14:35 ` Grant Likely
2013-06-26 14:35 ` Grant Likely
2013-06-26 14:35 ` Grant Likely
2013-06-27 14:22 ` Arnd Bergmann
2013-06-27 14:22 ` Arnd Bergmann
2013-06-27 14:22 ` Arnd Bergmann
2013-06-25 18:11 ` [PATCH 2/4] x86: efi: break efi_lookup_mapped_addr out to generic code Leif Lindholm
2013-06-25 18:11 ` Leif Lindholm
2013-06-26 13:30 ` Grant Likely
2013-06-26 13:30 ` Grant Likely
[not found] ` <1372183863-11333-3-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-26 13:32 ` Matt Fleming
2013-06-26 13:32 ` Matt Fleming
2013-06-26 13:32 ` Matt Fleming
[not found] ` <20130626133217.GO22026-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-26 14:11 ` Leif Lindholm
2013-06-26 14:11 ` Leif Lindholm
2013-06-26 14:11 ` Leif Lindholm
2013-06-26 14:40 ` Matt Fleming
2013-06-26 14:40 ` Matt Fleming
[not found] ` <1372183863-11333-1-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-25 18:11 ` [PATCH 3/4] arm: Add [U]EFI runtime services support Leif Lindholm
2013-06-25 18:11 ` Leif Lindholm
2013-06-25 18:11 ` Leif Lindholm
2013-06-25 18:20 ` Matthew Garrett [this message]
2013-06-25 18:20 ` Matthew Garrett
[not found] ` <20130625182021.GA29955-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-06-26 13:46 ` Grant Likely
2013-06-26 13:46 ` Grant Likely
2013-06-26 13:46 ` Grant Likely
[not found] ` <1372183863-11333-4-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-26 13:46 ` Grant Likely
2013-06-26 13:46 ` Grant Likely
2013-06-26 13:46 ` Grant Likely
[not found] ` <CACxGe6sH4dAVryBp7TeUmrwsJmnMdLsQm++U4EVDJVNi9pnqYw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-26 13:54 ` Matt Fleming
2013-06-26 13:54 ` Matt Fleming
2013-06-26 13:54 ` Matt Fleming
[not found] ` <20130626135417.GP22026-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-26 14:15 ` Borislav Petkov
2013-06-26 14:15 ` Borislav Petkov
2013-06-26 14:15 ` Borislav Petkov
2013-06-26 14:35 ` Grant Likely
2013-06-26 14:35 ` Grant Likely
2013-06-26 14:22 ` Leif Lindholm
2013-06-26 14:22 ` Leif Lindholm
2013-06-26 14:22 ` Leif Lindholm
2013-06-25 18:11 ` [PATCH 4/4] init: efi: arm: enable (U)EFI runtime services on arm Leif Lindholm
2013-06-25 18:11 ` Leif Lindholm
[not found] ` <1372183863-11333-5-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-26 13:24 ` Grant Likely
2013-06-26 13:24 ` Grant Likely
2013-06-26 13:24 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625182021.GA29955@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=hpa@linux.intel.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=patches@linaro.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.