From: Thierry Reding <thierry.reding@gmail.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: grant.likely@linaro.org, rob.herring@calxeda.com,
tomasz.figa@gmail.com, yongjun_wei@trendmicro.com.cn,
Kukjin Kim <kgene.kim@samsung.com>,
linux-pwm@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH -next] pwm: samsung: fix return value check in pwm_samsung_probe()
Date: Wed, 26 Jun 2013 11:46:05 +0200 [thread overview]
Message-ID: <20130626094604.GA9794@mithrandir> (raw)
In-Reply-To: <CAPgLHd8g2ChKSfyGUkFWBB-Z_6At2awyMAMRvA1fTvmCmeea+g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
On Wed, Jun 26, 2013 at 06:55:18AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/pwm/pwm-samsung.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Missed another one of those. Given that this isn't merged yet, would you
mind if Tomasz and/or Kukjin squash it into their patch?
If that's okay with Wei, can you, Tomasz or Kukjin, make sure to credit
Wei properly?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Wei Yongjun <weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH -next] pwm: samsung: fix return value check in pwm_samsung_probe()
Date: Wed, 26 Jun 2013 11:46:05 +0200 [thread overview]
Message-ID: <20130626094604.GA9794@mithrandir> (raw)
In-Reply-To: <CAPgLHd8g2ChKSfyGUkFWBB-Z_6At2awyMAMRvA1fTvmCmeea+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 762 bytes --]
On Wed, Jun 26, 2013 at 06:55:18AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
> ---
> drivers/pwm/pwm-samsung.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Missed another one of those. Given that this isn't merged yet, would you
mind if Tomasz and/or Kukjin squash it into their patch?
If that's okay with Wei, can you, Tomasz or Kukjin, make sure to credit
Wei properly?
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2013-06-26 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 22:55 [PATCH -next] pwm: samsung: fix return value check in pwm_samsung_probe() Wei Yongjun
2013-06-25 22:55 ` Wei Yongjun
2013-06-26 9:46 ` Thierry Reding [this message]
2013-06-26 9:46 ` Thierry Reding
2013-06-26 9:56 ` Wei Yongjun
2013-06-26 9:56 ` Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626094604.GA9794@mithrandir \
--to=thierry.reding@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-pwm@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tomasz.figa@gmail.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.