From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 04/23] ARM: dt: tegra30: Register AHB/IOMMU device first
Date: Wed, 26 Jun 2013 12:45:14 +0200 [thread overview]
Message-ID: <20130626104514.GJ27083@manwe> (raw)
In-Reply-To: <1372238906-9346-5-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On Wed, Jun 26, 2013 at 12:28:07PM +0300, Hiroshi Doyu wrote:
> Move up AHB/IOMMU to register them earlier than others. IOMMU needs
> AHB, and IOMMU needs to register all platform devices as
> IOMMU'able. So AHB/IOMMU needs to be instanciated at very beginning.
>
> Signed-off-by: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> arch/arm/boot/dts/tegra30.dtsi | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
This just happens to work because DTC keeps the order from the DTS in
the DTB and the Linux implementation sequentially instantiates devices
from DT nodes. Neither should be assumed though when writing DTS files.
Other implementations (DTC or OS) could do things differently.
But if I understand correctly there is another solution which should
solve this issue properly.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/23] ARM: dt: tegra30: Register AHB/IOMMU device first
Date: Wed, 26 Jun 2013 12:45:14 +0200 [thread overview]
Message-ID: <20130626104514.GJ27083@manwe> (raw)
In-Reply-To: <1372238906-9346-5-git-send-email-hdoyu@nvidia.com>
On Wed, Jun 26, 2013 at 12:28:07PM +0300, Hiroshi Doyu wrote:
> Move up AHB/IOMMU to register them earlier than others. IOMMU needs
> AHB, and IOMMU needs to register all platform devices as
> IOMMU'able. So AHB/IOMMU needs to be instanciated at very beginning.
>
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
> ---
> arch/arm/boot/dts/tegra30.dtsi | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
This just happens to work because DTC keeps the order from the DTS in
the DTB and the Linux implementation sequentially instantiates devices
from DT nodes. Neither should be assumed though when writing DTS files.
Other implementations (DTC or OS) could do things differently.
But if I understand correctly there is another solution which should
solve this issue properly.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/93649077/attachment-0001.sig>
next prev parent reply other threads:[~2013-06-26 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 9:28 [PATCH 04/23] ARM: dt: tegra30: Register AHB/IOMMU device first Hiroshi Doyu
2013-06-26 9:28 ` Hiroshi Doyu
[not found] ` <1372238906-9346-5-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-26 10:45 ` Thierry Reding [this message]
2013-06-26 10:45 ` Thierry Reding
2013-06-26 11:06 ` Hiroshi Doyu
2013-06-26 11:06 ` Hiroshi Doyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626104514.GJ27083@manwe \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.